net/packet: check length in getsockopt() called with PACKET_HDRLEN
authorAlexander Potapenko <glider@google.com>
Tue, 25 Apr 2017 16:51:46 +0000 (18:51 +0200)
committerDanny Wood <danwood76@gmail.com>
Tue, 29 Jan 2019 13:18:24 +0000 (13:18 +0000)
commit2601fa6688e053ba9ee6e39705a5a374d4eeb92e
tree1a4911afe8d386183597a70fece9996f82e9d5fe
parentd5388f059c33c8b6761e2b2dcca1241d2def4f00
net/packet: check length in getsockopt() called with PACKET_HDRLEN

commit fd2c83b35752f0a8236b976978ad4658df14a59f upstream.

In the case getsockopt() is called with PACKET_HDRLEN and optlen < 4
|val| remains uninitialized and the syscall may behave differently
depending on its value, and even copy garbage to userspace on certain
architectures. To fix this we now return -EINVAL if optlen is too small.

This bug has been detected with KMSAN.

Signed-off-by: Alexander Potapenko <glider@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Willy Tarreau <w@1wt.eu>
net/packet/af_packet.c