ext4: fix trim length underflow with small trim length
authorTao Ma <boyu.mt@taobao.com>
Mon, 11 Jul 2011 03:52:37 +0000 (23:52 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Mon, 11 Jul 2011 03:52:37 +0000 (23:52 -0400)
commit22f10457432387615fa1ae6e0375d9cacc50819b
tree9977fe8b44a0467bd9f1d942951f0382773af744
parent12706394bcaa48e3d5e19c97d7b4e5683ebb12fb
ext4: fix trim length underflow with small trim length

In 0f0a25b, we adjust 'len' with s_first_data_block - start, but
it could underflow in case blocksize=1K, fstrim_range.len=512 and
fstrim_range.start = 0. In this case, when we run the code:
len -= first_data_blk - start; len will be underflow to -1ULL.
In the end, although we are safe that last_group check later will limit
the trim to the whole volume, but that isn't what the user really want.

So this patch fix it. It also adds the check for 'start' like ext3 so that
we can break immediately if the start is invalid.

Cc: Lukas Czerner <lczerner@redhat.com>
Signed-off-by: Tao Ma <boyu.mt@taobao.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
fs/ext4/mballoc.c