staging: fix up speakup kobject mode
authorRusty Russell <rusty@rustcorp.com.au>
Tue, 1 Apr 2014 03:00:05 +0000 (13:30 +1030)
committerRusty Russell <rusty@rustcorp.com.au>
Tue, 1 Apr 2014 03:50:26 +0000 (14:20 +1030)
commit22c9bcad859d5c969289b3b37084a96c621f8f2c
treecc67e59e1ff7e575c6581b28f828a761e374aad3
parent57673c2b0baa900dddae3b9eb3d7748ebf550eb3
staging: fix up speakup kobject mode

It uses the unnecessary S_IFREG bit which broke when my
stricter-checking-for-mode patch went in.

Since we're fixing it anyway, the extra level of indirection is
confusing for readers (ROOT_W == rw-r--r-- for example).

Also, many of these are other-writable.  Is that really intended?

I'll-queue-this-patch-up-in-a-bit-by: Greg KH <greg@kroah.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
17 files changed:
drivers/staging/speakup/kobjects.c
drivers/staging/speakup/speakup.h
drivers/staging/speakup/speakup_acntpc.c
drivers/staging/speakup/speakup_acntsa.c
drivers/staging/speakup/speakup_apollo.c
drivers/staging/speakup/speakup_audptr.c
drivers/staging/speakup/speakup_bns.c
drivers/staging/speakup/speakup_decext.c
drivers/staging/speakup/speakup_decpc.c
drivers/staging/speakup/speakup_dectlk.c
drivers/staging/speakup/speakup_dtlk.c
drivers/staging/speakup/speakup_dummy.c
drivers/staging/speakup/speakup_keypc.c
drivers/staging/speakup/speakup_ltlk.c
drivers/staging/speakup/speakup_soft.c
drivers/staging/speakup/speakup_spkout.c
drivers/staging/speakup/speakup_txprt.c