genetlink: fix genlmsg_multicast() bug
authorJohannes Berg <johannes.berg@intel.com>
Thu, 21 Nov 2013 17:17:04 +0000 (18:17 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 21 Nov 2013 18:09:43 +0000 (13:09 -0500)
commit220815a9665f7deca98a09ecca655044f94cfa44
tree9708d1e73ac82cb2514a1f3305695962281c8852
parente40526cb20b5ee53419452e1f03d97092f144418
genetlink: fix genlmsg_multicast() bug

Unfortunately, I introduced a tremendously stupid bug into
genlmsg_multicast() when doing all those multicast group
changes: it adjusts the group number, but then passes it
to genlmsg_multicast_netns() which does that again.

Somehow, my tests failed to catch this, so add a warning
into genlmsg_multicast_netns() and remove the offending
group ID adjustment.

Also add a warning to the similar code in other functions
so people who misuse them are more loudly warned.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/net/genetlink.h
net/netlink/genetlink.c