[media] dvb-usb-v2: remove dvb_usb_device NULL check
authorAntti Palosaari <crope@iki.fi>
Thu, 21 Aug 2014 14:19:13 +0000 (11:19 -0300)
committerMauro Carvalho Chehab <m.chehab@samsung.com>
Tue, 2 Sep 2014 18:46:50 +0000 (15:46 -0300)
commit206ace2288449008742c8ca65f1865e51e83e442
tree7f4c3bc9df6b1824ff87c6391b312e40601fec6d
parent5cd62db71dcf3a4722959d9f90ca4c5ca09502cb
[media] dvb-usb-v2: remove dvb_usb_device NULL check

Reported by Dan Carpenter:

The patch d10d1b9ac97b: "[media] dvb_usb_v2: use dev_* logging
macros" from Jun 26, 2012, leads to the following Smatch complaint:

drivers/media/usb/dvb-usb-v2/dvb_usb_urb.c:31 dvb_usb_v2_generic_io()
 error: we previously assumed 'd' could be null (see line 29)

...
Remove whole check as it must not happen in any case. Driver is
totally broken if it does not have valid pointer to device.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Antti Palosaari <crope@iki.fi>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
drivers/media/usb/dvb-usb-v2/dvb_usb_urb.c