USB: serial: quatech2: fix use-after-free in probe error path
authorJohan Hovold <johan@kernel.org>
Sun, 8 May 2016 18:08:02 +0000 (20:08 +0200)
committerWilly Tarreau <w@1wt.eu>
Tue, 7 Jun 2016 08:42:55 +0000 (10:42 +0200)
commit1f983d0bebe54898bc35779815a23582ac38c9b7
tree5d588f517204cbfc2f9418a8b678db9eb0e4c3f2
parent550d9c436e40dd384b22f2beea93e20c2e069600
USB: serial: quatech2: fix use-after-free in probe error path

commit 028c49f5e02a257c94129cd815f7c8485f51d4ef upstream.

The interface read URB is submitted in attach, but was only unlinked by
the driver at disconnect.

In case of a late probe error (e.g. due to failed minor allocation),
disconnect is never called and we would end up with active URBs for an
unbound interface. This in turn could lead to deallocated memory being
dereferenced in the completion callback.

Fixes: f7a33e608d9a ("USB: serial: add quatech2 usb to serial driver")
Signed-off-by: Johan Hovold <johan@kernel.org>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/usb/serial/quatech2.c