dm thin metadata: remove incorrect close_device on creation error paths
authorMike Snitzer <snitzer@redhat.com>
Wed, 7 Mar 2012 19:09:41 +0000 (19:09 +0000)
committerAlasdair G Kergon <agk@redhat.com>
Wed, 7 Mar 2012 19:09:41 +0000 (19:09 +0000)
commit1f3db25d8be4ac50b897b39609802183ea68a514
treeb8e140111ba62062d309ae0dec90543f35e28172
parent1212268fd9816e3b8801e57b896fceaec71969ad
dm thin metadata: remove incorrect close_device on creation error paths

The __open_device() error paths in __create_thin() and __create_snap()
incorrectly call __close_device() even if td was not initialized by
__open_device().  Remove this.

Also document __open_device() return values, remove a redundant
td->changed = 1 in __create_thin(), and insert an additional
safeguard against creating an already-existing device.

Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Cc: stable@kernel.org
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
drivers/md/dm-thin-metadata.c