MIPS: Compat: Use 32-bit wrapper for compat_sys_futex.
authorYong Zhang <yong.zhang@windriver.com>
Tue, 16 Aug 2011 01:54:54 +0000 (09:54 +0800)
committerRalf Baechle <ralf@linux-mips.org>
Wed, 21 Sep 2011 15:53:44 +0000 (17:53 +0200)
commit1eec6cd08b4feb72a73aff468ab72bdd21e1dc61
tree70278d81550236b2dc57ddb52b3fc3380fe0c5d9
parentb8ecf341f1b7ca7bf3cb80c48cbbae33b79947d0
MIPS: Compat: Use 32-bit wrapper for compat_sys_futex.

We can't trust userspace to pass signed-extend arguments.  Not correctly
sign-extended arguments to futex-wait result in architecturally undefined
operation of 32-bit arithmetic instructions.

For example, if 'val' is too big and bit-31 is 1, the caller may enter
endless loop at:

futex_wait_setup()
{
...

if (uval != val) {
queue_unlock(q, *hb);
ret = -EWOULDBLOCK;

...
}

Signed-off-by: Yong Zhang <yong.zhang@windriver.com>
To: linux-mips@linux-mips.org
To: linux-kernel@vger.kernel.org
Patchwork: https://patchwork.linux-mips.org/patch/2714/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
arch/mips/kernel/linux32.c
arch/mips/kernel/scall64-n32.S
arch/mips/kernel/scall64-o32.S