target: Change target_submit_cmd() to return void
authorAndy Grover <agrover@redhat.com>
Thu, 19 Jan 2012 21:39:23 +0000 (13:39 -0800)
committerNicholas Bellinger <nab@linux-iscsi.org>
Tue, 7 Feb 2012 06:41:04 +0000 (06:41 +0000)
commit1edcdb497ef418122cd4f98e157660cf594b345a
treebf41780935b8996f85a0ae090897495961deb6d7
parent95fe1ee41e23fa271416da67483594dde74bc6ca
target: Change target_submit_cmd() to return void

Retval not very useful, and may even be harmful. Once submitted, fabrics
should expect a sense error if anything goes wrong. All fabrics checking
of this retval are useless or broken:

fc checks it just to emit more debug output.
ib_srpt trickles retval up, then it is ignored.
qla2xxx trickles it up, which then causes a bug because the abort goto
in qla_target.c thinks cmd hasn't been sent to target.

Just returning nothing is best.

Signed-off-by: Andy Grover <agrover@redhat.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/target_core_transport.c
drivers/target/tcm_fc/tfc_cmd.c
include/target/target_core_fabric.h