drivers/ata: Move a dereference below a NULL test
authorJulia Lawall <julia@diku.dk>
Sat, 11 Jul 2009 07:49:48 +0000 (09:49 +0200)
committerJeff Garzik <jgarzik@redhat.com>
Wed, 15 Jul 2009 02:42:51 +0000 (22:42 -0400)
commit1e1f421a8137824127a41303a30493356b5da638
treee112d0f728f33ba9376af26c703472b97a53f60b
parentd0cb43b35d64877b2944bd37719708be5d7bbf99
drivers/ata: Move a dereference below a NULL test

If the NULL test is necessary, then the dereference should be moved below
the NULL test.

The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@

- T i = E->fld;
+ T i;
  ... when != E
      when != i
  if (E == NULL) S
+ i = E->fld;
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
drivers/ata/pata_at91.c