x86/fpu: Factor out memset(xstate, 0) in fpu_finit() paths
authorOleg Nesterov <oleg@redhat.com>
Tue, 10 Mar 2015 06:06:25 +0000 (07:06 +0100)
committerIngo Molnar <mingo@kernel.org>
Tue, 10 Mar 2015 06:14:31 +0000 (07:14 +0100)
commit1d23c4518b1f3a03c278f23333149245c178d2a6
treeb21290a5adff68cb50dc85f9e208c7c0f32f28f4
parente7f180dcd8ab48f18b20d7e8a7e9b39192bdf8e0
x86/fpu: Factor out memset(xstate, 0) in fpu_finit() paths

fx_finit() has two users but only fpu_finit() needs to clear
xstate, alloc_bootmem_align() in setup_init_fpu_buf() returns
zero-filled memory.

And note that both memset()'s look confusing. Yes, offsetof() is
0 for ->fxsave or ->fsave, but it would be cleaner to turn
them into a single memset() which zeroes fpu->state.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Acked-by: Rik van Riel <riel@redhat.com>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Borislav Petkov <bp@alien8.de>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Tavis Ormandy <taviso@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/1425967585-4725-2-git-send-email-bp@alien8.de
Link: http://lkml.kernel.org/r/20150302183257.GC23085@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/include/asm/fpu-internal.h
arch/x86/kernel/i387.c