drm/tegra: Fix error handling cleanup
authorThierry Reding <treding@nvidia.com>
Thu, 6 Nov 2014 13:12:08 +0000 (14:12 +0100)
committerThierry Reding <treding@nvidia.com>
Thu, 13 Nov 2014 15:14:48 +0000 (16:14 +0100)
commit1d1e6fe9b5cd9e51c0b064b60f673a973cac38ba
tree404e5b43d88a459e749d0a749ff41b6eebf5b9fc
parent53ea72132df8dd62bb77b28df7b05074dcea96fe
drm/tegra: Fix error handling cleanup

The DRM driver's ->load() implementation didn't do a good job (no job at
all really) cleaning up on failure. Fix that by undoing any prior setup
when an error occurs. This requires a bit of rework to make it possible
to clean up fbdev midway.

This was tested by injecting errors at various points during the
initialization sequence and verifying that error cleanup didn't crash
and no memory leaked (using kmemleak).

Reported-by: Stéphane Marchesin <marcheu@chromium.org>
Reported-by: Sean Paul <seanpaul@chromium.org>
Reviewed-by: Sean Paul <seanpaul@chromium.org>
Signed-off-by: Thierry Reding <treding@nvidia.com>
drivers/gpu/drm/tegra/drm.c
drivers/gpu/drm/tegra/drm.h
drivers/gpu/drm/tegra/fb.c