net: mvneta: Fix spinlock usage
authorGregory CLEMENT <gregory.clement@free-electrons.com>
Sat, 12 Mar 2016 17:44:17 +0000 (18:44 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 14 Mar 2016 19:48:51 +0000 (15:48 -0400)
commit1c2722a975fdb8c90bc6ba8570b7fb62db4e2e9c
tree488a09415a2b84f82e3612d45694f292218197a5
parent8626c56c8279b88b91b8df55345cdf89542d5e90
net: mvneta: Fix spinlock usage

In the previous patch, the spinlock was not initialized. While it didn't
cause any trouble yet it could be a problem to use it uninitialized.

The most annoying part was the critical section protected by the spinlock
in mvneta_stop(). Some of the functions could sleep as pointed when
activated CONFIG_DEBUG_ATOMIC_SLEEP. Actually, in mvneta_stop() we only
need to protect the is_stopped flagged, indeed the code of the notifier
for CPU online is protected by the same spinlock, so when we get the
lock, the notifer work is done.

Reported-by: Patrick Uiterwijk <patrick@puiterwijk.org>
Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/marvell/mvneta.c