ACER: Fix Smatch double-free issue
authorMarek Vasut <marex@denx.de>
Wed, 4 Jul 2012 23:30:10 +0000 (01:30 +0200)
committerMatthew Garrett <mjg@redhat.com>
Sat, 28 Jul 2012 04:28:55 +0000 (00:28 -0400)
commit1bfaf1d5bcfb2ae0b7b90c5aed86909ee4f3f099
tree81ce7e33bda2146faff3da9dcc954cea73feb7f7
parent24237c43aade30758aacabbf0e462fca19c48231
ACER: Fix Smatch double-free issue

The patch 6ae3a0876185: "ACER: Add support for accelerometer sensor"
from Jun 1, 2012, leads to the following Smatch warning:
drivers/platform/x86/acer-wmi.c:1886 acer_wmi_accel_destroy()
         error: don't call input_free_device() after input_unregister_device()

drivers/platform/x86/acer-wmi.c
  1883  static void acer_wmi_accel_destroy(void)
  1884  {
  1885          input_unregister_device(acer_wmi_accel_dev);
  1886          input_free_device(acer_wmi_accel_dev);
  1887  }

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Fengguang Wu <wfg@linux.intel.com>
Cc: joeyli <jlee@suse.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
drivers/platform/x86/acer-wmi.c