drivers: dma-mapping: Do not leave an invalid area->pages pointer in dma_common_conti...
authorCatalin Marinas <catalin.marinas@arm.com>
Thu, 25 May 2017 16:26:47 +0000 (17:26 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 3 Jun 2017 09:51:12 +0000 (18:51 +0900)
commit1a3389ffc538a3a7b73335e84f33120a2f636f55
treea1abb7f86a98eb1cdc2459e3289b6ce38675d0bd
parente622ec579b9ac3a3280088b991e3a26309582b3b
drivers: dma-mapping: Do not leave an invalid area->pages pointer in dma_common_contiguous_remap()

The dma_common_pages_remap() function allocates a vm_struct object and
initialises the pages pointer to value passed as argument. However, when
this function is called dma_common_contiguous_remap(), the pages array
is only temporarily allocated, being freed shortly after
dma_common_contiguous_remap() returns. Architecture code checking the
validity of an area->pages pointer would incorrectly dereference already
freed pointers. This has been exposed by the arm64 commit 44176bb38fa4
("arm64: Add support for DMA_ATTR_FORCE_CONTIGUOUS to IOMMU").

Fixes: 513510ddba96 ("common: dma-mapping: introduce common remapping functions")
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reported-by: Andrzej Hajda <a.hajda@samsung.com>
Acked-by: Laura Abbott <labbott@redhat.com>
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/dma-mapping.c