genirq: Skip chained interrupt trigger setup if type is IRQ_TYPE_NONE
authorMarc Zyngier <marc.zyngier@arm.com>
Mon, 19 Sep 2016 08:49:27 +0000 (09:49 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Mon, 19 Sep 2016 09:31:36 +0000 (11:31 +0200)
commit1984e075915cbae65336a99b1879865080d8e55e
tree7821bac4d017d04a8b6563493bb767af11b22f74
parent3be7988674ab33565700a37b210f502563d932e6
genirq: Skip chained interrupt trigger setup if type is IRQ_TYPE_NONE

There is no point in trying to configure the trigger of a chained
interrupt if no trigger information has been configured. At best
this is ignored, and at the worse this confuses the underlying
irqchip (which is likely not to handle such a thing), and
unnecessarily alarms the user.

Only apply the configuration if type is not IRQ_TYPE_NONE.

Fixes: 1e12c4a9393b ("genirq: Correctly configure the trigger on chained interrupts")
Reported-and-tested-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Link: https://lkml.kernel.org/r/CAMuHMdVW1eTn20=EtYcJ8hkVwohaSuH_yQXrY2MGBEvZ8fpFOg@mail.gmail.com
Link: http://lkml.kernel.org/r/1474274967-15984-1-git-send-email-marc.zyngier@arm.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
kernel/irq/chip.c