media: davinci/vpbe: array underflow in vpbe_enum_outputs()
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 24 Apr 2019 09:46:27 +0000 (05:46 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 29 Jan 2020 09:24:24 +0000 (10:24 +0100)
commit190c1d6c90dc347ea55467d51b5b536ec68f4370
treee51cd69d0b8c2bf73fd2e2a5ab7c2519b4508d38
parentf222b8962fed5611bdb1b86b91fd87b4e6570495
media: davinci/vpbe: array underflow in vpbe_enum_outputs()

[ Upstream commit b72845ee5577b227131b1fef23f9d9a296621d7b ]

In vpbe_enum_outputs() we check if (temp_index >= cfg->num_outputs) but
the problem is that "temp_index" can be negative.  This patch changes
the types to unsigned to address this array underflow bug.

Fixes: 66715cdc3224 ("[media] davinci vpbe: VPBE display driver")

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/platform/davinci/vpbe.c
include/media/davinci/vpbe.h