irqchip/mmp: Only touch the PJ4 IRQ & FIQ bits on enable/disable
authorLubomir Rintel <lkundrak@v3.sk>
Mon, 28 Jan 2019 15:59:35 +0000 (16:59 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 13 Mar 2019 21:03:20 +0000 (14:03 -0700)
commit18579f6965137f4c134e22b8dd906eba8a712dfc
tree78f6ebfedb81679406aa601c49a35787e6568c46
parentecfcdee1e9d57fd0d3e38e9491510307358dc9d3
irqchip/mmp: Only touch the PJ4 IRQ & FIQ bits on enable/disable

[ Upstream commit 2380a22b60ce6f995eac806e69c66e397b59d045 ]

Resetting bit 4 disables the interrupt delivery to the "secure
processor" core. This breaks the keyboard on a OLPC XO 1.75 laptop,
where the firmware running on the "secure processor" bit-bangs the
PS/2 protocol over the GPIO lines.

It is not clear what the rest of the bits are and Marvell was unhelpful
when asked for documentation. Aside from the SP bit, there are probably
priority bits.

Leaving the unknown bits as the firmware set them up seems to be a wiser
course of action compared to just turning them off.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Acked-by: Pavel Machek <pavel@ucw.cz>
[maz: fixed-up subject and commit message]
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/irqchip/irq-mmp.c