net/core: revert "net: fix __netdev_update_features return.." and add comment
authorNikolay Aleksandrov <nikolay@cumulusnetworks.com>
Tue, 17 Nov 2015 14:49:06 +0000 (15:49 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 17 Nov 2015 20:25:45 +0000 (15:25 -0500)
commit17b85d29e82cc3c874a497a8bc5764d6a2b043e2
tree7234f1e9f3a38dff362a6efc9f775757ad9c5849
parenta3a116e04cc6a94d595ead4e956ab1bc1d2f4746
net/core: revert "net: fix __netdev_update_features return.." and add comment

This reverts commit 00ee59271777 ("net: fix __netdev_update_features return
on ndo_set_features failure")
and adds a comment explaining why it's okay to return a value other than
0 upon error. Some drivers might actually change flags and return an
error so it's better to fire a spurious notification rather than miss
these.

CC: Michał Mirosław <mirq-linux@rere.qmqm.pl>
Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/dev.c