xen/pciback: Fix conf_space read/write overlap check.
authorAndrey Grodzovsky <andrey2805@gmail.com>
Tue, 21 Jun 2016 18:26:36 +0000 (14:26 -0400)
committerDanny Wood <danwood76@gmail.com>
Tue, 29 Jan 2019 13:13:48 +0000 (13:13 +0000)
commit16ccdd1c33b3b5b6dcb6a7ac6258fbb7b1506862
tree711d5278524e571ec1915d03a7326c58e12e1d8d
parentef5795e122a92c4f5c0512389f55c76e52585d29
xen/pciback: Fix conf_space read/write overlap check.

commit 02ef871ecac290919ea0c783d05da7eedeffc10e upstream.

Current overlap check is evaluating to false a case where a filter
field is fully contained (proper subset) of a r/w request.  This
change applies classical overlap check instead to include all the
scenarios.

More specifically, for (Hilscher GmbH CIFX 50E-DP(M/S)) device driver
the logic is such that the entire confspace is read and written in 4
byte chunks. In this case as an example, CACHE_LINE_SIZE,
LATENCY_TIMER and PCI_BIST are arriving together in one call to
xen_pcibk_config_write() with offset == 0xc and size == 4.  With the
exsisting overlap check the LATENCY_TIMER field (offset == 0xd, length
== 1) is fully contained in the write request and hence is excluded
from write, which is incorrect.

Signed-off-by: Andrey Grodzovsky <andrey2805@gmail.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Reviewed-by: Jan Beulich <JBeulich@suse.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/xen/xen-pciback/conf_space.c