media: cec: only increase the seqnr if CEC_TRANSMIT would return 0
authorHans Verkuil <hverkuil@xs4all.nl>
Thu, 6 Jul 2017 14:09:52 +0000 (11:09 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Tue, 18 Jul 2017 15:37:21 +0000 (12:37 -0300)
commit15e809e961bad6c31f995100bf5e3c3f860b1b2c
treead97a2c0c8b4874856aa2ae1ab1085d94f545760
parent299708e45e75500ba40b615896806c2f0877170f
media: cec: only increase the seqnr if CEC_TRANSMIT would return 0

The transmit code would increase the sequence number first thing, even though
CEC_TRANSMIT would return an error due to a malformatted cec_msg struct later
on.

While valid behavior, this had the disadvantage of producing holes in the
sequence list that made debugging harder.

Only increase the sequence number when the whole message is validated.
When debugging (i.e. with cec-ctl -M) the sequence numbering is now nicely
increasing by 1 per message.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/cec/cec-adap.c