ath6kl: remove false check from ath6kl_rx()
authorKalle Valo <kvalo@qca.qualcomm.com>
Sun, 10 Mar 2013 05:51:39 +0000 (07:51 +0200)
committerKalle Valo <kvalo@qca.qualcomm.com>
Mon, 18 Mar 2013 11:50:19 +0000 (13:50 +0200)
commit15ac0778a65322c8c39eb2a6636218554d348690
tree887519d14cca564add1a8fadfb55f414c6957eef
parent99089ab756a26c8f1be5942178bf9b3fa9ae54d6
ath6kl: remove false check from ath6kl_rx()

Dan found a check from ath6kl_rx() which doesn't make any sense at all:

"  1327          if (status || !(skb->data + HTC_HDR_LENGTH)) {
                                ^^^^^^^^^^^^^^^^^^^^^^^^^^
skb->data is a pointer.  This pointer math is always going to be false.
Should it be testing "packet->act_len < HTC_HDR_LENGTH" or something?"

I don't know what the check really was supposed to do, but I think Dan's guess
is right. Fix it accordingly.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com>
drivers/net/wireless/ath/ath6kl/txrx.c