do_add_mount()/umount -l races
authorAl Viro <viro@zeniv.linux.org.uk>
Fri, 21 Sep 2012 12:19:02 +0000 (08:19 -0400)
committerAl Viro <viro@zeniv.linux.org.uk>
Sun, 23 Sep 2012 00:48:18 +0000 (20:48 -0400)
commit156cacb1d0d36b0d0582d9e798e58e0044f516b3
tree79eddbde8671b1899d77dcfabb3ae3e21ce39072
parentfea7a08acb13524b47711625eebea40a0ede69a0
do_add_mount()/umount -l races

normally we deal with lock_mount()/umount races by checking that
mountpoint to be is still in our namespace after lock_mount() has
been done.  However, do_add_mount() skips that check when called
with MNT_SHRINKABLE in flags (i.e. from finish_automount()).  The
reason is that ->mnt_ns may be a temporary namespace created exactly
to contain automounts a-la NFS4 referral handling.  It's not the
namespace of the caller, though, so check_mnt() would fail here.
We still need to check that ->mnt_ns is non-NULL in that case,
though.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/namespace.c