net: netxen: fix a missing check and an uninitialized use
authorKangjie Lu <kjlu@umn.edu>
Fri, 21 Dec 2018 06:22:32 +0000 (00:22 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 13 Jan 2019 09:03:50 +0000 (10:03 +0100)
commit154b7716f9aaf55a8307e464069d25cf5830f6e3
treef3f0c7bfcd2c94ac6101e3daa17b03924829f866
parent5d036c3ad4bcb100b98640e78ee2fd5f9ec634f0
net: netxen: fix a missing check and an uninitialized use

[ Upstream commit d134e486e831defd26130770181f01dfc6195f7d ]

When netxen_rom_fast_read() fails, "bios" is left uninitialized and may
contain random value, thus should not be used.

The fix ensures that if netxen_rom_fast_read() fails, we return "-EIO".

Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c