projects / GitHub / exynos8895 / android_kernel_samsung_universal8895.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 7908a9e) | patch
sata_sil24: memset() overflow
authorDan Carpenter <error27@gmail.com>
Wed, 9 Jun 2010 12:01:54 +0000 (14:01 +0200)
committerJeff Garzik <jgarzik@redhat.com>
Thu, 10 Jun 2010 20:06:33 +0000 (16:06 -0400)
commit14e45c15e1dcc4d972b41343661683efd60fed72
tree96635555f499e15ae8b0eb2a0e0d45233544f80btree | snapshot (tar.gz zip)
parent7908a9e5fc3f9a679b1777ed231a03636c068446commit | diff
sata_sil24: memset() overflow

cb->atapi.cdb is an array of 16 u8 elements.  The call too memset()
would set the first part of the sge array to zero as well.  It's not
a packed struct.

This one has been around for five years.  I found it with Smatch.  I
think the reason no one has seen it before is because we normally call
sil24_fill_sg() and that overwrites sge with proper information?

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
drivers/ata/sata_sil24.c diff | blob | blame | history