netfilter: nf_conntrack_ipv6: Plug sk_buff leak in fragment handling
authorPhil Oester <kernel@linuxace.com>
Wed, 19 Jun 2013 10:49:51 +0000 (06:49 -0400)
committerPablo Neira Ayuso <pablo@netfilter.org>
Thu, 20 Jun 2013 10:01:24 +0000 (12:01 +0200)
commit142dcdd3c25fc7a3866bb06980e8f93a2ed7e050
treeaf92eb2328b0c4d1f8632ab0d1f26145b413c58f
parent06f3d7f973ec04290d86b7dd91b48d38d90433dc
netfilter: nf_conntrack_ipv6: Plug sk_buff leak in fragment handling

In commit 4cdd3408 ("netfilter: nf_conntrack_ipv6: improve fragmentation
handling"), an sk_buff leak was introduced when dealing with reassembled
packets by grabbing a reference to the original skb instead of the
reassembled skb.  At this point, the leak only impacted conntracks with an
associated helper.

In commit 58a317f1 ("netfilter: ipv6: add IPv6 NAT support"), the bug was
expanded to include all reassembled packets with unconfirmed conntracks.

Fix this by grabbing a reference to the proper reassembled skb.  This
closes netfilter bugzilla #823.

Signed-off-by: Phil Oester <kernel@linuxace.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c