nfsd: stricter decoding of write-like NFSv2/v3 ops
authorJ. Bruce Fields <bfields@redhat.com>
Fri, 21 Apr 2017 19:26:30 +0000 (15:26 -0400)
committerJ. Bruce Fields <bfields@redhat.com>
Tue, 25 Apr 2017 20:36:23 +0000 (16:36 -0400)
commit13bf9fbff0e5e099e2b6f003a0ab8ae145436309
tree950c4317be5f1138b1659aaa535de228ea51c36c
parentdb44bac41bbfc0c0d9dd943092d8bded3c9db19b
nfsd: stricter decoding of write-like NFSv2/v3 ops

The NFSv2/v3 code does not systematically check whether we decode past
the end of the buffer.  This generally appears to be harmless, but there
are a few places where we do arithmetic on the pointers involved and
don't account for the possibility that a length could be negative.  Add
checks to catch these.

Reported-by: Tuomas Haanpää <thaan@synopsys.com>
Reported-by: Ari Kauppi <ari@synopsys.com>
Reviewed-by: NeilBrown <neilb@suse.com>
Cc: stable@vger.kernel.org
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/nfs3xdr.c
fs/nfsd/nfsxdr.c