projects / GitHub / moto-9609 / android_kernel_motorola_exynos9610.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 1a07bfb) | patch
davinci: aemif: signedness bug in davinci_aemif_setup_timing()
authorNicolas Kaiser <nikai@nikai.net>
Mon, 15 Nov 2010 18:40:28 +0000 (19:40 +0100)
committerKevin Hilman <khilman@deeprootsystems.com>
Fri, 10 Dec 2010 15:33:51 +0000 (07:33 -0800)
commit12cdd3d71954c2cd6dd556eec25dd7d346735831
tree2201eb4a1fea43603ef527321a8a7a83c46d7c67tree | snapshot (tar.gz zip)
parent1a07bfb5215e11227403f121097ed72187dc3241commit | diff
davinci: aemif: signedness bug in davinci_aemif_setup_timing()

aemif_calc_rate() can return a negative error value, so all the
variables that get tested for this value need to be signed.

The maximum bit width of WSETUP(WSETUP_MAX) appears to be 30 bits
(0xf << 26). Using a signed instead of an unsigned integer
shouldn't make a difference here.

Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
Acked-by: Sekhar Nori <nsekhar@ti.com>
Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
arch/arm/mach-davinci/aemif.c diff | blob | blame | history