firewire: fix potential uaf in outbound_phy_packet_callback()
authorChengfeng Ye <cyeaa@connect.ust.hk>
Sat, 9 Apr 2022 04:12:41 +0000 (13:12 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 12 May 2022 10:17:09 +0000 (12:17 +0200)
commit1269a6567274edecd04ee7fd7871aa4d0c937f2a
tree1f60e605d2674b00c6fc0722da68de14ac724ddb
parenta176498ec0767053a5fc279bcc8e1720a57e2eab
firewire: fix potential uaf in outbound_phy_packet_callback()

commit b7c81f80246fac44077166f3e07103affe6db8ff upstream.

&e->event and e point to the same address, and &e->event could
be freed in queue_event. So there is a potential uaf issue if
we dereference e after calling queue_event(). Fix this by adding
a temporary variable to maintain e->client in advance, this can
avoid the potential uaf issue.

Cc: <stable@vger.kernel.org>
Signed-off-by: Chengfeng Ye <cyeaa@connect.ust.hk>
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20220409041243.603210-2-o-takashi@sakamocchi.jp
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/firewire/core-cdev.c