ptrace: restore smp_rmb() in __ptrace_may_access()
authorJann Horn <jannh@google.com>
Wed, 29 May 2019 11:31:57 +0000 (13:31 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 22 Jun 2019 06:17:18 +0000 (08:17 +0200)
commit122be5afdf7ba7afd60e65d9b781353da823088e
tree34bd0b246ac3c8e1ad023fa415e343c94fbc9fd9
parent2fc1de48326fd22b1e1be4fa050fb3a710fe2327
ptrace: restore smp_rmb() in __ptrace_may_access()

commit f6581f5b55141a95657ef5742cf6a6bfa20a109f upstream.

Restore the read memory barrier in __ptrace_may_access() that was deleted
a couple years ago. Also add comments on this barrier and the one it pairs
with to explain why they're there (as far as I understand).

Fixes: bfedb589252c ("mm: Add a user_ns owner to mm_struct and fix ptrace permission checks")
Cc: stable@vger.kernel.org
Acked-by: Kees Cook <keescook@chromium.org>
Acked-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Jann Horn <jannh@google.com>
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel/cred.c
kernel/ptrace.c