dm bufio: fix memleak when using a dm_buffer's inline bio
authorDarrick J. Wong <darrick.wong@oracle.com>
Wed, 26 Nov 2014 01:45:15 +0000 (17:45 -0800)
committerDanny Wood <danwood76@gmail.com>
Tue, 29 Jan 2019 13:05:31 +0000 (13:05 +0000)
commit1197010d1229009f62878a030b7aab35691bd318
treee5093e47ac68f5971c9b9072feac87b5ee523450
parent8ba190c182046fe2c63852288ed9a5c75a4cd1ef
dm bufio: fix memleak when using a dm_buffer's inline bio

commit 445559cdcb98a141f5de415b94fd6eaccab87e6d upstream.

When dm-bufio sets out to use the bio built into a struct dm_buffer to
issue an IO, it needs to call bio_reset after it's done with the bio
so that we can free things attached to the bio such as the integrity
payload.  Therefore, inject our own endio callback to take care of
the bio_reset after calling submit_io's end_io callback.

Test case:
1. modprobe scsi_debug delay=0 dif=1 dix=199 ato=1 dev_size_mb=300
2. Set up a dm-bufio client, e.g. dm-verity, on the scsi_debug device
3. Repeatedly read metadata and watch kmalloc-192 leak!

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/md/dm-bufio.c