ALSA: vmaster: Propagate slave error
authorTakashi Iwai <tiwai@suse.de>
Thu, 8 Mar 2018 07:26:48 +0000 (08:26 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 May 2018 05:52:35 +0000 (07:52 +0200)
commit10626a0c20272741e11bfc59ccef161248bfb8fc
tree6cff289debacaece39692816fe0ee7c219a7d2b8
parentb1ebc21c146b9a4b72caf712137f940b566fa90c
ALSA: vmaster: Propagate slave error

[ Upstream commit 2e2c177ca84aff092c3c96714b0f6a12900f3946 ]

In slave_update() of vmaster code ignores the error from the slave
get() callback and copies the values.  It's not only about the missing
error code but also that this may potentially lead to a leak of
uninitialized variables when the slave get() don't clear them.

This patch fixes slave_update() not to copy the potentially
uninitialized values when an error is returned from the slave get()
callback, and to propagate the error value properly.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/core/vmaster.c