ipvlan: use rcu_deference_bh() in ipvlan_queue_xmit()
In tx path rcu_read_lock_bh() is held, so we need rcu_deference_bh().
This fixes the following warning:
===============================
[ INFO: suspicious RCU usage. ]
4.1.0-rc1+ #1007 Not tainted
-------------------------------
drivers/net/ipvlan/ipvlan.h:106 suspicious rcu_dereference_check() usage!
other info that might help us debug this:
rcu_scheduler_active = 1, debug_locks = 0
1 lock held by dhclient/1076:
#0: (rcu_read_lock_bh){......}, at: [<
ffffffff817e8d84>] rcu_lock_acquire+0x0/0x26
stack backtrace:
CPU: 2 PID: 1076 Comm: dhclient Not tainted 4.1.0-rc1+ #1007
Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011
0000000000000001 ffff8800d381bac8 ffffffff81a4154f 000000003c1a3c19
ffff8800d4d0a690 ffff8800d381baf8 ffffffff810b849f ffff880117d41148
ffff880117d40000 ffff880117d40068 0000000000000156 ffff8800d381bb18
Call Trace:
[<
ffffffff81a4154f>] dump_stack+0x4c/0x65
[<
ffffffff810b849f>] lockdep_rcu_suspicious+0x107/0x110
[<
ffffffff8165a522>] ipvlan_port_get_rcu+0x47/0x4e
[<
ffffffff8165ad14>] ipvlan_queue_xmit+0x35/0x450
[<
ffffffff817ea45d>] ? rcu_read_unlock+0x3e/0x5f
[<
ffffffff810a20bf>] ? local_clock+0x19/0x22
[<
ffffffff810b4781>] ? __lock_is_held+0x39/0x52
[<
ffffffff8165b64c>] ipvlan_start_xmit+0x1b/0x44
[<
ffffffff817edf7f>] dev_hard_start_xmit+0x2ae/0x467
[<
ffffffff817ee642>] __dev_queue_xmit+0x50a/0x60c
[<
ffffffff817ee7a7>] dev_queue_xmit_sk+0x13/0x15
[<
ffffffff81997596>] dev_queue_xmit+0x10/0x12
[<
ffffffff8199b41c>] packet_sendmsg+0xb6b/0xbdf
[<
ffffffff810b5ea7>] ? mark_lock+0x2e/0x226
[<
ffffffff810a1fcc>] ? sched_clock_cpu+0x9e/0xb7
[<
ffffffff817d56f9>] sock_sendmsg_nosec+0x12/0x1d
[<
ffffffff817d7257>] sock_sendmsg+0x29/0x2e
[<
ffffffff817d72cc>] sock_write_iter+0x70/0x91
[<
ffffffff81199563>] __vfs_write+0x7e/0xa7
[<
ffffffff811996bc>] vfs_write+0x92/0xe8
[<
ffffffff811997d7>] SyS_write+0x47/0x7e
[<
ffffffff81a4d517>] system_call_fastpath+0x12/0x6f
Fixes:
2ad7bf363841 ("ipvlan: Initial check-in of the IPVLAN driver.")
Cc: Mahesh Bandewar <maheshb@google.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Acked-by: Mahesh Bandewar <maheshb@google.com>
Acked-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>