batman-adv: avoid NULL dereferences and fix if check
authorAntonio Quartulli <antonio@meshcoding.com>
Sat, 20 Dec 2014 12:48:57 +0000 (13:48 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 24 Dec 2014 04:13:37 +0000 (23:13 -0500)
commit0d1644919578db525b9a7b6c8197ce02adbfce26
tree98dd759ca950e3d8220ff7504baba8c4bec7b7da
parent0402e444cd199389b7fe47be68a67b817e09e097
batman-adv: avoid NULL dereferences and fix if check

Gateway having bandwidth_down equal to zero are not accepted
at all and so never added to the Gateway list.
For this reason checking the bandwidth_down member in
batadv_gw_out_of_range() is useless.

This is probably a copy/paste error and this check was supposed
to be "!gw_node" only. Moreover, the way the check is written
now may also lead to a NULL dereference.

Fix this by rewriting the if-condition properly.

Introduced by 414254e342a0d58144de40c3da777521ebaeeb07
("batman-adv: tvlv - gateway download/upload bandwidth container")

Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/batman-adv/gateway_client.c