xen-netback: fix race between napi_complete() and interrupt handler
authorDavid Vrabel <david.vrabel@citrix.com>
Fri, 16 May 2014 11:26:04 +0000 (12:26 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 16 May 2014 20:27:23 +0000 (16:27 -0400)
commit0d08fceb2e21c30ca3e1e462e678723f806acf18
tree4a890dcf919f80ffb067351bfc45cc63dab35791
parent202630b445d2618d94e4f099567fcee5618dab27
xen-netback: fix race between napi_complete() and interrupt handler

When the NAPI budget was not all used, xenvif_poll() would call
napi_complete() /after/ enabling the interrupt.  This resulted in a
race between the napi_complete() and the napi_schedule() in the
interrupt handler.  The use of local_irq_save/restore() avoided by
race iff the handler is running on the same CPU but not if it was
running on a different CPU.

Fix this properly by calling napi_complete() before reenabling
interrupts (in the xenvif_napi_schedule_or_enable_irq() call).

Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/xen-netback/common.h
drivers/net/xen-netback/interface.c
drivers/net/xen-netback/netback.c