tracing: kernel/trace/trace.c: introduce missing kfree()
authorJulia Lawall <julia@diku.dk>
Fri, 14 Nov 2008 18:05:31 +0000 (19:05 +0100)
committerIngo Molnar <mingo@elte.hu>
Tue, 18 Nov 2008 15:59:58 +0000 (16:59 +0100)
commit0bb943c7a2136716757a263f604d26309fd98042
tree80af655ff3272a820a9090e6fa08c9e6472f0bed
parente270219f4372b58bd3eeac12bd9f7edc592b8f6b
tracing: kernel/trace/trace.c: introduce missing kfree()

Impact: fix memory leak

Error handling code following a kzalloc should free the allocated data.

The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,l;
position p1,p2;
expression *ptr != NULL;
@@

(
if ((x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...)) == NULL) S
|
x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
)
<... when != x
     when != if (...) { <+...x...+> }
x->f = E
...>
(
 return \(0\|<+...x...+>\|ptr\);
|
 return@p2 ...;
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
kernel/trace/trace.c