usb-serial: fix crash when sub-driver updates firmware
authorAlan Stern <stern@rowland.harvard.edu>
Wed, 27 May 2009 15:25:52 +0000 (11:25 -0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 28 May 2009 20:54:43 +0000 (13:54 -0700)
commit0a3c8549ea7e94d74a41096d42bc6cdf43d183bf
treed3f09b0bbc2ad2b21b7b7458986c10e01aae490b
parent0afb20e00b5053170c85298fed842b32d20b4ea9
usb-serial: fix crash when sub-driver updates firmware

This patch (as1244) fixes a crash in usb-serial that occurs when a
sub-driver returns a positive value from its attach method, indicating
that new firmware was loaded and the device will disconnect and
reconnect.  The usb-serial core then skips the step of registering the
port devices; when the disconnect occurs, the attempt to unregister
the ports fails dramatically.

This problem shows up with Keyspan devices and it might affect others
as well.

When the attach method returns a positive value, the patch sets
num_ports to 0.  This tells usb_serial_disconnect() not to try
unregistering any of the ports; instead they are cleaned up by
destroy_serial().

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Tested-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/serial/usb-serial.c