ext4: validate the debug_want_extra_isize mount option at parse time
authorTheodore Ts'o <tytso@mit.edu>
Sun, 15 Dec 2019 06:09:03 +0000 (01:09 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 5 Feb 2020 14:18:13 +0000 (14:18 +0000)
commit08e4a312439c294b9753166537baf3cc0bd6bb07
tree85af38113f69ad3674d53f97b880fd7dad96f0f7
parent64700ad97eab8b533afd5dbfff22266b68900e35
ext4: validate the debug_want_extra_isize mount option at parse time

commit 9803387c55f7d2ce69aa64340c5fdc6b3027dbc8 upstream.

Instead of setting s_want_extra_size and then making sure that it is a
valid value afterwards, validate the field before we set it.  This
avoids races and other problems when remounting the file system.

Link: https://lore.kernel.org/r/20191215063020.GA11512@mit.edu
Cc: stable@kernel.org
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reported-and-tested-by: syzbot+4a39a025912b265cacef@syzkaller.appspotmail.com
Signed-off-by: Zubin Mithra <zsm@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ext4/super.c