uprobes: Do not delete uprobe if uprobe_unregister() fails
authorOleg Nesterov <oleg@redhat.com>
Sun, 30 Sep 2012 16:54:53 +0000 (18:54 +0200)
committerOleg Nesterov <oleg@redhat.com>
Sun, 7 Oct 2012 19:19:41 +0000 (21:19 +0200)
commit076a365b3da99b68c5d58e394714d0611f1fa002
treeb58ae7da7bfa80200bb9982f344b93cf3f22a7fd
parenta5f658b71bc622b731961ea3addcf146ed3c599f
uprobes: Do not delete uprobe if uprobe_unregister() fails

delete_uprobe() must not be called if register_for_each_vma(false)
fails to remove all breakpoints, __uprobe_unregister() is correct.
The problem is that register_for_each_vma(false) always returns 0
and thus this logic does not work.

1. Change verify_opcode() to return 0 rather than -EINVAL when
   unregister detects the !is_swbp insn, we can treat this case
   as success and currently unregister paths ignore the error
   code anyway.

2. Change remove_breakpoint() to propagate the error code from
   write_opcode().

3. Change register_for_each_vma(is_register => false) to remove
   as much breakpoints as possible but return non-zero if
   remove_breakpoint() fails at least once.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
kernel/events/uprobes.c