sctp: translate host order to network order when setting a hmacid
authorlucien <lucien.xin@gmail.com>
Thu, 12 Nov 2015 05:07:07 +0000 (13:07 +0800)
committerDanny Wood <danwood76@gmail.com>
Tue, 29 Jan 2019 13:10:55 +0000 (13:10 +0000)
commit0660c06bfbee0e9d0a95052ace484ca198a6d3ce
tree9e268d7ec12faa548f0c0702107060d64d3c1cc9
parent01ea9fe25bca01300ab547e71ca47f0812536cfe
sctp: translate host order to network order when setting a hmacid

[ Upstream commit ed5a377d87dc4c87fb3e1f7f698cba38cd893103 ]

now sctp auth cannot work well when setting a hmacid manually, which
is caused by that we didn't use the network order for hmacid, so fix
it by adding the transformation in sctp_auth_ep_set_hmacs.

even we set hmacid with the network order in userspace, it still
can't work, because of this condition in sctp_auth_ep_set_hmacs():

if (id > SCTP_AUTH_HMAC_ID_MAX)
return -EOPNOTSUPP;

so this wasn't working before and thus it won't break compatibility.

Fixes: 65b07e5d0d09 ("[SCTP]: API updates to suport SCTP-AUTH extensions.")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Acked-by: Vlad Yasevich <vyasevich@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/sctp/auth.c