[RAMEN9610-21992]icmp: randomize the global rate limiter
authorEric Dumazet <edumazet@google.com>
Thu, 15 Oct 2020 18:42:00 +0000 (11:42 -0700)
committerlingsen1 <lingsen1@lenovo.com>
Thu, 1 Apr 2021 13:30:04 +0000 (21:30 +0800)
commit063438189636c06c779d954ce504e35fc935b7cd
treef2a9ac5628f7bd5c8da1d7d87272c7f6aabc6562
parent47dab6f3ad15eaa875632f14ea0869fd331df1ed
[RAMEN9610-21992]icmp: randomize the global rate limiter

[ Upstream commit b38e7819cae946e2edf869e604af1e65a5d241c5 ]

Keyu Man reported that the ICMP rate limiter could be used
by attackers to get useful signal. Details will be provided
in an upcoming academic publication.

Our solution is to add some noise, so that the attackers
no longer can get help from the predictable token bucket limiter.

Fixes: 4cdf507d5452 ("icmp: add a global rate limitation")
Change-Id: Ib1a0ee70e55123a17d88b79a83664a3b2ac70034
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Keyu Man <kman001@ucr.edu>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Documentation/networking/ip-sysctl.txt
net/ipv4/icmp.c