genirq: Warn when IRQ_NOAUTOEN is used with shared interrupts
authorThomas Gleixner <tglx@linutronix.de>
Wed, 31 May 2017 09:58:33 +0000 (11:58 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Sun, 4 Jun 2017 12:38:41 +0000 (14:38 +0200)
commit04c848d398797a626608ff48804d809ae6687163
tree4225f152323a63dc6cf7cfbc124a22a300599530
parent201d7f47f34bd7cb19161d0426f13b141e381f30
genirq: Warn when IRQ_NOAUTOEN is used with shared interrupts

Shared interrupts do not go well with disabling auto enable:

1) The sharing interrupt might request it while it's still disabled and
   then wait for interrupts forever.

2) The interrupt might have been requested by the driver sharing the line
   before IRQ_NOAUTOEN has been set. So the driver which expects that
   disabled state after calling request_irq() will not get what it wants.
   Even worse, when it calls enable_irq() later, it will trigger the
   unbalanced enable_irq() warning.

Reported-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: dianders@chromium.org
Cc: jeffy <jeffy.chen@rock-chips.com>
Cc: Marc Zyngier <marc.zyngier@arm.com>
Cc: tfiga@chromium.org
Link: http://lkml.kernel.org/r/20170531100212.210682135@linutronix.de
kernel/irq/chip.c
kernel/irq/manage.c