tcp: fix more NULL deref after prequeue changes
authorEric Dumazet <edumazet@google.com>
Tue, 9 Dec 2014 17:56:08 +0000 (09:56 -0800)
committerDanny Wood <danwood76@gmail.com>
Tue, 28 Jul 2020 08:47:01 +0000 (09:47 +0100)
commit04140b07839b75932f4a5f2bdb51a7c57f6b7c93
tree14eea828b47fd2f6e683d77789dd83646debc48c
parent70d7432bc199dce6d6bb3bff62239f9c30675289
tcp: fix more NULL deref after prequeue changes

When I cooked commit c3658e8d0f1 ("tcp: fix possible NULL dereference in
tcp_vX_send_reset()") I missed other spots we could deref a NULL
skb_dst(skb)

Again, if a socket is provided, we do not need skb_dst() to get a
pointer to network namespace : sock_net(sk) is good enough.

[Backport of net-next 0f85feae6b710ced3abad5b2b47d31dfcb956b62]

Bug: 16355602
Change-Id: I72c9f7dae8da4451112a20ea36183365303bd389
Reported-by: Dann Frazier <dann.frazier@canonical.com>
Bisected-by: Dann Frazier <dann.frazier@canonical.com>
Tested-by: Dann Frazier <dann.frazier@canonical.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Fixes: ca777eff51f7 ("tcp: remove dst refcount false sharing for prequeue mode")
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/tcp_ipv4.c
net/ipv6/tcp_ipv6.c