gfs2: Fix use-after-free in gfs2_glock_shrink_scan
authorHillf Danton <hdanton@sina.com>
Tue, 18 May 2021 08:46:25 +0000 (16:46 +0800)
committerSasha Levin <sashal@kernel.org>
Wed, 30 Jun 2021 12:48:46 +0000 (08:48 -0400)
commit0364742decb0f02bc183404868b82896f7992595
treed9e9d7b56bc7e74afa6dca76b934109078d78971
parentb5496f3da6b5b6c91e6990ebbb243415e95f7f83
gfs2: Fix use-after-free in gfs2_glock_shrink_scan

[ Upstream commit 1ab19c5de4c537ec0d9b21020395a5b5a6c059b2 ]

The GLF_LRU flag is checked under lru_lock in gfs2_glock_remove_from_lru() to
remove the glock from the lru list in __gfs2_glock_put().

On the shrink scan path, the same flag is cleared under lru_lock but because
of cond_resched_lock(&lru_lock) in gfs2_dispose_glock_lru(), progress on the
put side can be made without deleting the glock from the lru list.

Keep GLF_LRU across the race window opened by cond_resched_lock(&lru_lock) to
ensure correct behavior on both sides - clear GLF_LRU after list_del under
lru_lock.

Reported-by: syzbot <syzbot+34ba7ddbf3021981a228@syzkaller.appspotmail.com>
Signed-off-by: Hillf Danton <hdanton@sina.com>
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/gfs2/glock.c