[media] msp3400: fix mute audio regression
authorHans Verkuil <hverkuil@xs4all.nl>
Sun, 17 Oct 2010 10:24:20 +0000 (07:24 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 21 Oct 2010 10:56:41 +0000 (08:56 -0200)
commit0310871d8f71da4ad8643687fbc40f219a0dac4d
treedae49f63fd458fb708852ce68b320bd7cea13767
parentf43402fa55bf5e7e190c176343015122f694857c
[media] msp3400: fix mute audio regression

The switch to the new control framework caused a regression where the audio was
no longer unmuted after the carrier scan finished.

The original code attempted to set the volume control to its current value in
order to have the set-volume control code to be called that handles the volume
and muting. However, the framework will not call that code unless the new volume
value is different from the old.

Instead we now call msp_s_ctrl directly.

It is a bit of a hack: we really need a v4l2_ctrl_refresh_ctrl function for this
(or something along those lines).

Thanks to Andy Walls for bisecting this and to Shane Shrybman for reporting it!

Reported-by: Shane Shrybman <shrybman@teksavvy.com>
Thanks-to: Andy Walls <awalls@md.metrocast.net>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/msp3400-driver.c