blk: replace bioset_create_nobvec() with a flags arg to bioset_create()
authorNeilBrown <neilb@suse.com>
Sun, 18 Jun 2017 04:38:57 +0000 (14:38 +1000)
committerJens Axboe <axboe@kernel.dk>
Sun, 18 Jun 2017 18:40:59 +0000 (12:40 -0600)
commit011067b05668b05aae88e5a24cff0ca0a67ca0b0
treeb56fb4114e8bd71ffd36520f1b4cf7e4e49f1c79
parentaf67c31fba3b879b241536a48df703a2eee18ebf
blk: replace bioset_create_nobvec() with a flags arg to bioset_create()

"flags" arguments are often seen as good API design as they allow
easy extensibility.
bioset_create_nobvec() is implemented internally as a variation in
flags passed to __bioset_create().

To support future extension, make the internal structure part of the
API.
i.e. add a 'flags' argument to bioset_create() and discard
bioset_create_nobvec().

Note that the bio_split allocations in drivers/md/raid* do not need
the bvec mempool - they should have used bioset_create_nobvec().

Suggested-by: Christoph Hellwig <hch@infradead.org>
Reviewed-by: Christoph Hellwig <hch@infradead.org>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
18 files changed:
block/bio.c
block/blk-core.c
drivers/block/drbd/drbd_main.c
drivers/md/bcache/super.c
drivers/md/dm-crypt.c
drivers/md/dm-io.c
drivers/md/dm.c
drivers/md/md.c
drivers/md/raid1.c
drivers/md/raid10.c
drivers/md/raid5-cache.c
drivers/md/raid5-ppl.c
drivers/md/raid5.c
drivers/target/target_core_iblock.c
fs/block_dev.c
fs/btrfs/extent_io.c
fs/xfs/xfs_super.c
include/linux/bio.h