f2fs: check its block allocation to avoid producing wrong dirty pages

[GitHub/exynos8895/android_kernel_samsung_universal8895.git] / fs / f2fs / data.c

diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 08a71ae3ab8d1c8b8cb71429183c580f333f135e..389fda772e69fae8c636543c67dc5b7a1db0f697 100644 (file)
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -273,9 +273,6 @@ static bool lookup_extent_info(struct inode *inode, pgoff_t pgofs,
        pgoff_t start_fofs, end_fofs;
        block_t start_blkaddr;
 
-       if (is_inode_flag_set(fi, FI_NO_EXTENT))
-               return false;
-
        read_lock(&fi->ext_lock);
        if (fi->ext.len == 0) {
                read_unlock(&fi->ext_lock);
@@ -306,9 +303,6 @@ static bool update_extent_info(struct inode *inode, pgoff_t fofs,
        block_t start_blkaddr, end_blkaddr;
        int need_update = true;
 
-       if (is_inode_flag_set(fi, FI_NO_EXTENT))
-               return false;
-
        write_lock(&fi->ext_lock);
 
        start_fofs = fi->ext.fofs;
@@ -542,9 +536,6 @@ static bool f2fs_lookup_extent_tree(struct inode *inode, pgoff_t pgofs,
        struct extent_tree *et;
        struct extent_node *en;
 
-       if (is_inode_flag_set(F2FS_I(inode), FI_NO_EXTENT))
-               return false;
-
        trace_f2fs_lookup_extent_tree_start(inode, pgofs);
 
        down_read(&sbi->extent_tree_lock);
@@ -586,9 +577,6 @@ static void f2fs_update_extent_tree(struct inode *inode, pgoff_t fofs,
        struct extent_info ei, dei;
        unsigned int endofs;
 
-       if (is_inode_flag_set(F2FS_I(inode), FI_NO_EXTENT))
-               return;
-
        trace_f2fs_update_extent_tree(inode, fofs, blkaddr);
 
        down_write(&sbi->extent_tree_lock);
@@ -780,6 +768,9 @@ out:
 static bool f2fs_lookup_extent_cache(struct inode *inode, pgoff_t pgofs,
                                                        struct extent_info *ei)
 {
+       if (is_inode_flag_set(F2FS_I(inode), FI_NO_EXTENT))
+               return false;
+
        if (test_opt(F2FS_I_SB(inode), EXTENT_CACHE))
                return f2fs_lookup_extent_tree(inode, pgofs, ei);
 
@@ -796,6 +787,9 @@ void f2fs_update_extent_cache(struct dnode_of_data *dn)
        /* Update the page address in the parent node */
        __set_data_blkaddr(dn);
 
+       if (is_inode_flag_set(fi, FI_NO_EXTENT))
+               return;
+
        fofs = start_bidx_of_node(ofs_of_node(dn->node_page), fi) +
                                                        dn->ofs_in_node;
 
@@ -812,16 +806,30 @@ struct page *find_data_page(struct inode *inode, pgoff_t index, bool sync)
        struct address_space *mapping = inode->i_mapping;
        struct dnode_of_data dn;
        struct page *page;
+       struct extent_info ei;
        int err;
        struct f2fs_io_info fio = {
                .type = DATA,
                .rw = sync ? READ_SYNC : READA,
        };
 
+       /*
+        * If sync is false, it needs to check its block allocation.
+        * This is need and triggered by two flows:
+        *   gc and truncate_partial_data_page.
+        */
+       if (!sync)
+               goto search;
+
        page = find_get_page(mapping, index);
        if (page && PageUptodate(page))
                return page;
        f2fs_put_page(page, 0);
+search:
+       if (f2fs_lookup_extent_cache(inode, index, &ei)) {
+               dn.data_blkaddr = ei.blk + index - ei.fofs;
+               goto got_it;
+       }
 
        set_new_dnode(&dn, inode, NULL, NULL, 0);
        err = get_dnode_of_data(&dn, index, LOOKUP_NODE);
@@ -836,6 +844,7 @@ struct page *find_data_page(struct inode *inode, pgoff_t index, bool sync)
        if (unlikely(dn.data_blkaddr == NEW_ADDR))
                return ERR_PTR(-EINVAL);
 
+got_it:
        page = grab_cache_page(mapping, index);
        if (!page)
                return ERR_PTR(-ENOMEM);
@@ -870,6 +879,7 @@ struct page *get_lock_data_page(struct inode *inode, pgoff_t index)
        struct address_space *mapping = inode->i_mapping;
        struct dnode_of_data dn;
        struct page *page;
+       struct extent_info ei;
        int err;
        struct f2fs_io_info fio = {
                .type = DATA,
@@ -880,6 +890,11 @@ repeat:
        if (!page)
                return ERR_PTR(-ENOMEM);
 
+       if (f2fs_lookup_extent_cache(inode, index, &ei)) {
+               dn.data_blkaddr = ei.blk + index - ei.fofs;
+               goto got_it;
+       }
+
        set_new_dnode(&dn, inode, NULL, NULL, 0);
        err = get_dnode_of_data(&dn, index, LOOKUP_NODE);
        if (err) {
@@ -893,6 +908,7 @@ repeat:
                return ERR_PTR(-ENOENT);
        }
 
+got_it:
        if (PageUptodate(page))
                return page;
 
@@ -1251,8 +1267,10 @@ int do_write_data_page(struct page *page, struct f2fs_io_info *fio)
        fio->blk_addr = dn.data_blkaddr;
 
        /* This page is already truncated */
-       if (fio->blk_addr == NULL_ADDR)
+       if (fio->blk_addr == NULL_ADDR) {
+               ClearPageUptodate(page);
                goto out_writepage;
+       }
 
        set_page_writeback(page);
 
@@ -1347,6 +1365,8 @@ done:
        clear_cold_data(page);
 out:
        inode_dec_dirty_pages(inode);
+       if (err)
+               ClearPageUptodate(page);
        unlock_page(page);
        if (need_balance_fs)
                f2fs_balance_fs(sbi);