drm: Make the CRTC gamma_set operation optional
[GitHub/LineageOS/android_kernel_samsung_universal7580.git] / drivers / gpu / drm / drm_crtc.c
index b6783f914246f87160c38d5c8019edfe61542cd4..6cb47d9f0ca2603de2d3af1f859419d65151ef1c 100644 (file)
@@ -363,7 +363,7 @@ EXPORT_SYMBOL(drm_framebuffer_cleanup);
  * @funcs: callbacks for the new CRTC
  *
  * LOCKING:
- * Caller must hold mode config lock.
+ * Takes mode_config lock.
  *
  * Inits a new object created as base part of an driver crtc object.
  *
@@ -384,6 +384,8 @@ int drm_crtc_init(struct drm_device *dev, struct drm_crtc *crtc,
        if (ret)
                goto out;
 
+       crtc->base.properties = &crtc->properties;
+
        list_add_tail(&crtc->head, &dev->mode_config.crtc_list);
        dev->mode_config.num_crtc++;
 
@@ -1425,11 +1427,7 @@ int drm_mode_getconnector(struct drm_device *dev, void *data,
        }
        connector = obj_to_connector(obj);
 
-       for (i = 0; i < DRM_OBJECT_MAX_PROPERTY; i++) {
-               if (connector->properties.ids[i] != 0) {
-                       props_count++;
-               }
-       }
+       props_count = connector->properties.count;
 
        for (i = 0; i < DRM_CONNECTOR_MAX_ENCODER; i++) {
                if (connector->encoder_ids[i] != 0) {
@@ -1482,21 +1480,19 @@ int drm_mode_getconnector(struct drm_device *dev, void *data,
                copied = 0;
                prop_ptr = (uint32_t __user *)(unsigned long)(out_resp->props_ptr);
                prop_values = (uint64_t __user *)(unsigned long)(out_resp->prop_values_ptr);
-               for (i = 0; i < DRM_OBJECT_MAX_PROPERTY; i++) {
-                       if (connector->properties.ids[i] != 0) {
-                               if (put_user(connector->properties.ids[i],
-                                            prop_ptr + copied)) {
-                                       ret = -EFAULT;
-                                       goto out;
-                               }
+               for (i = 0; i < connector->properties.count; i++) {
+                       if (put_user(connector->properties.ids[i],
+                                    prop_ptr + copied)) {
+                               ret = -EFAULT;
+                               goto out;
+                       }
 
-                               if (put_user(connector->properties.values[i],
-                                            prop_values + copied)) {
-                                       ret = -EFAULT;
-                                       goto out;
-                               }
-                               copied++;
+                       if (put_user(connector->properties.values[i],
+                                    prop_values + copied)) {
+                               ret = -EFAULT;
+                               goto out;
                        }
+                       copied++;
                }
        }
        out_resp->count_props = props_count;
@@ -1833,7 +1829,7 @@ int drm_mode_setcrtc(struct drm_device *dev, void *data,
        struct drm_display_mode *mode = NULL;
        struct drm_mode_set set;
        uint32_t __user *set_connectors_ptr;
-       int ret = 0;
+       int ret;
        int i;
 
        if (!drm_core_check_feature(dev, DRIVER_MODESET))
@@ -2252,7 +2248,7 @@ int drm_mode_addfb2(struct drm_device *dev,
        struct drm_mode_fb_cmd2 *r = data;
        struct drm_mode_config *config = &dev->mode_config;
        struct drm_framebuffer *fb;
-       int ret = 0;
+       int ret;
 
        if (!drm_core_check_feature(dev, DRIVER_MODESET))
                return -EINVAL;
@@ -2407,7 +2403,7 @@ int drm_mode_dirtyfb_ioctl(struct drm_device *dev,
        struct drm_framebuffer *fb;
        unsigned flags;
        int num_clips;
-       int ret = 0;
+       int ret;
 
        if (!drm_core_check_feature(dev, DRIVER_MODESET))
                return -EINVAL;
@@ -2606,7 +2602,7 @@ int drm_mode_attachmode_ioctl(struct drm_device *dev,
        struct drm_display_mode *mode;
        struct drm_mode_object *obj;
        struct drm_mode_modeinfo *umode = &mode_cmd->mode;
-       int ret = 0;
+       int ret;
 
        if (!drm_core_check_feature(dev, DRIVER_MODESET))
                return -EINVAL;
@@ -2660,7 +2656,7 @@ int drm_mode_detachmode_ioctl(struct drm_device *dev,
        struct drm_connector *connector;
        struct drm_display_mode mode;
        struct drm_mode_modeinfo *umode = &mode_cmd->mode;
-       int ret = 0;
+       int ret;
 
        if (!drm_core_check_feature(dev, DRIVER_MODESET))
                return -EINVAL;
@@ -2823,55 +2819,21 @@ EXPORT_SYMBOL(drm_property_destroy);
 void drm_connector_attach_property(struct drm_connector *connector,
                               struct drm_property *property, uint64_t init_val)
 {
-       int i;
-
-       for (i = 0; i < DRM_OBJECT_MAX_PROPERTY; i++) {
-               if (connector->properties.ids[i] == 0) {
-                       connector->properties.ids[i] = property->base.id;
-                       connector->properties.values[i] = init_val;
-                       return;
-               }
-       }
-
-       WARN(1, "Failed to attach connector property. Please increase "
-               "DRM_OBJECT_MAX_PROPERTY by 1 for each time you see this "
-               "message\n");
+       drm_object_attach_property(&connector->base, property, init_val);
 }
 EXPORT_SYMBOL(drm_connector_attach_property);
 
 int drm_connector_property_set_value(struct drm_connector *connector,
                                  struct drm_property *property, uint64_t value)
 {
-       int i;
-
-       for (i = 0; i < DRM_OBJECT_MAX_PROPERTY; i++) {
-               if (connector->properties.ids[i] == property->base.id) {
-                       connector->properties.values[i] = value;
-                       break;
-               }
-       }
-
-       if (i == DRM_OBJECT_MAX_PROPERTY)
-               return -EINVAL;
-       return 0;
+       return drm_object_property_set_value(&connector->base, property, value);
 }
 EXPORT_SYMBOL(drm_connector_property_set_value);
 
 int drm_connector_property_get_value(struct drm_connector *connector,
                                  struct drm_property *property, uint64_t *val)
 {
-       int i;
-
-       for (i = 0; i < DRM_OBJECT_MAX_PROPERTY; i++) {
-               if (connector->properties.ids[i] == property->base.id) {
-                       *val = connector->properties.values[i];
-                       break;
-               }
-       }
-
-       if (i == DRM_OBJECT_MAX_PROPERTY)
-               return -EINVAL;
-       return 0;
+       return drm_object_property_get_value(&connector->base, property, val);
 }
 EXPORT_SYMBOL(drm_connector_property_get_value);
 
@@ -2879,19 +2841,19 @@ void drm_object_attach_property(struct drm_mode_object *obj,
                                struct drm_property *property,
                                uint64_t init_val)
 {
-       int i;
+       int count = obj->properties->count;
 
-       for (i = 0; i < DRM_OBJECT_MAX_PROPERTY; i++) {
-               if (obj->properties->ids[i] == 0) {
-                       obj->properties->ids[i] = property->base.id;
-                       obj->properties->values[i] = init_val;
-                       return;
-               }
+       if (count == DRM_OBJECT_MAX_PROPERTY) {
+               WARN(1, "Failed to attach object property (type: 0x%x). Please "
+                       "increase DRM_OBJECT_MAX_PROPERTY by 1 for each time "
+                       "you see this message on the same object type.\n",
+                       obj->type);
+               return;
        }
 
-       WARN(1, "Failed to attach object property (type: 0x%x). Please "
-               "increase DRM_OBJECT_MAX_PROPERTY by 1 for each time you see "
-               "this message on the same object type.\n", obj->type);
+       obj->properties->ids[count] = property->base.id;
+       obj->properties->values[count] = init_val;
+       obj->properties->count++;
 }
 EXPORT_SYMBOL(drm_object_attach_property);
 
@@ -2900,7 +2862,7 @@ int drm_object_property_set_value(struct drm_mode_object *obj,
 {
        int i;
 
-       for (i = 0; i < DRM_OBJECT_MAX_PROPERTY; i++) {
+       for (i = 0; i < obj->properties->count; i++) {
                if (obj->properties->ids[i] == property->base.id) {
                        obj->properties->values[i] = val;
                        return 0;
@@ -2916,7 +2878,7 @@ int drm_object_property_get_value(struct drm_mode_object *obj,
 {
        int i;
 
-       for (i = 0; i < DRM_OBJECT_MAX_PROPERTY; i++) {
+       for (i = 0; i < obj->properties->count; i++) {
                if (obj->properties->ids[i] == property->base.id) {
                        *val = obj->properties->values[i];
                        return 0;
@@ -3103,7 +3065,7 @@ int drm_mode_connector_update_edid_property(struct drm_connector *connector,
                                            struct edid *edid)
 {
        struct drm_device *dev = connector->dev;
-       int ret = 0, size;
+       int ret, size;
 
        if (connector->edid_blob_ptr)
                drm_property_destroy_blob(dev, connector->edid_blob_ptr);
@@ -3148,56 +3110,16 @@ static bool drm_property_change_is_valid(struct drm_property *property,
 int drm_mode_connector_property_set_ioctl(struct drm_device *dev,
                                       void *data, struct drm_file *file_priv)
 {
-       struct drm_mode_connector_set_property *out_resp = data;
-       struct drm_mode_object *obj;
-       struct drm_property *property;
-       struct drm_connector *connector;
-       int ret = -EINVAL;
-       int i;
-
-       if (!drm_core_check_feature(dev, DRIVER_MODESET))
-               return -EINVAL;
-
-       mutex_lock(&dev->mode_config.mutex);
-
-       obj = drm_mode_object_find(dev, out_resp->connector_id, DRM_MODE_OBJECT_CONNECTOR);
-       if (!obj) {
-               goto out;
-       }
-       connector = obj_to_connector(obj);
-
-       for (i = 0; i < DRM_OBJECT_MAX_PROPERTY; i++) {
-               if (connector->properties.ids[i] == out_resp->prop_id)
-                       break;
-       }
-
-       if (i == DRM_OBJECT_MAX_PROPERTY) {
-               goto out;
-       }
-
-       obj = drm_mode_object_find(dev, out_resp->prop_id, DRM_MODE_OBJECT_PROPERTY);
-       if (!obj) {
-               goto out;
-       }
-       property = obj_to_property(obj);
+       struct drm_mode_connector_set_property *conn_set_prop = data;
+       struct drm_mode_obj_set_property obj_set_prop = {
+               .value = conn_set_prop->value,
+               .prop_id = conn_set_prop->prop_id,
+               .obj_id = conn_set_prop->connector_id,
+               .obj_type = DRM_MODE_OBJECT_CONNECTOR
+       };
 
-       if (!drm_property_change_is_valid(property, out_resp->value))
-               goto out;
-
-       /* Do DPMS ourselves */
-       if (property == connector->dev->mode_config.dpms_property) {
-               if (connector->funcs->dpms)
-                       (*connector->funcs->dpms)(connector, (int) out_resp->value);
-               ret = 0;
-       } else if (connector->funcs->set_property)
-               ret = connector->funcs->set_property(connector, property, out_resp->value);
-
-       /* store the property value if successful */
-       if (!ret)
-               drm_connector_property_set_value(connector, property, out_resp->value);
-out:
-       mutex_unlock(&dev->mode_config.mutex);
-       return ret;
+       /* It does all the locking and checking we need */
+       return drm_mode_obj_set_property_ioctl(dev, &obj_set_prop, file_priv);
 }
 
 static int drm_mode_connector_set_obj_prop(struct drm_mode_object *obj,
@@ -3221,6 +3143,21 @@ static int drm_mode_connector_set_obj_prop(struct drm_mode_object *obj,
        return ret;
 }
 
+static int drm_mode_crtc_set_obj_prop(struct drm_mode_object *obj,
+                                     struct drm_property *property,
+                                     uint64_t value)
+{
+       int ret = -EINVAL;
+       struct drm_crtc *crtc = obj_to_crtc(obj);
+
+       if (crtc->funcs->set_property)
+               ret = crtc->funcs->set_property(crtc, property, value);
+       if (!ret)
+               drm_object_property_set_value(obj, property, value);
+
+       return ret;
+}
+
 int drm_mode_obj_get_properties_ioctl(struct drm_device *dev, void *data,
                                      struct drm_file *file_priv)
 {
@@ -3248,11 +3185,7 @@ int drm_mode_obj_get_properties_ioctl(struct drm_device *dev, void *data,
                goto out;
        }
 
-       /* Assume [ prop, 0, prop ] won't happen (if we ever delete properties,
-        * we need to remove the gap inside the array). */
-       for (props_count = 0; props_count < DRM_OBJECT_MAX_PROPERTY &&
-               obj->properties->ids[props_count] != 0; props_count++)
-               ;
+       props_count = obj->properties->count;
 
        /* This ioctl is called twice, once to determine how much space is
         * needed, and the 2nd time to fill it. */
@@ -3302,11 +3235,11 @@ int drm_mode_obj_set_property_ioctl(struct drm_device *dev, void *data,
        if (!arg_obj->properties)
                goto out;
 
-       for (i = 0; i < DRM_OBJECT_MAX_PROPERTY; i++)
+       for (i = 0; i < arg_obj->properties->count; i++)
                if (arg_obj->properties->ids[i] == arg->prop_id)
                        break;
 
-       if (i == DRM_OBJECT_MAX_PROPERTY)
+       if (i == arg_obj->properties->count)
                goto out;
 
        prop_obj = drm_mode_object_find(dev, arg->prop_id,
@@ -3323,6 +3256,9 @@ int drm_mode_obj_set_property_ioctl(struct drm_device *dev, void *data,
                ret = drm_mode_connector_set_obj_prop(arg_obj, property,
                                                      arg->value);
                break;
+       case DRM_MODE_OBJECT_CRTC:
+               ret = drm_mode_crtc_set_obj_prop(arg_obj, property, arg->value);
+               break;
        }
 
 out:
@@ -3396,6 +3332,11 @@ int drm_mode_gamma_set_ioctl(struct drm_device *dev,
        }
        crtc = obj_to_crtc(obj);
 
+       if (crtc->funcs->gamma_set == NULL) {
+               ret = -ENOSYS;
+               goto out;
+       }
+
        /* memcpy into gamma store */
        if (crtc_lut->gamma_size != crtc->gamma_size) {
                ret = -EINVAL;