scripts/checkpatch.pl

   1 #!/usr/bin/perl -w
   2 # (c) 2001, Dave Jones. <davej@codemonkey.org.uk> (the file handling bit)
   3 # (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit)
   4 # (c) 2007, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite, etc)
   5 # Licensed under the terms of the GNU GPL License version 2
   6
   7 use strict;
   8
   9 my $P = $0;
  10 $P =~ s@.*/@@g;
  11
  12 my $V = '0.20';
  13
  14 use Getopt::Long qw(:config no_auto_abbrev);
  15
  16 my $quiet = 0;
  17 my $tree = 1;
  18 my $chk_signoff = 1;
  19 my $chk_patch = 1;
  20 my $tst_only;
  21 my $emacs = 0;
  22 my $terse = 0;
  23 my $file = 0;
  24 my $check = 0;
  25 my $summary = 1;
  26 my $mailback = 0;
  27 my $summary_file = 0;
  28 my $root;
  29 my %debug;
  30 GetOptions(
  31         'q|quiet+'      => \$quiet,
  32         'tree!'         => \$tree,
  33         'signoff!'      => \$chk_signoff,
  34         'patch!'        => \$chk_patch,
  35         'emacs!'        => \$emacs,
  36         'terse!'        => \$terse,
  37         'file!'         => \$file,
  38         'subjective!'   => \$check,
  39         'strict!'       => \$check,
  40         'root=s'        => \$root,
  41         'summary!'      => \$summary,
  42         'mailback!'     => \$mailback,
  43         'summary-file!' => \$summary_file,
  44
  45         'debug=s'       => \%debug,
  46         'test-only=s'   => \$tst_only,
  47 ) or exit;
  48
  49 my $exit = 0;
  50
  51 if ($#ARGV < 0) {
  52         print "usage: $P [options] patchfile\n";
  53         print "version: $V\n";
  54         print "options: -q               => quiet\n";
  55         print "         --no-tree        => run without a kernel tree\n";
  56         print "         --terse          => one line per report\n";
  57         print "         --emacs          => emacs compile window format\n";
  58         print "         --file           => check a source file\n";
  59         print "         --strict         => enable more subjective tests\n";
  60         print "         --root           => path to the kernel tree root\n";
  61         print "         --no-summary     => suppress the per-file summary\n";
  62         print "         --summary-file   => include the filename in summary\n";
  63         exit(1);
  64 }
  65
  66 my $dbg_values = 0;
  67 my $dbg_possible = 0;
  68 my $dbg_type = 0;
  69 for my $key (keys %debug) {
  70         eval "\${dbg_$key} = '$debug{$key}';"
  71 }
  72
  73 if ($terse) {
  74         $emacs = 1;
  75         $quiet++;
  76 }
  77
  78 if ($tree) {
  79         if (defined $root) {
  80                 if (!top_of_kernel_tree($root)) {
  81                         die "$P: $root: --root does not point at a valid tree\n";
  82                 }
  83         } else {
  84                 if (top_of_kernel_tree('.')) {
  85                         $root = '.';
  86                 } elsif ($0 =~ m@(.*)/scripts/[^/]*$@ &&
  87                                                 top_of_kernel_tree($1)) {
  88                         $root = $1;
  89                 }
  90         }
  91
  92         if (!defined $root) {
  93                 print "Must be run from the top-level dir. of a kernel tree\n";
  94                 exit(2);
  95         }
  96 }
  97
  98 my $emitted_corrupt = 0;
  99
 100 our $Ident       = qr{[A-Za-z_][A-Za-z\d_]*};
 101 our $Storage    = qr{extern|static|asmlinkage};
 102 our $Sparse     = qr{
 103                         __user|
 104                         __kernel|
 105                         __force|
 106                         __iomem|
 107                         __must_check|
 108                         __init_refok|
 109                         __kprobes
 110                 }x;
 111 our $Attribute  = qr{
 112                         const|
 113                         __read_mostly|
 114                         __kprobes|
 115                         __(?:mem|cpu|dev|)(?:initdata|init)
 116                   }x;
 117 our $Modifier;
 118 our $Inline     = qr{inline|__always_inline|noinline};
 119 our $Member     = qr{->$Ident|\.$Ident|\[[^]]*\]};
 120 our $Lval       = qr{$Ident(?:$Member)*};
 121
 122 our $Constant   = qr{(?:[0-9]+|0x[0-9a-fA-F]+)[UL]*};
 123 our $Assignment = qr{(?:\*\=|/=|%=|\+=|-=|<<=|>>=|&=|\^=|\|=|=)};
 124 our $Operators  = qr{
 125                         <=|>=|==|!=|
 126                         =>|->|<<|>>|<|>|!|~|
 127                         &&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|%
 128                   }x;
 129
 130 our $NonptrType;
 131 our $Type;
 132 our $Declare;
 133
 134 our $UTF8       = qr {
 135         [\x09\x0A\x0D\x20-\x7E]              # ASCII
 136         | [\xC2-\xDF][\x80-\xBF]             # non-overlong 2-byte
 137         |  \xE0[\xA0-\xBF][\x80-\xBF]        # excluding overlongs
 138         | [\xE1-\xEC\xEE\xEF][\x80-\xBF]{2}  # straight 3-byte
 139         |  \xED[\x80-\x9F][\x80-\xBF]        # excluding surrogates
 140         |  \xF0[\x90-\xBF][\x80-\xBF]{2}     # planes 1-3
 141         | [\xF1-\xF3][\x80-\xBF]{3}          # planes 4-15
 142         |  \xF4[\x80-\x8F][\x80-\xBF]{2}     # plane 16
 143 }x;
 144
 145 our @typeList = (
 146         qr{void},
 147         qr{(?:unsigned\s+)?char},
 148         qr{(?:unsigned\s+)?short},
 149         qr{(?:unsigned\s+)?int},
 150         qr{(?:unsigned\s+)?long},
 151         qr{(?:unsigned\s+)?long\s+int},
 152         qr{(?:unsigned\s+)?long\s+long},
 153         qr{(?:unsigned\s+)?long\s+long\s+int},
 154         qr{unsigned},
 155         qr{float},
 156         qr{double},
 157         qr{bool},
 158         qr{(?:__)?(?:u|s|be|le)(?:8|16|32|64)},
 159         qr{struct\s+$Ident},
 160         qr{union\s+$Ident},
 161         qr{enum\s+$Ident},
 162         qr{${Ident}_t},
 163         qr{${Ident}_handler},
 164         qr{${Ident}_handler_fn},
 165 );
 166 our @modifierList = (
 167         qr{fastcall},
 168 );
 169
 170 sub build_types {
 171         my $mods = "(?x:  \n" . join("|\n  ", @modifierList) . "\n)";
 172         my $all = "(?x:  \n" . join("|\n  ", @typeList) . "\n)";
 173         $Modifier       = qr{(?:$Attribute|$Sparse|$mods)};
 174         $NonptrType     = qr{
 175                         (?:$Modifier\s+|const\s+)*
 176                         (?:
 177                                 (?:typeof|__typeof__)\s*\(\s*\**\s*$Ident\s*\)|
 178                                 (?:${all}\b)
 179                         )
 180                         (?:\s+$Modifier|\s+const)*
 181                   }x;
 182         $Type   = qr{
 183                         $NonptrType
 184                         (?:\s*\*+\s*const|\s*\*+|(?:\s*\[\s*\])+)?
 185                         (?:\s+$Inline|\s+$Modifier)*
 186                   }x;
 187         $Declare        = qr{(?:$Storage\s+)?$Type};
 188 }
 189 build_types();
 190
 191 $chk_signoff = 0 if ($file);
 192
 193 my @dep_includes = ();
 194 my @dep_functions = ();
 195 my $removal = "Documentation/feature-removal-schedule.txt";
 196 if ($tree && -f "$root/$removal") {
 197         open(REMOVE, "<$root/$removal") ||
 198                                 die "$P: $removal: open failed - $!\n";
 199         while (<REMOVE>) {
 200                 if (/^Check:\s+(.*\S)/) {
 201                         for my $entry (split(/[, ]+/, $1)) {
 202                                 if ($entry =~ m@include/(.*)@) {
 203                                         push(@dep_includes, $1);
 204
 205                                 } elsif ($entry !~ m@/@) {
 206                                         push(@dep_functions, $entry);
 207                                 }
 208                         }
 209                 }
 210         }
 211 }
 212
 213 my @rawlines = ();
 214 my @lines = ();
 215 my $vname;
 216 for my $filename (@ARGV) {
 217         if ($file) {
 218                 open(FILE, "diff -u /dev/null $filename|") ||
 219                         die "$P: $filename: diff failed - $!\n";
 220         } else {
 221                 open(FILE, "<$filename") ||
 222                         die "$P: $filename: open failed - $!\n";
 223         }
 224         if ($filename eq '-') {
 225                 $vname = 'Your patch';
 226         } else {
 227                 $vname = $filename;
 228         }
 229         while (<FILE>) {
 230                 chomp;
 231                 push(@rawlines, $_);
 232         }
 233         close(FILE);
 234         if (!process($filename)) {
 235                 $exit = 1;
 236         }
 237         @rawlines = ();
 238         @lines = ();
 239 }
 240
 241 exit($exit);
 242
 243 sub top_of_kernel_tree {
 244         my ($root) = @_;
 245
 246         my @tree_check = (
 247                 "COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile",
 248                 "README", "Documentation", "arch", "include", "drivers",
 249                 "fs", "init", "ipc", "kernel", "lib", "scripts",
 250         );
 251
 252         foreach my $check (@tree_check) {
 253                 if (! -e $root . '/' . $check) {
 254                         return 0;
 255                 }
 256         }
 257         return 1;
 258 }
 259
 260 sub expand_tabs {
 261         my ($str) = @_;
 262
 263         my $res = '';
 264         my $n = 0;
 265         for my $c (split(//, $str)) {
 266                 if ($c eq "\t") {
 267                         $res .= ' ';
 268                         $n++;
 269                         for (; ($n % 8) != 0; $n++) {
 270                                 $res .= ' ';
 271                         }
 272                         next;
 273                 }
 274                 $res .= $c;
 275                 $n++;
 276         }
 277
 278         return $res;
 279 }
 280 sub copy_spacing {
 281         (my $res = shift) =~ tr/\t/ /c;
 282         return $res;
 283 }
 284
 285 sub line_stats {
 286         my ($line) = @_;
 287
 288         # Drop the diff line leader and expand tabs
 289         $line =~ s/^.//;
 290         $line = expand_tabs($line);
 291
 292         # Pick the indent from the front of the line.
 293         my ($white) = ($line =~ /^(\s*)/);
 294
 295         return (length($line), length($white));
 296 }
 297
 298 my $sanitise_quote = '';
 299
 300 sub sanitise_line_reset {
 301         my ($in_comment) = @_;
 302
 303         if ($in_comment) {
 304                 $sanitise_quote = '*/';
 305         } else {
 306                 $sanitise_quote = '';
 307         }
 308 }
 309 sub sanitise_line {
 310         my ($line) = @_;
 311
 312         my $res = '';
 313         my $l = '';
 314
 315         my $qlen = 0;
 316         my $off = 0;
 317         my $c;
 318
 319         # Always copy over the diff marker.
 320         $res = substr($line, 0, 1);
 321
 322         for ($off = 1; $off < length($line); $off++) {
 323                 $c = substr($line, $off, 1);
 324
 325                 # Comments we are wacking completly including the begin
 326                 # and end, all to $;.
 327                 if ($sanitise_quote eq '' && substr($line, $off, 2) eq '/*') {
 328                         $sanitise_quote = '*/';
 329
 330                         substr($res, $off, 2, "$;$;");
 331                         $off++;
 332                         next;
 333                 }
 334                 if (substr($line, $off, 2) eq '*/') {
 335                         $sanitise_quote = '';
 336                         substr($res, $off, 2, "$;$;");
 337                         $off++;
 338                         next;
 339                 }
 340
 341                 # A \ in a string means ignore the next character.
 342                 if (($sanitise_quote eq "'" || $sanitise_quote eq '"') &&
 343                     $c eq "\\") {
 344                         substr($res, $off, 2, 'XX');
 345                         $off++;
 346                         next;
 347                 }
 348                 # Regular quotes.
 349                 if ($c eq "'" || $c eq '"') {
 350                         if ($sanitise_quote eq '') {
 351                                 $sanitise_quote = $c;
 352
 353                                 substr($res, $off, 1, $c);
 354                                 next;
 355                         } elsif ($sanitise_quote eq $c) {
 356                                 $sanitise_quote = '';
 357                         }
 358                 }
 359
 360                 #print "SQ:$sanitise_quote\n";
 361                 if ($off != 0 && $sanitise_quote eq '*/' && $c ne "\t") {
 362                         substr($res, $off, 1, $;);
 363                 } elsif ($off != 0 && $sanitise_quote && $c ne "\t") {
 364                         substr($res, $off, 1, 'X');
 365                 } else {
 366                         substr($res, $off, 1, $c);
 367                 }
 368         }
 369
 370         # The pathname on a #include may be surrounded by '<' and '>'.
 371         if ($res =~ /^.\s*\#\s*include\s+\<(.*)\>/) {
 372                 my $clean = 'X' x length($1);
 373                 $res =~ s@\<.*\>@<$clean>@;
 374
 375         # The whole of a #error is a string.
 376         } elsif ($res =~ /^.\s*\#\s*(?:error|warning)\s+(.*)\b/) {
 377                 my $clean = 'X' x length($1);
 378                 $res =~ s@(\#\s*(?:error|warning)\s+).*@$1$clean@;
 379         }
 380
 381         return $res;
 382 }
 383
 384 sub ctx_statement_block {
 385         my ($linenr, $remain, $off) = @_;
 386         my $line = $linenr - 1;
 387         my $blk = '';
 388         my $soff = $off;
 389         my $coff = $off - 1;
 390         my $coff_set = 0;
 391
 392         my $loff = 0;
 393
 394         my $type = '';
 395         my $level = 0;
 396         my $p;
 397         my $c;
 398         my $len = 0;
 399
 400         my $remainder;
 401         while (1) {
 402                 #warn "CSB: blk<$blk> remain<$remain>\n";
 403                 # If we are about to drop off the end, pull in more
 404                 # context.
 405                 if ($off >= $len) {
 406                         for (; $remain > 0; $line++) {
 407                                 next if ($lines[$line] =~ /^-/);
 408                                 $remain--;
 409                                 $loff = $len;
 410                                 $blk .= $lines[$line] . "\n";
 411                                 $len = length($blk);
 412                                 $line++;
 413                                 last;
 414                         }
 415                         # Bail if there is no further context.
 416                         #warn "CSB: blk<$blk> off<$off> len<$len>\n";
 417                         if ($off >= $len) {
 418                                 last;
 419                         }
 420                 }
 421                 $p = $c;
 422                 $c = substr($blk, $off, 1);
 423                 $remainder = substr($blk, $off);
 424
 425                 #warn "CSB: c<$c> type<$type> level<$level> remainder<$remainder> coff_set<$coff_set>\n";
 426                 # Statement ends at the ';' or a close '}' at the
 427                 # outermost level.
 428                 if ($level == 0 && $c eq ';') {
 429                         last;
 430                 }
 431
 432                 # An else is really a conditional as long as its not else if
 433                 if ($level == 0 && $coff_set == 0 &&
 434                                 (!defined($p) || $p =~ /(?:\s|\}|\+)/) &&
 435                                 $remainder =~ /^(else)(?:\s|{)/ &&
 436                                 $remainder !~ /^else\s+if\b/) {
 437                         $coff = $off + length($1) - 1;
 438                         $coff_set = 1;
 439                         #warn "CSB: mark coff<$coff> soff<$soff> 1<$1>\n";
 440                         #warn "[" . substr($blk, $soff, $coff - $soff + 1) . "]\n";
 441                 }
 442
 443                 if (($type eq '' || $type eq '(') && $c eq '(') {
 444                         $level++;
 445                         $type = '(';
 446                 }
 447                 if ($type eq '(' && $c eq ')') {
 448                         $level--;
 449                         $type = ($level != 0)? '(' : '';
 450
 451                         if ($level == 0 && $coff < $soff) {
 452                                 $coff = $off;
 453                                 $coff_set = 1;
 454                                 #warn "CSB: mark coff<$coff>\n";
 455                         }
 456                 }
 457                 if (($type eq '' || $type eq '{') && $c eq '{') {
 458                         $level++;
 459                         $type = '{';
 460                 }
 461                 if ($type eq '{' && $c eq '}') {
 462                         $level--;
 463                         $type = ($level != 0)? '{' : '';
 464
 465                         if ($level == 0) {
 466                                 last;
 467                         }
 468                 }
 469                 $off++;
 470         }
 471         # We are truly at the end, so shuffle to the next line.
 472         if ($off == $len) {
 473                 $loff = $len + 1;
 474                 $line++;
 475                 $remain--;
 476         }
 477
 478         my $statement = substr($blk, $soff, $off - $soff + 1);
 479         my $condition = substr($blk, $soff, $coff - $soff + 1);
 480
 481         #warn "STATEMENT<$statement>\n";
 482         #warn "CONDITION<$condition>\n";
 483
 484         #print "coff<$coff> soff<$off> loff<$loff>\n";
 485
 486         return ($statement, $condition,
 487                         $line, $remain + 1, $off - $loff + 1, $level);
 488 }
 489
 490 sub statement_lines {
 491         my ($stmt) = @_;
 492
 493         # Strip the diff line prefixes and rip blank lines at start and end.
 494         $stmt =~ s/(^|\n)./$1/g;
 495         $stmt =~ s/^\s*//;
 496         $stmt =~ s/\s*$//;
 497
 498         my @stmt_lines = ($stmt =~ /\n/g);
 499
 500         return $#stmt_lines + 2;
 501 }
 502
 503 sub statement_rawlines {
 504         my ($stmt) = @_;
 505
 506         my @stmt_lines = ($stmt =~ /\n/g);
 507
 508         return $#stmt_lines + 2;
 509 }
 510
 511 sub statement_block_size {
 512         my ($stmt) = @_;
 513
 514         $stmt =~ s/(^|\n)./$1/g;
 515         $stmt =~ s/^\s*{//;
 516         $stmt =~ s/}\s*$//;
 517         $stmt =~ s/^\s*//;
 518         $stmt =~ s/\s*$//;
 519
 520         my @stmt_lines = ($stmt =~ /\n/g);
 521         my @stmt_statements = ($stmt =~ /;/g);
 522
 523         my $stmt_lines = $#stmt_lines + 2;
 524         my $stmt_statements = $#stmt_statements + 1;
 525
 526         if ($stmt_lines > $stmt_statements) {
 527                 return $stmt_lines;
 528         } else {
 529                 return $stmt_statements;
 530         }
 531 }
 532
 533 sub ctx_statement_full {
 534         my ($linenr, $remain, $off) = @_;
 535         my ($statement, $condition, $level);
 536
 537         my (@chunks);
 538
 539         # Grab the first conditional/block pair.
 540         ($statement, $condition, $linenr, $remain, $off, $level) =
 541                                 ctx_statement_block($linenr, $remain, $off);
 542         #print "F: c<$condition> s<$statement> remain<$remain>\n";
 543         push(@chunks, [ $condition, $statement ]);
 544         if (!($remain > 0 && $condition =~ /^\s*(?:\n[+-])?\s*(?:if|else|do)\b/s)) {
 545                 return ($level, $linenr, @chunks);
 546         }
 547
 548         # Pull in the following conditional/block pairs and see if they
 549         # could continue the statement.
 550         for (;;) {
 551                 ($statement, $condition, $linenr, $remain, $off, $level) =
 552                                 ctx_statement_block($linenr, $remain, $off);
 553                 #print "C: c<$condition> s<$statement> remain<$remain>\n";
 554                 last if (!($remain > 0 && $condition =~ /^(?:\s*\n[+-])*\s*(?:else|do)\b/s));
 555                 #print "C: push\n";
 556                 push(@chunks, [ $condition, $statement ]);
 557         }
 558
 559         return ($level, $linenr, @chunks);
 560 }
 561
 562 sub ctx_block_get {
 563         my ($linenr, $remain, $outer, $open, $close, $off) = @_;
 564         my $line;
 565         my $start = $linenr - 1;
 566         my $blk = '';
 567         my @o;
 568         my @c;
 569         my @res = ();
 570
 571         my $level = 0;
 572         for ($line = $start; $remain > 0; $line++) {
 573                 next if ($rawlines[$line] =~ /^-/);
 574                 $remain--;
 575
 576                 $blk .= $rawlines[$line];
 577                 foreach my $c (split(//, $rawlines[$line])) {
 578                         ##print "C<$c>L<$level><$open$close>O<$off>\n";
 579                         if ($off > 0) {
 580                                 $off--;
 581                                 next;
 582                         }
 583
 584                         if ($c eq $close && $level > 0) {
 585                                 $level--;
 586                                 last if ($level == 0);
 587                         } elsif ($c eq $open) {
 588                                 $level++;
 589                         }
 590                 }
 591
 592                 if (!$outer || $level <= 1) {
 593                         push(@res, $rawlines[$line]);
 594                 }
 595
 596                 last if ($level == 0);
 597         }
 598
 599         return ($level, @res);
 600 }
 601 sub ctx_block_outer {
 602         my ($linenr, $remain) = @_;
 603
 604         my ($level, @r) = ctx_block_get($linenr, $remain, 1, '{', '}', 0);
 605         return @r;
 606 }
 607 sub ctx_block {
 608         my ($linenr, $remain) = @_;
 609
 610         my ($level, @r) = ctx_block_get($linenr, $remain, 0, '{', '}', 0);
 611         return @r;
 612 }
 613 sub ctx_statement {
 614         my ($linenr, $remain, $off) = @_;
 615
 616         my ($level, @r) = ctx_block_get($linenr, $remain, 0, '(', ')', $off);
 617         return @r;
 618 }
 619 sub ctx_block_level {
 620         my ($linenr, $remain) = @_;
 621
 622         return ctx_block_get($linenr, $remain, 0, '{', '}', 0);
 623 }
 624 sub ctx_statement_level {
 625         my ($linenr, $remain, $off) = @_;
 626
 627         return ctx_block_get($linenr, $remain, 0, '(', ')', $off);
 628 }
 629
 630 sub ctx_locate_comment {
 631         my ($first_line, $end_line) = @_;
 632
 633         # Catch a comment on the end of the line itself.
 634         my ($current_comment) = ($rawlines[$end_line - 1] =~ m@.*(/\*.*\*/)\s*(?:\\\s*)?$@);
 635         return $current_comment if (defined $current_comment);
 636
 637         # Look through the context and try and figure out if there is a
 638         # comment.
 639         my $in_comment = 0;
 640         $current_comment = '';
 641         for (my $linenr = $first_line; $linenr < $end_line; $linenr++) {
 642                 my $line = $rawlines[$linenr - 1];
 643                 #warn "           $line\n";
 644                 if ($linenr == $first_line and $line =~ m@^.\s*\*@) {
 645                         $in_comment = 1;
 646                 }
 647                 if ($line =~ m@/\*@) {
 648                         $in_comment = 1;
 649                 }
 650                 if (!$in_comment && $current_comment ne '') {
 651                         $current_comment = '';
 652                 }
 653                 $current_comment .= $line . "\n" if ($in_comment);
 654                 if ($line =~ m@\*/@) {
 655                         $in_comment = 0;
 656                 }
 657         }
 658
 659         chomp($current_comment);
 660         return($current_comment);
 661 }
 662 sub ctx_has_comment {
 663         my ($first_line, $end_line) = @_;
 664         my $cmt = ctx_locate_comment($first_line, $end_line);
 665
 666         ##print "LINE: $rawlines[$end_line - 1 ]\n";
 667         ##print "CMMT: $cmt\n";
 668
 669         return ($cmt ne '');
 670 }
 671
 672 sub cat_vet {
 673         my ($vet) = @_;
 674         my ($res, $coded);
 675
 676         $res = '';
 677         while ($vet =~ /([^[:cntrl:]]*)([[:cntrl:]]|$)/g) {
 678                 $res .= $1;
 679                 if ($2 ne '') {
 680                         $coded = sprintf("^%c", unpack('C', $2) + 64);
 681                         $res .= $coded;
 682                 }
 683         }
 684         $res =~ s/$/\$/;
 685
 686         return $res;
 687 }
 688
 689 my $av_preprocessor = 0;
 690 my $av_pending;
 691 my @av_paren_type;
 692
 693 sub annotate_reset {
 694         $av_preprocessor = 0;
 695         $av_pending = '_';
 696         @av_paren_type = ('E');
 697 }
 698
 699 sub annotate_values {
 700         my ($stream, $type) = @_;
 701
 702         my $res;
 703         my $cur = $stream;
 704
 705         print "$stream\n" if ($dbg_values > 1);
 706
 707         while (length($cur)) {
 708                 @av_paren_type = ('E') if ($#av_paren_type < 0);
 709                 print " <" . join('', @av_paren_type) .
 710                                 "> <$type> <$av_pending>" if ($dbg_values > 1);
 711                 if ($cur =~ /^(\s+)/o) {
 712                         print "WS($1)\n" if ($dbg_values > 1);
 713                         if ($1 =~ /\n/ && $av_preprocessor) {
 714                                 $type = pop(@av_paren_type);
 715                                 $av_preprocessor = 0;
 716                         }
 717
 718                 } elsif ($cur =~ /^($Type)\s*(?:$Ident|,|\)|\()/) {
 719                         print "DECLARE($1)\n" if ($dbg_values > 1);
 720                         $type = 'T';
 721
 722                 } elsif ($cur =~ /^($Modifier)\s*/) {
 723                         print "MODIFIER($1)\n" if ($dbg_values > 1);
 724                         $type = 'T';
 725
 726                 } elsif ($cur =~ /^(\#\s*define\s*$Ident)(\(?)/o) {
 727                         print "DEFINE($1,$2)\n" if ($dbg_values > 1);
 728                         $av_preprocessor = 1;
 729                         push(@av_paren_type, $type);
 730                         if ($2 ne '') {
 731                                 $av_pending = 'N';
 732                         }
 733                         $type = 'E';
 734
 735                 } elsif ($cur =~ /^(\#\s*(?:undef\s*$Ident|include\b))/o) {
 736                         print "UNDEF($1)\n" if ($dbg_values > 1);
 737                         $av_preprocessor = 1;
 738                         push(@av_paren_type, $type);
 739
 740                 } elsif ($cur =~ /^(\#\s*(?:ifdef|ifndef|if))/o) {
 741                         print "PRE_START($1)\n" if ($dbg_values > 1);
 742                         $av_preprocessor = 1;
 743
 744                         push(@av_paren_type, $type);
 745                         push(@av_paren_type, $type);
 746                         $type = 'E';
 747
 748                 } elsif ($cur =~ /^(\#\s*(?:else|elif))/o) {
 749                         print "PRE_RESTART($1)\n" if ($dbg_values > 1);
 750                         $av_preprocessor = 1;
 751
 752                         push(@av_paren_type, $av_paren_type[$#av_paren_type]);
 753
 754                         $type = 'E';
 755
 756                 } elsif ($cur =~ /^(\#\s*(?:endif))/o) {
 757                         print "PRE_END($1)\n" if ($dbg_values > 1);
 758
 759                         $av_preprocessor = 1;
 760
 761                         # Assume all arms of the conditional end as this
 762                         # one does, and continue as if the #endif was not here.
 763                         pop(@av_paren_type);
 764                         push(@av_paren_type, $type);
 765                         $type = 'E';
 766
 767                 } elsif ($cur =~ /^(\\\n)/o) {
 768                         print "PRECONT($1)\n" if ($dbg_values > 1);
 769
 770                 } elsif ($cur =~ /^(__attribute__)\s*\(?/o) {
 771                         print "ATTR($1)\n" if ($dbg_values > 1);
 772                         $av_pending = $type;
 773                         $type = 'N';
 774
 775                 } elsif ($cur =~ /^(sizeof)\s*(\()?/o) {
 776                         print "SIZEOF($1)\n" if ($dbg_values > 1);
 777                         if (defined $2) {
 778                                 $av_pending = 'V';
 779                         }
 780                         $type = 'N';
 781
 782                 } elsif ($cur =~ /^(if|while|typeof|__typeof__|for)\b/o) {
 783                         print "COND($1)\n" if ($dbg_values > 1);
 784                         $av_pending = 'N';
 785                         $type = 'N';
 786
 787                 } elsif ($cur =~/^(return|case|else|goto)/o) {
 788                         print "KEYWORD($1)\n" if ($dbg_values > 1);
 789                         $type = 'N';
 790
 791                 } elsif ($cur =~ /^(\()/o) {
 792                         print "PAREN('$1')\n" if ($dbg_values > 1);
 793                         push(@av_paren_type, $av_pending);
 794                         $av_pending = '_';
 795                         $type = 'N';
 796
 797                 } elsif ($cur =~ /^(\))/o) {
 798                         my $new_type = pop(@av_paren_type);
 799                         if ($new_type ne '_') {
 800                                 $type = $new_type;
 801                                 print "PAREN('$1') -> $type\n"
 802                                                         if ($dbg_values > 1);
 803                         } else {
 804                                 print "PAREN('$1')\n" if ($dbg_values > 1);
 805                         }
 806
 807                 } elsif ($cur =~ /^($Ident)\s*\(/o) {
 808                         print "FUNC($1)\n" if ($dbg_values > 1);
 809                         $type = 'V';
 810                         $av_pending = 'V';
 811
 812                 } elsif ($cur =~ /^($Ident|$Constant)/o) {
 813                         print "IDENT($1)\n" if ($dbg_values > 1);
 814                         $type = 'V';
 815
 816                 } elsif ($cur =~ /^($Assignment)/o) {
 817                         print "ASSIGN($1)\n" if ($dbg_values > 1);
 818                         $type = 'N';
 819
 820                 } elsif ($cur =~/^(;|{|})/) {
 821                         print "END($1)\n" if ($dbg_values > 1);
 822                         $type = 'E';
 823
 824                 } elsif ($cur =~ /^(;|\?|:|\[)/o) {
 825                         print "CLOSE($1)\n" if ($dbg_values > 1);
 826                         $type = 'N';
 827
 828                 } elsif ($cur =~ /^($Operators)/o) {
 829                         print "OP($1)\n" if ($dbg_values > 1);
 830                         if ($1 ne '++' && $1 ne '--') {
 831                                 $type = 'N';
 832                         }
 833
 834                 } elsif ($cur =~ /(^.)/o) {
 835                         print "C($1)\n" if ($dbg_values > 1);
 836                 }
 837                 if (defined $1) {
 838                         $cur = substr($cur, length($1));
 839                         $res .= $type x length($1);
 840                 }
 841         }
 842
 843         return $res;
 844 }
 845
 846 sub possible {
 847         my ($possible, $line) = @_;
 848
 849         print "CHECK<$possible> ($line)\n" if ($dbg_possible > 1);
 850         if ($possible !~ /^(?:$Modifier|$Storage|$Type|DEFINE_\S+)$/ &&
 851             $possible ne 'goto' && $possible ne 'return' &&
 852             $possible ne 'case' && $possible ne 'else' &&
 853             $possible ne 'asm' && $possible ne '__asm__' &&
 854             $possible !~ /^(typedef|struct|enum)\b/) {
 855                 # Check for modifiers.
 856                 $possible =~ s/\s*$Storage\s*//g;
 857                 $possible =~ s/\s*$Sparse\s*//g;
 858                 if ($possible =~ /^\s*$/) {
 859
 860                 } elsif ($possible =~ /\s/) {
 861                         $possible =~ s/\s*$Type\s*//g;
 862                         warn "MODIFIER: $possible ($line)\n" if ($dbg_possible);
 863                         push(@modifierList, $possible);
 864
 865                 } else {
 866                         warn "POSSIBLE: $possible ($line)\n" if ($dbg_possible);
 867                         push(@typeList, $possible);
 868                 }
 869                 build_types();
 870         }
 871 }
 872
 873 my $prefix = '';
 874
 875 sub report {
 876         if (defined $tst_only && $_[0] !~ /\Q$tst_only\E/) {
 877                 return 0;
 878         }
 879         my $line = $prefix . $_[0];
 880
 881         $line = (split('\n', $line))[0] . "\n" if ($terse);
 882
 883         push(our @report, $line);
 884
 885         return 1;
 886 }
 887 sub report_dump {
 888         our @report;
 889 }
 890 sub ERROR {
 891         if (report("ERROR: $_[0]\n")) {
 892                 our $clean = 0;
 893                 our $cnt_error++;
 894         }
 895 }
 896 sub WARN {
 897         if (report("WARNING: $_[0]\n")) {
 898                 our $clean = 0;
 899                 our $cnt_warn++;
 900         }
 901 }
 902 sub CHK {
 903         if ($check && report("CHECK: $_[0]\n")) {
 904                 our $clean = 0;
 905                 our $cnt_chk++;
 906         }
 907 }
 908
 909 sub process {
 910         my $filename = shift;
 911
 912         my $linenr=0;
 913         my $prevline="";
 914         my $prevrawline="";
 915         my $stashline="";
 916         my $stashrawline="";
 917
 918         my $length;
 919         my $indent;
 920         my $previndent=0;
 921         my $stashindent=0;
 922
 923         our $clean = 1;
 924         my $signoff = 0;
 925         my $is_patch = 0;
 926
 927         our @report = ();
 928         our $cnt_lines = 0;
 929         our $cnt_error = 0;
 930         our $cnt_warn = 0;
 931         our $cnt_chk = 0;
 932
 933         # Trace the real file/line as we go.
 934         my $realfile = '';
 935         my $realline = 0;
 936         my $realcnt = 0;
 937         my $here = '';
 938         my $in_comment = 0;
 939         my $comment_edge = 0;
 940         my $first_line = 0;
 941
 942         my $prev_values = 'E';
 943
 944         # suppression flags
 945         my %suppress_ifbraces;
 946
 947         # Pre-scan the patch sanitizing the lines.
 948         # Pre-scan the patch looking for any __setup documentation.
 949         #
 950         my @setup_docs = ();
 951         my $setup_docs = 0;
 952
 953         sanitise_line_reset();
 954         my $line;
 955         foreach my $rawline (@rawlines) {
 956                 $linenr++;
 957                 $line = $rawline;
 958
 959                 if ($rawline=~/^\+\+\+\s+(\S+)/) {
 960                         $setup_docs = 0;
 961                         if ($1 =~ m@Documentation/kernel-parameters.txt$@) {
 962                                 $setup_docs = 1;
 963                         }
 964                         #next;
 965                 }
 966                 if ($rawline=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
 967                         $realline=$1-1;
 968                         if (defined $2) {
 969                                 $realcnt=$3+1;
 970                         } else {
 971                                 $realcnt=1+1;
 972                         }
 973                         $in_comment = 0;
 974
 975                         # Guestimate if this is a continuing comment.  Run
 976                         # the context looking for a comment "edge".  If this
 977                         # edge is a close comment then we must be in a comment
 978                         # at context start.
 979                         my $edge;
 980                         for (my $ln = $linenr + 1; $ln < ($linenr + $realcnt); $ln++) {
 981                                 next if ($line =~ /^-/);
 982                                 ($edge) = ($rawlines[$ln - 1] =~ m@(/\*|\*/)@);
 983                                 last if (defined $edge);
 984                         }
 985                         if (defined $edge && $edge eq '*/') {
 986                                 $in_comment = 1;
 987                         }
 988
 989                         # Guestimate if this is a continuing comment.  If this
 990                         # is the start of a diff block and this line starts
 991                         # ' *' then it is very likely a comment.
 992                         if (!defined $edge &&
 993                             $rawlines[$linenr] =~ m@^.\s* \*(?:\s|$)@)
 994                         {
 995                                 $in_comment = 1;
 996                         }
 997
 998                         ##print "COMMENT:$in_comment edge<$edge> $rawline\n";
 999                         sanitise_line_reset($in_comment);
1000
1001                 } elsif ($realcnt && $rawline =~ /^(?:\+| |$)/) {
1002                         # Standardise the strings and chars within the input to
1003                         # simplify matching -- only bother with positive lines.
1004                         $line = sanitise_line($rawline);
1005                 }
1006                 push(@lines, $line);
1007
1008                 if ($realcnt > 1) {
1009                         $realcnt-- if ($line =~ /^(?:\+| |$)/);
1010                 } else {
1011                         $realcnt = 0;
1012                 }
1013
1014                 #print "==>$rawline\n";
1015                 #print "-->$line\n";
1016
1017                 if ($setup_docs && $line =~ /^\+/) {
1018                         push(@setup_docs, $line);
1019                 }
1020         }
1021
1022         $prefix = '';
1023
1024         $realcnt = 0;
1025         $linenr = 0;
1026         foreach my $line (@lines) {
1027                 $linenr++;
1028
1029                 my $rawline = $rawlines[$linenr - 1];
1030
1031 #extract the line range in the file after the patch is applied
1032                 if ($line=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
1033                         $is_patch = 1;
1034                         $first_line = $linenr + 1;
1035                         $realline=$1-1;
1036                         if (defined $2) {
1037                                 $realcnt=$3+1;
1038                         } else {
1039                                 $realcnt=1+1;
1040                         }
1041                         annotate_reset();
1042                         $prev_values = 'E';
1043
1044                         %suppress_ifbraces = ();
1045                         next;
1046
1047 # track the line number as we move through the hunk, note that
1048 # new versions of GNU diff omit the leading space on completely
1049 # blank context lines so we need to count that too.
1050                 } elsif ($line =~ /^( |\+|$)/) {
1051                         $realline++;
1052                         $realcnt-- if ($realcnt != 0);
1053
1054                         # Measure the line length and indent.
1055                         ($length, $indent) = line_stats($rawline);
1056
1057                         # Track the previous line.
1058                         ($prevline, $stashline) = ($stashline, $line);
1059                         ($previndent, $stashindent) = ($stashindent, $indent);
1060                         ($prevrawline, $stashrawline) = ($stashrawline, $rawline);
1061
1062                         #warn "line<$line>\n";
1063
1064                 } elsif ($realcnt == 1) {
1065                         $realcnt--;
1066                 }
1067
1068 #make up the handle for any error we report on this line
1069                 $prefix = "$filename:$realline: " if ($emacs && $file);
1070                 $prefix = "$filename:$linenr: " if ($emacs && !$file);
1071
1072                 $here = "#$linenr: " if (!$file);
1073                 $here = "#$realline: " if ($file);
1074
1075                 # extract the filename as it passes
1076                 if ($line=~/^\+\+\+\s+(\S+)/) {
1077                         $realfile = $1;
1078                         $realfile =~ s@^[^/]*/@@;
1079
1080                         if ($realfile =~ m@include/asm/@) {
1081                                 ERROR("do not modify files in include/asm, change architecture specific files in include/asm-<architecture>\n" . "$here$rawline\n");
1082                         }
1083                         next;
1084                 }
1085
1086                 $here .= "FILE: $realfile:$realline:" if ($realcnt != 0);
1087
1088                 my $hereline = "$here\n$rawline\n";
1089                 my $herecurr = "$here\n$rawline\n";
1090                 my $hereprev = "$here\n$prevrawline\n$rawline\n";
1091
1092                 $cnt_lines++ if ($realcnt != 0);
1093
1094 #check the patch for a signoff:
1095                 if ($line =~ /^\s*signed-off-by:/i) {
1096                         # This is a signoff, if ugly, so do not double report.
1097                         $signoff++;
1098                         if (!($line =~ /^\s*Signed-off-by:/)) {
1099                                 WARN("Signed-off-by: is the preferred form\n" .
1100                                         $herecurr);
1101                         }
1102                         if ($line =~ /^\s*signed-off-by:\S/i) {
1103                                 WARN("space required after Signed-off-by:\n" .
1104                                         $herecurr);
1105                         }
1106                 }
1107
1108 # Check for wrappage within a valid hunk of the file
1109                 if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) {
1110                         ERROR("patch seems to be corrupt (line wrapped?)\n" .
1111                                 $herecurr) if (!$emitted_corrupt++);
1112                 }
1113
1114 # UTF-8 regex found at http://www.w3.org/International/questions/qa-forms-utf-8.en.php
1115                 if (($realfile =~ /^$/ || $line =~ /^\+/) &&
1116                     $rawline !~ m/^$UTF8*$/) {
1117                         my ($utf8_prefix) = ($rawline =~ /^($UTF8*)/);
1118
1119                         my $blank = copy_spacing($rawline);
1120                         my $ptr = substr($blank, 0, length($utf8_prefix)) . "^";
1121                         my $hereptr = "$hereline$ptr\n";
1122
1123                         ERROR("Invalid UTF-8, patch and commit message should be encoded in UTF-8\n" . $hereptr);
1124                 }
1125
1126 #ignore lines being removed
1127                 if ($line=~/^-/) {next;}
1128
1129 # check we are in a valid source file if not then ignore this hunk
1130                 next if ($realfile !~ /\.(h|c|s|S|pl|sh)$/);
1131
1132 #trailing whitespace
1133                 if ($line =~ /^\+.*\015/) {
1134                         my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1135                         ERROR("DOS line endings\n" . $herevet);
1136
1137                 } elsif ($rawline =~ /^\+.*\S\s+$/ || $rawline =~ /^\+\s+$/) {
1138                         my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1139                         ERROR("trailing whitespace\n" . $herevet);
1140                 }
1141 #80 column limit
1142                 if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ &&
1143                     $rawline !~ /^.\s*\*\s*\@$Ident\s/ &&
1144                     $line !~ /^\+\s*printk\s*\(\s*(?:KERN_\S+\s*)?"[X\t]*"\s*(?:,|\)\s*;)\s*$/ &&
1145                     $length > 80)
1146                 {
1147                         WARN("line over 80 characters\n" . $herecurr);
1148                 }
1149
1150 # check for adding lines without a newline.
1151                 if ($line =~ /^\+/ && defined $lines[$linenr] && $lines[$linenr] =~ /^\\ No newline at end of file/) {
1152                         WARN("adding a line without newline at end of file\n" . $herecurr);
1153                 }
1154
1155 # check we are in a valid source file *.[hc] if not then ignore this hunk
1156                 next if ($realfile !~ /\.[hc]$/);
1157
1158 # at the beginning of a line any tabs must come first and anything
1159 # more than 8 must use tabs.
1160                 if ($rawline =~ /^\+\s* \t\s*\S/ ||
1161                     $rawline =~ /^\+\s*        \s*/) {
1162                         my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1163                         ERROR("code indent should use tabs where possible\n" . $herevet);
1164                 }
1165
1166 # check for RCS/CVS revision markers
1167                 if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) {
1168                         WARN("CVS style keyword markers, these will _not_ be updated\n". $herecurr);
1169                 }
1170
1171 # Check for potential 'bare' types
1172                 my ($stat, $cond, $line_nr_next, $remain_next);
1173                 if ($realcnt && $line =~ /.\s*\S/) {
1174                         ($stat, $cond, $line_nr_next, $remain_next) =
1175                                 ctx_statement_block($linenr, $realcnt, 0);
1176                         $stat =~ s/\n./\n /g;
1177                         $cond =~ s/\n./\n /g;
1178
1179                         my $s = $stat;
1180                         $s =~ s/{.*$//s;
1181
1182                         # Ignore goto labels.
1183                         if ($s =~ /$Ident:\*$/s) {
1184
1185                         # Ignore functions being called
1186                         } elsif ($s =~ /^.\s*$Ident\s*\(/s) {
1187
1188                         # declarations always start with types
1189                         } elsif ($prev_values eq 'E' && $s =~ /^.\s*(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?((?:\s*$Ident)+)\b(?:\s+$Sparse)?\s*\**\s*(?:$Ident|\(\*[^\)]*\))\s*(?:;|=|,|\()/s) {
1190                                 my $type = $1;
1191                                 $type =~ s/\s+/ /g;
1192                                 possible($type, "A:" . $s);
1193
1194                         # definitions in global scope can only start with types
1195                         } elsif ($s =~ /^.(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?($Ident)\b/s) {
1196                                 possible($1, "B:" . $s);
1197                         }
1198
1199                         # any (foo ... *) is a pointer cast, and foo is a type
1200                         while ($s =~ /\(($Ident)(?:\s+$Sparse)*\s*\*+\s*\)/sg) {
1201                                 possible($1, "C:" . $s);
1202                         }
1203
1204                         # Check for any sort of function declaration.
1205                         # int foo(something bar, other baz);
1206                         # void (*store_gdt)(x86_descr_ptr *);
1207                         if ($prev_values eq 'E' && $s =~ /^(.(?:typedef\s*)?(?:(?:$Storage|$Inline)\s*)*\s*$Type\s*(?:\b$Ident|\(\*\s*$Ident\))\s*)\(/s) {
1208                                 my ($name_len) = length($1);
1209
1210                                 my $ctx = $s;
1211                                 substr($ctx, 0, $name_len + 1, '');
1212                                 $ctx =~ s/\)[^\)]*$//;
1213
1214                                 for my $arg (split(/\s*,\s*/, $ctx)) {
1215                                         if ($arg =~ /^(?:const\s+)?($Ident)(?:\s+$Sparse)*\s*\**\s*(:?\b$Ident)?$/s || $arg =~ /^($Ident)$/s) {
1216
1217                                                 possible($1, "D:" . $s);
1218                                         }
1219                                 }
1220                         }
1221
1222                 }
1223
1224 #
1225 # Checks which may be anchored in the context.
1226 #
1227
1228 # Check for switch () and associated case and default
1229 # statements should be at the same indent.
1230                 if ($line=~/\bswitch\s*\(.*\)/) {
1231                         my $err = '';
1232                         my $sep = '';
1233                         my @ctx = ctx_block_outer($linenr, $realcnt);
1234                         shift(@ctx);
1235                         for my $ctx (@ctx) {
1236                                 my ($clen, $cindent) = line_stats($ctx);
1237                                 if ($ctx =~ /^\+\s*(case\s+|default:)/ &&
1238                                                         $indent != $cindent) {
1239                                         $err .= "$sep$ctx\n";
1240                                         $sep = '';
1241                                 } else {
1242                                         $sep = "[...]\n";
1243                                 }
1244                         }
1245                         if ($err ne '') {
1246                                 ERROR("switch and case should be at the same indent\n$hereline$err");
1247                         }
1248                 }
1249                 if ($line =~ /^.\s*(?:case\s*.*|default\s*):/g &&
1250                     $line !~ /\G(?:\s*{)?(?:\s*$;*)(?:\s*\\)?\s*$/g) {
1251                         ERROR("trailing statements should be on next line\n" . $herecurr);
1252                 }
1253
1254 # if/while/etc brace do not go on next line, unless defining a do while loop,
1255 # or if that brace on the next line is for something else
1256                 if ($line =~ /(.*)\b((?:if|while|for|switch)\s*\(|do\b|else\b)/ && $line !~ /^.\s*\#/) {
1257                         my $pre_ctx = "$1$2";
1258
1259                         my ($level, @ctx) = ctx_statement_level($linenr, $realcnt, 0);
1260                         my $ctx_cnt = $realcnt - $#ctx - 1;
1261                         my $ctx = join("\n", @ctx);
1262
1263                         my $ctx_ln = $linenr;
1264                         my $ctx_skip = $realcnt;
1265
1266                         while ($ctx_skip > $ctx_cnt || ($ctx_skip == $ctx_cnt &&
1267                                         defined $lines[$ctx_ln - 1] &&
1268                                         $lines[$ctx_ln - 1] =~ /^-/)) {
1269                                 ##print "SKIP<$ctx_skip> CNT<$ctx_cnt>\n";
1270                                 $ctx_skip-- if (!defined $lines[$ctx_ln - 1] || $lines[$ctx_ln - 1] !~ /^-/);
1271                                 $ctx_ln++;
1272                         }
1273
1274                         #print "realcnt<$realcnt> ctx_cnt<$ctx_cnt>\n";
1275                         #print "pre<$pre_ctx>\nline<$line>\nctx<$ctx>\nnext<$lines[$ctx_ln - 1]>\n";
1276
1277                         if ($ctx !~ /{\s*/ && defined($lines[$ctx_ln -1]) && $lines[$ctx_ln - 1] =~ /^\+\s*{/) {
1278                                 ERROR("that open brace { should be on the previous line\n" .
1279                                         "$here\n$ctx\n$lines[$ctx_ln - 1]\n");
1280                         }
1281                         if ($level == 0 && $pre_ctx !~ /}\s*while\s*\($/ &&
1282                             $ctx =~ /\)\s*\;\s*$/ &&
1283                             defined $lines[$ctx_ln - 1])
1284                         {
1285                                 my ($nlength, $nindent) = line_stats($lines[$ctx_ln - 1]);
1286                                 if ($nindent > $indent) {
1287                                         WARN("trailing semicolon indicates no statements, indent implies otherwise\n" .
1288                                                 "$here\n$ctx\n$lines[$ctx_ln - 1]\n");
1289                                 }
1290                         }
1291                 }
1292
1293                 # Track the 'values' across context and added lines.
1294                 my $opline = $line; $opline =~ s/^./ /;
1295                 my $curr_values = annotate_values($opline . "\n", $prev_values);
1296                 $curr_values = $prev_values . $curr_values;
1297                 if ($dbg_values) {
1298                         my $outline = $opline; $outline =~ s/\t/ /g;
1299                         print "$linenr > .$outline\n";
1300                         print "$linenr > $curr_values\n";
1301                 }
1302                 $prev_values = substr($curr_values, -1);
1303
1304 #ignore lines not being added
1305                 if ($line=~/^[^\+]/) {next;}
1306
1307 # TEST: allow direct testing of the type matcher.
1308                 if ($dbg_type) {
1309                         if ($line =~ /^.\s*$Declare\s*$/) {
1310                                 ERROR("TEST: is type\n" . $herecurr);
1311                         } elsif ($dbg_type > 1 && $line =~ /^.+($Declare)/) {
1312                                 ERROR("TEST: is not type ($1 is)\n". $herecurr);
1313                         }
1314                         next;
1315                 }
1316
1317 # check for initialisation to aggregates open brace on the next line
1318                 if ($prevline =~ /$Declare\s*$Ident\s*=\s*$/ &&
1319                     $line =~ /^.\s*{/) {
1320                         ERROR("that open brace { should be on the previous line\n" . $hereprev);
1321                 }
1322
1323 #
1324 # Checks which are anchored on the added line.
1325 #
1326
1327 # check for malformed paths in #include statements (uses RAW line)
1328                 if ($rawline =~ m{^.\s*\#\s*include\s+[<"](.*)[">]}) {
1329                         my $path = $1;
1330                         if ($path =~ m{//}) {
1331                                 ERROR("malformed #include filename\n" .
1332                                         $herecurr);
1333                         }
1334                 }
1335
1336 # no C99 // comments
1337                 if ($line =~ m{//}) {
1338                         ERROR("do not use C99 // comments\n" . $herecurr);
1339                 }
1340                 # Remove C99 comments.
1341                 $line =~ s@//.*@@;
1342                 $opline =~ s@//.*@@;
1343
1344 #EXPORT_SYMBOL should immediately follow its function closing }.
1345                 if (($line =~ /EXPORT_SYMBOL.*\((.*)\)/) ||
1346                     ($line =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) {
1347                         my $name = $1;
1348                         if (($prevline !~ /^}/) &&
1349                            ($prevline !~ /^\+}/) &&
1350                            ($prevline !~ /^ }/) &&
1351                            ($prevline !~ /^.DECLARE_$Ident\(\Q$name\E\)/) &&
1352                            ($prevline !~ /^.LIST_HEAD\(\Q$name\E\)/) &&
1353                            ($prevline !~ /^.$Type\s*\(\s*\*\s*\Q$name\E\s*\)\s*\(/) &&
1354                            ($prevline !~ /\b\Q$name\E(?:\s+$Attribute)?\s*(?:;|=|\[)/)) {
1355                                 WARN("EXPORT_SYMBOL(foo); should immediately follow its function/variable\n" . $herecurr);
1356                         }
1357                 }
1358
1359 # check for external initialisers.
1360                 if ($line =~ /^.$Type\s*$Ident\s*(?:\s+$Modifier)*\s*=\s*(0|NULL|false)\s*;/) {
1361                         ERROR("do not initialise externals to 0 or NULL\n" .
1362                                 $herecurr);
1363                 }
1364 # check for static initialisers.
1365                 if ($line =~ /\s*static\s.*=\s*(0|NULL|false)\s*;/) {
1366                         ERROR("do not initialise statics to 0 or NULL\n" .
1367                                 $herecurr);
1368                 }
1369
1370 # check for new typedefs, only function parameters and sparse annotations
1371 # make sense.
1372                 if ($line =~ /\btypedef\s/ &&
1373                     $line !~ /\btypedef\s+$Type\s+\(\s*\*?$Ident\s*\)\s*\(/ &&
1374                     $line !~ /\btypedef\s+$Type\s+$Ident\s*\(/ &&
1375                     $line !~ /\b__bitwise(?:__|)\b/) {
1376                         WARN("do not add new typedefs\n" . $herecurr);
1377                 }
1378
1379 # * goes on variable not on type
1380                 if ($line =~ m{\($NonptrType(\*+)(?:\s+const)?\)}) {
1381                         ERROR("\"(foo$1)\" should be \"(foo $1)\"\n" .
1382                                 $herecurr);
1383
1384                 } elsif ($line =~ m{\($NonptrType\s+(\*+)(?!\s+const)\s+\)}) {
1385                         ERROR("\"(foo $1 )\" should be \"(foo $1)\"\n" .
1386                                 $herecurr);
1387
1388                 } elsif ($line =~ m{$NonptrType(\*+)(?:\s+(?:$Attribute|$Sparse))?\s+[A-Za-z\d_]+}) {
1389                         ERROR("\"foo$1 bar\" should be \"foo $1bar\"\n" .
1390                                 $herecurr);
1391
1392                 } elsif ($line =~ m{$NonptrType\s+(\*+)(?!\s+(?:$Attribute|$Sparse))\s+[A-Za-z\d_]+}) {
1393                         ERROR("\"foo $1 bar\" should be \"foo $1bar\"\n" .
1394                                 $herecurr);
1395                 }
1396
1397 # # no BUG() or BUG_ON()
1398 #               if ($line =~ /\b(BUG|BUG_ON)\b/) {
1399 #                       print "Try to use WARN_ON & Recovery code rather than BUG() or BUG_ON()\n";
1400 #                       print "$herecurr";
1401 #                       $clean = 0;
1402 #               }
1403
1404                 if ($line =~ /\bLINUX_VERSION_CODE\b/) {
1405                         WARN("LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged\n" . $herecurr);
1406                 }
1407
1408 # printk should use KERN_* levels.  Note that follow on printk's on the
1409 # same line do not need a level, so we use the current block context
1410 # to try and find and validate the current printk.  In summary the current
1411 # printk includes all preceeding printk's which have no newline on the end.
1412 # we assume the first bad printk is the one to report.
1413                 if ($line =~ /\bprintk\((?!KERN_)\s*"/) {
1414                         my $ok = 0;
1415                         for (my $ln = $linenr - 1; $ln >= $first_line; $ln--) {
1416                                 #print "CHECK<$lines[$ln - 1]\n";
1417                                 # we have a preceeding printk if it ends
1418                                 # with "\n" ignore it, else it is to blame
1419                                 if ($lines[$ln - 1] =~ m{\bprintk\(}) {
1420                                         if ($rawlines[$ln - 1] !~ m{\\n"}) {
1421                                                 $ok = 1;
1422                                         }
1423                                         last;
1424                                 }
1425                         }
1426                         if ($ok == 0) {
1427                                 WARN("printk() should include KERN_ facility level\n" . $herecurr);
1428                         }
1429                 }
1430
1431 # function brace can't be on same line, except for #defines of do while,
1432 # or if closed on same line
1433                 if (($line=~/$Type\s*$Ident\(.*\).*\s{/) and
1434                     !($line=~/\#\s*define.*do\s{/) and !($line=~/}/)) {
1435                         ERROR("open brace '{' following function declarations go on the next line\n" . $herecurr);
1436                 }
1437
1438 # open braces for enum, union and struct go on the same line.
1439                 if ($line =~ /^.\s*{/ &&
1440                     $prevline =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident)?\s*$/) {
1441                         ERROR("open brace '{' following $1 go on the same line\n" . $hereprev);
1442                 }
1443
1444 # check for spacing round square brackets; allowed:
1445 #  1. with a type on the left -- int [] a;
1446 #  2. at the beginning of a line for slice initialisers -- [0..10] = 5,
1447                 while ($line =~ /(.*?\s)\[/g) {
1448                         my ($where, $prefix) = ($-[1], $1);
1449                         if ($prefix !~ /$Type\s+$/ &&
1450                             ($where != 0 || $prefix !~ /^.\s+$/)) {
1451                                 ERROR("space prohibited before open square bracket '['\n" . $herecurr);
1452                         }
1453                 }
1454
1455 # check for spaces between functions and their parentheses.
1456                 while ($line =~ /($Ident)\s+\(/g) {
1457                         my $name = $1;
1458                         my $ctx_before = substr($line, 0, $-[1]);
1459                         my $ctx = "$ctx_before$name";
1460
1461                         # Ignore those directives where spaces _are_ permitted.
1462                         if ($name =~ /^(?:
1463                                 if|for|while|switch|return|case|
1464                                 volatile|__volatile__|
1465                                 __attribute__|format|__extension__|
1466                                 asm|__asm__)$/x)
1467                         {
1468
1469                         # cpp #define statements have non-optional spaces, ie
1470                         # if there is a space between the name and the open
1471                         # parenthesis it is simply not a parameter group.
1472                         } elsif ($ctx_before =~ /^.\s*\#\s*define\s*$/) {
1473
1474                         # cpp #elif statement condition may start with a (
1475                         } elsif ($ctx =~ /^.\s*\#\s*elif\s*$/) {
1476
1477                         # If this whole things ends with a type its most
1478                         # likely a typedef for a function.
1479                         } elsif ($ctx =~ /$Type$/) {
1480
1481                         } else {
1482                                 WARN("space prohibited between function name and open parenthesis '('\n" . $herecurr);
1483                         }
1484                 }
1485 # Check operator spacing.
1486                 if (!($line=~/\#\s*include/)) {
1487                         my $ops = qr{
1488                                 <<=|>>=|<=|>=|==|!=|
1489                                 \+=|-=|\*=|\/=|%=|\^=|\|=|&=|
1490                                 =>|->|<<|>>|<|>|=|!|~|
1491                                 &&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|%
1492                         }x;
1493                         my @elements = split(/($ops|;)/, $opline);
1494                         my $off = 0;
1495
1496                         my $blank = copy_spacing($opline);
1497
1498                         for (my $n = 0; $n < $#elements; $n += 2) {
1499                                 $off += length($elements[$n]);
1500
1501                                 # Pick up the preceeding and succeeding characters.
1502                                 my $ca = substr($opline, 0, $off);
1503                                 my $cc = '';
1504                                 if (length($opline) >= ($off + length($elements[$n + 1]))) {
1505                                         $cc = substr($opline, $off + length($elements[$n + 1]));
1506                                 }
1507                                 my $cb = "$ca$;$cc";
1508
1509                                 my $a = '';
1510                                 $a = 'V' if ($elements[$n] ne '');
1511                                 $a = 'W' if ($elements[$n] =~ /\s$/);
1512                                 $a = 'C' if ($elements[$n] =~ /$;$/);
1513                                 $a = 'B' if ($elements[$n] =~ /(\[|\()$/);
1514                                 $a = 'O' if ($elements[$n] eq '');
1515                                 $a = 'E' if ($ca =~ /^\s*$/);
1516
1517                                 my $op = $elements[$n + 1];
1518
1519                                 my $c = '';
1520                                 if (defined $elements[$n + 2]) {
1521                                         $c = 'V' if ($elements[$n + 2] ne '');
1522                                         $c = 'W' if ($elements[$n + 2] =~ /^\s/);
1523                                         $c = 'C' if ($elements[$n + 2] =~ /^$;/);
1524                                         $c = 'B' if ($elements[$n + 2] =~ /^(\)|\]|;)/);
1525                                         $c = 'O' if ($elements[$n + 2] eq '');
1526                                         $c = 'E' if ($elements[$n + 2] =~ /\s*\\$/);
1527                                 } else {
1528                                         $c = 'E';
1529                                 }
1530
1531                                 my $ctx = "${a}x${c}";
1532
1533                                 my $at = "(ctx:$ctx)";
1534
1535                                 my $ptr = substr($blank, 0, $off) . "^";
1536                                 my $hereptr = "$hereline$ptr\n";
1537
1538                                 # Classify operators into binary, unary, or
1539                                 # definitions (* only) where they have more
1540                                 # than one mode.
1541                                 my $op_type = substr($curr_values, $off + 1, 1);
1542                                 my $op_left = substr($curr_values, $off, 1);
1543                                 my $is_unary;
1544                                 if ($op_type eq 'T') {
1545                                         $is_unary = 2;
1546                                 } elsif ($op_left eq 'V') {
1547                                         $is_unary = 0;
1548                                 } else {
1549                                         $is_unary = 1;
1550                                 }
1551                                 #if ($op eq '-' || $op eq '&' || $op eq '*') {
1552                                 #       print "UNARY: <$op_left$op_type $is_unary $a:$op:$c> <$ca:$op:$cc> <$unary_ctx>\n";
1553                                 #}
1554
1555                                 # Ignore operators passed as parameters.
1556                                 if ($op_type ne 'V' &&
1557                                     $ca =~ /\s$/ && $cc =~ /^\s*,/) {
1558
1559 #                               # Ignore comments
1560 #                               } elsif ($op =~ /^$;+$/) {
1561
1562                                 # ; should have either the end of line or a space or \ after it
1563                                 } elsif ($op eq ';') {
1564                                         if ($ctx !~ /.x[WEBC]/ &&
1565                                             $cc !~ /^\\/ && $cc !~ /^;/) {
1566                                                 ERROR("space required after that '$op' $at\n" . $hereptr);
1567                                         }
1568
1569                                 # // is a comment
1570                                 } elsif ($op eq '//') {
1571
1572                                 # -> should have no spaces
1573                                 } elsif ($op eq '->') {
1574                                         if ($ctx =~ /Wx.|.xW/) {
1575                                                 ERROR("spaces prohibited around that '$op' $at\n" . $hereptr);
1576                                         }
1577
1578                                 # , must have a space on the right.
1579                                 } elsif ($op eq ',') {
1580                                         if ($ctx !~ /.x[WEC]/ && $cc !~ /^}/) {
1581                                                 ERROR("space required after that '$op' $at\n" . $hereptr);
1582                                         }
1583
1584                                 # '*' as part of a type definition -- reported already.
1585                                 } elsif ($op eq '*' && $is_unary == 2) {
1586                                         #warn "'*' is part of type\n";
1587
1588                                 # unary operators should have a space before and
1589                                 # none after.  May be left adjacent to another
1590                                 # unary operator, or a cast
1591                                 } elsif ($op eq '!' || $op eq '~' ||
1592                                          ($is_unary && ($op eq '*' || $op eq '-' || $op eq '&'))) {
1593                                         if ($ctx !~ /[WEBC]x./ && $ca !~ /(?:\)|!|~|\*|-|\&|\||\+\+|\-\-|\{)$/) {
1594                                                 ERROR("space required before that '$op' $at\n" . $hereptr);
1595                                         }
1596                                         if ($op  eq '*' && $cc =~/\s*const\b/) {
1597                                                 # A unary '*' may be const
1598
1599                                         } elsif ($ctx =~ /.xW/) {
1600                                                 ERROR("space prohibited after that '$op' $at\n" . $hereptr);
1601                                         }
1602
1603                                 # unary ++ and unary -- are allowed no space on one side.
1604                                 } elsif ($op eq '++' or $op eq '--') {
1605                                         if ($ctx !~ /[WEOBC]x[^W]/ && $ctx !~ /[^W]x[WOBEC]/) {
1606                                                 ERROR("space required one side of that '$op' $at\n" . $hereptr);
1607                                         }
1608                                         if ($ctx =~ /Wx[BE]/ ||
1609                                             ($ctx =~ /Wx./ && $cc =~ /^;/)) {
1610                                                 ERROR("space prohibited before that '$op' $at\n" . $hereptr);
1611                                         }
1612                                         if ($ctx =~ /ExW/) {
1613                                                 ERROR("space prohibited after that '$op' $at\n" . $hereptr);
1614                                         }
1615
1616
1617                                 # << and >> may either have or not have spaces both sides
1618                                 } elsif ($op eq '<<' or $op eq '>>' or
1619                                          $op eq '&' or $op eq '^' or $op eq '|' or
1620                                          $op eq '+' or $op eq '-' or
1621                                          $op eq '*' or $op eq '/' or
1622                                          $op eq '%')
1623                                 {
1624                                         if ($ctx =~ /Wx[^WCE]|[^WCE]xW/) {
1625                                                 ERROR("need consistent spacing around '$op' $at\n" .
1626                                                         $hereptr);
1627                                         }
1628
1629                                 # All the others need spaces both sides.
1630                                 } elsif ($ctx !~ /[EWC]x[CWE]/) {
1631                                         # Ignore email addresses <foo@bar>
1632                                         if (!($op eq '<' && $cb =~ /$;\S+\@\S+>/) &&
1633                                             !($op eq '>' && $cb =~ /<\S+\@\S+$;/)) {
1634                                                 ERROR("spaces required around that '$op' $at\n" . $hereptr);
1635                                         }
1636                                 }
1637                                 $off += length($elements[$n + 1]);
1638                         }
1639                 }
1640
1641 # check for multiple assignments
1642                 if ($line =~ /^.\s*$Lval\s*=\s*$Lval\s*=(?!=)/) {
1643                         CHK("multiple assignments should be avoided\n" . $herecurr);
1644                 }
1645
1646 ## # check for multiple declarations, allowing for a function declaration
1647 ## # continuation.
1648 ##              if ($line =~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Ident.*/ &&
1649 ##                  $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) {
1650 ##
1651 ##                      # Remove any bracketed sections to ensure we do not
1652 ##                      # falsly report the parameters of functions.
1653 ##                      my $ln = $line;
1654 ##                      while ($ln =~ s/\([^\(\)]*\)//g) {
1655 ##                      }
1656 ##                      if ($ln =~ /,/) {
1657 ##                              WARN("declaring multiple variables together should be avoided\n" . $herecurr);
1658 ##                      }
1659 ##              }
1660
1661 #need space before brace following if, while, etc
1662                 if (($line =~ /\(.*\){/ && $line !~ /\($Type\){/) ||
1663                     $line =~ /do{/) {
1664                         ERROR("space required before the open brace '{'\n" . $herecurr);
1665                 }
1666
1667 # closing brace should have a space following it when it has anything
1668 # on the line
1669                 if ($line =~ /}(?!(?:,|;|\)))\S/) {
1670                         ERROR("space required after that close brace '}'\n" . $herecurr);
1671                 }
1672
1673 # check spacing on square brackets
1674                 if ($line =~ /\[\s/ && $line !~ /\[\s*$/) {
1675                         ERROR("space prohibited after that open square bracket '['\n" . $herecurr);
1676                 }
1677                 if ($line =~ /\s\]/) {
1678                         ERROR("space prohibited before that close square bracket ']'\n" . $herecurr);
1679                 }
1680
1681 # check spacing on parentheses
1682                 if ($line =~ /\(\s/ && $line !~ /\(\s*(?:\\)?$/ &&
1683                     $line !~ /for\s*\(\s+;/) {
1684                         ERROR("space prohibited after that open parenthesis '('\n" . $herecurr);
1685                 }
1686                 if ($line =~ /(\s+)\)/ && $line !~ /^.\s*\)/ &&
1687                     $line !~ /for\s*\(.*;\s+\)/ &&
1688                     $line !~ /:\s+\)/) {
1689                         ERROR("space prohibited before that close parenthesis ')'\n" . $herecurr);
1690                 }
1691
1692 #goto labels aren't indented, allow a single space however
1693                 if ($line=~/^.\s+[A-Za-z\d_]+:(?![0-9]+)/ and
1694                    !($line=~/^. [A-Za-z\d_]+:/) and !($line=~/^.\s+default:/)) {
1695                         WARN("labels should not be indented\n" . $herecurr);
1696                 }
1697
1698 # Return is not a function.
1699                 if (defined($stat) && $stat =~ /^.\s*return(\s*)(\(.*);/s) {
1700                         my $spacing = $1;
1701                         my $value = $2;
1702
1703                         # Flatten any parentheses and braces
1704                         $value =~ s/\)\(/\) \(/g;
1705                         while ($value =~ s/\([^\(\)]*\)/1/) {
1706                         }
1707
1708                         if ($value =~ /^(?:$Ident|-?$Constant)$/) {
1709                                 ERROR("return is not a function, parentheses are not required\n" . $herecurr);
1710
1711                         } elsif ($spacing !~ /\s+/) {
1712                                 ERROR("space required before the open parenthesis '('\n" . $herecurr);
1713                         }
1714                 }
1715
1716 # Need a space before open parenthesis after if, while etc
1717                 if ($line=~/\b(if|while|for|switch)\(/) {
1718                         ERROR("space required before the open parenthesis '('\n" . $herecurr);
1719                 }
1720
1721 # Check for illegal assignment in if conditional -- and check for trailing
1722 # statements after the conditional.
1723                 if ($line =~ /\b(?:if|while|for)\s*\(/ && $line !~ /^.\s*#/) {
1724                         my ($s, $c) = ($stat, $cond);
1725
1726                         if ($c =~ /\bif\s*\(.*[^<>!=]=[^=].*/) {
1727                                 ERROR("do not use assignment in if condition\n" . $herecurr);
1728                         }
1729
1730                         # Find out what is on the end of the line after the
1731                         # conditional.
1732                         substr($s, 0, length($c), '');
1733                         $s =~ s/\n.*//g;
1734                         $s =~ s/$;//g;  # Remove any comments
1735                         if (length($c) && $s !~ /^\s*{?\s*\\*\s*$/ &&
1736                             $c !~ /}\s*while\s*/)
1737                         {
1738                                 ERROR("trailing statements should be on next line\n" . $herecurr);
1739                         }
1740                 }
1741
1742 # Check relative indent for conditionals and blocks.
1743                 if ($line =~ /\b(?:(?:if|while|for)\s*\(|do\b)/ && $line !~ /^.\s*#/ && $line !~ /\}\s*while\s*/) {
1744                         my ($s, $c) = ($stat, $cond);
1745
1746                         substr($s, 0, length($c), '');
1747
1748                         # Make sure we remove the line prefixes as we have
1749                         # none on the first line, and are going to readd them
1750                         # where necessary.
1751                         $s =~ s/\n./\n/gs;
1752
1753                         # We want to check the first line inside the block
1754                         # starting at the end of the conditional, so remove:
1755                         #  1) any blank line termination
1756                         #  2) any opening brace { on end of the line
1757                         #  3) any do (...) {
1758                         my $continuation = 0;
1759                         my $check = 0;
1760                         $s =~ s/^.*\bdo\b//;
1761                         $s =~ s/^\s*{//;
1762                         if ($s =~ s/^\s*\\//) {
1763                                 $continuation = 1;
1764                         }
1765                         if ($s =~ s/^\s*\n//) {
1766                                 $check = 1;
1767                         }
1768
1769                         # Also ignore a loop construct at the end of a
1770                         # preprocessor statement.
1771                         if (($prevline =~ /^.\s*#\s*define\s/ ||
1772                             $prevline =~ /\\\s*$/) && $continuation == 0) {
1773                                 $check = 0;
1774                         }
1775
1776                         # Ignore the current line if its is a preprocessor
1777                         # line.
1778                         if ($s =~ /^\s*#\s*/) {
1779                                 $check = 0;
1780                         }
1781
1782                         my (undef, $sindent) = line_stats("+" . $s);
1783
1784                         ##print "line<$line> prevline<$prevline> indent<$indent> sindent<$sindent> check<$check> continuation<$continuation> s<$s>\n";
1785
1786                         if ($check && (($sindent % 8) != 0 ||
1787                             ($sindent <= $indent && $s ne ''))) {
1788                                 WARN("suspect code indent for conditional statements\n" . $herecurr);
1789                         }
1790                 }
1791
1792 # Check for bitwise tests written as boolean
1793                 if ($line =~ /
1794                         (?:
1795                                 (?:\[|\(|\&\&|\|\|)
1796                                 \s*0[xX][0-9]+\s*
1797                                 (?:\&\&|\|\|)
1798                         |
1799                                 (?:\&\&|\|\|)
1800                                 \s*0[xX][0-9]+\s*
1801                                 (?:\&\&|\|\||\)|\])
1802                         )/x)
1803                 {
1804                         WARN("boolean test with hexadecimal, perhaps just 1 \& or \|?\n" . $herecurr);
1805                 }
1806
1807 # if and else should not have general statements after it
1808                 if ($line =~ /^.\s*(?:}\s*)?else\b(.*)/) {
1809                         my $s = $1;
1810                         $s =~ s/$;//g;  # Remove any comments
1811                         if ($s !~ /^\s*(?:\sif|(?:{|)\s*\\?\s*$)/) {
1812                                 ERROR("trailing statements should be on next line\n" . $herecurr);
1813                         }
1814                 }
1815
1816                 # Check for }<nl>else {, these must be at the same
1817                 # indent level to be relevant to each other.
1818                 if ($prevline=~/}\s*$/ and $line=~/^.\s*else\s*/ and
1819                                                 $previndent == $indent) {
1820                         ERROR("else should follow close brace '}'\n" . $hereprev);
1821                 }
1822
1823                 if ($prevline=~/}\s*$/ and $line=~/^.\s*while\s*/ and
1824                                                 $previndent == $indent) {
1825                         my ($s, $c) = ctx_statement_block($linenr, $realcnt, 0);
1826
1827                         # Find out what is on the end of the line after the
1828                         # conditional.
1829                         substr($s, 0, length($c), '');
1830                         $s =~ s/\n.*//g;
1831
1832                         if ($s =~ /^\s*;/) {
1833                                 ERROR("while should follow close brace '}'\n" . $hereprev);
1834                         }
1835                 }
1836
1837 #studly caps, commented out until figure out how to distinguish between use of existing and adding new
1838 #               if (($line=~/[\w_][a-z\d]+[A-Z]/) and !($line=~/print/)) {
1839 #                   print "No studly caps, use _\n";
1840 #                   print "$herecurr";
1841 #                   $clean = 0;
1842 #               }
1843
1844 #no spaces allowed after \ in define
1845                 if ($line=~/\#\s*define.*\\\s$/) {
1846                         WARN("Whitepspace after \\ makes next lines useless\n" . $herecurr);
1847                 }
1848
1849 #warn if <asm/foo.h> is #included and <linux/foo.h> is available (uses RAW line)
1850                 if ($tree && $rawline =~ m{^.\s*\#\s*include\s*\<asm\/(.*)\.h\>}) {
1851                         my $checkfile = "include/linux/$1.h";
1852                         if (-f "$root/$checkfile" && $realfile ne $checkfile &&
1853                             $1 ne 'irq')
1854                         {
1855                                 WARN("Use #include <linux/$1.h> instead of <asm/$1.h>\n" .
1856                                         $herecurr);
1857                         }
1858                 }
1859
1860 # multi-statement macros should be enclosed in a do while loop, grab the
1861 # first statement and ensure its the whole macro if its not enclosed
1862 # in a known good container
1863                 if ($realfile !~ m@/vmlinux.lds.h$@ &&
1864                     $line =~ /^.\s*\#\s*define\s*$Ident(\()?/) {
1865                         my $ln = $linenr;
1866                         my $cnt = $realcnt;
1867                         my ($off, $dstat, $dcond, $rest);
1868                         my $ctx = '';
1869
1870                         my $args = defined($1);
1871
1872                         # Find the end of the macro and limit our statement
1873                         # search to that.
1874                         while ($cnt > 0 && defined $lines[$ln - 1] &&
1875                                 $lines[$ln - 1] =~ /^(?:-|..*\\$)/)
1876                         {
1877                                 $ctx .= $rawlines[$ln - 1] . "\n";
1878                                 $cnt-- if ($lines[$ln - 1] !~ /^-/);
1879                                 $ln++;
1880                         }
1881                         $ctx .= $rawlines[$ln - 1];
1882
1883                         ($dstat, $dcond, $ln, $cnt, $off) =
1884                                 ctx_statement_block($linenr, $ln - $linenr + 1, 0);
1885                         #print "dstat<$dstat> dcond<$dcond> cnt<$cnt> off<$off>\n";
1886                         #print "LINE<$lines[$ln-1]> len<" . length($lines[$ln-1]) . "\n";
1887
1888                         # Extract the remainder of the define (if any) and
1889                         # rip off surrounding spaces, and trailing \'s.
1890                         $rest = '';
1891                         while ($off != 0 || ($cnt > 0 && $rest =~ /(?:^|\\)\s*$/)) {
1892                                 #print "ADDING $off <" . substr($lines[$ln - 1], $off) . ">\n";
1893                                 if ($off != 0 || $lines[$ln - 1] !~ /^-/) {
1894                                         $rest .= substr($lines[$ln - 1], $off) . "\n";
1895                                         $cnt--;
1896                                 }
1897                                 $ln++;
1898                                 $off = 0;
1899                         }
1900                         $rest =~ s/\\\n.//g;
1901                         $rest =~ s/^\s*//s;
1902                         $rest =~ s/\s*$//s;
1903
1904                         # Clean up the original statement.
1905                         if ($args) {
1906                                 substr($dstat, 0, length($dcond), '');
1907                         } else {
1908                                 $dstat =~ s/^.\s*\#\s*define\s+$Ident\s*//;
1909                         }
1910                         $dstat =~ s/\\\n.//g;
1911                         $dstat =~ s/^\s*//s;
1912                         $dstat =~ s/\s*$//s;
1913
1914                         # Flatten any parentheses and braces
1915                         while ($dstat =~ s/\([^\(\)]*\)/1/) {
1916                         }
1917                         while ($dstat =~ s/\{[^\{\}]*\}/1/) {
1918                         }
1919
1920                         my $exceptions = qr{
1921                                 $Declare|
1922                                 module_param_named|
1923                                 MODULE_PARAM_DESC|
1924                                 DECLARE_PER_CPU|
1925                                 DEFINE_PER_CPU|
1926                                 __typeof__\(
1927                         }x;
1928                         #print "REST<$rest>\n";
1929                         if ($rest ne '') {
1930                                 if ($rest !~ /while\s*\(/ &&
1931                                     $dstat !~ /$exceptions/)
1932                                 {
1933                                         ERROR("Macros with multiple statements should be enclosed in a do - while loop\n" . "$here\n$ctx\n");
1934                                 }
1935
1936                         } elsif ($ctx !~ /;/) {
1937                                 if ($dstat ne '' &&
1938                                     $dstat !~ /^(?:$Ident|-?$Constant)$/ &&
1939                                     $dstat !~ /$exceptions/ &&
1940                                     $dstat =~ /$Operators/)
1941                                 {
1942                                         ERROR("Macros with complex values should be enclosed in parenthesis\n" . "$here\n$ctx\n");
1943                                 }
1944                         }
1945                 }
1946
1947 # check for redundant bracing round if etc
1948                 if ($line =~ /(^.*)\bif\b/ && $1 !~ /else\s*$/) {
1949                         my ($level, $endln, @chunks) =
1950                                 ctx_statement_full($linenr, $realcnt, 1);
1951                         #print "chunks<$#chunks> linenr<$linenr> endln<$endln> level<$level>\n";
1952                         #print "APW: <<$chunks[1][0]>><<$chunks[1][1]>>\n";
1953                         if ($#chunks > 0 && $level == 0) {
1954                                 my $allowed = 0;
1955                                 my $seen = 0;
1956                                 my $herectx = $here . "\n";
1957                                 my $ln = $linenr - 1;
1958                                 for my $chunk (@chunks) {
1959                                         my ($cond, $block) = @{$chunk};
1960
1961                                         # If the condition carries leading newlines, then count those as offsets.
1962                                         my ($whitespace) = ($cond =~ /^((?:\s*\n[+-])*\s*)/s);
1963                                         my $offset = statement_rawlines($whitespace) - 1;
1964
1965                                         #print "COND<$cond> whitespace<$whitespace> offset<$offset>\n";
1966
1967                                         # We have looked at and allowed this specific line.
1968                                         $suppress_ifbraces{$ln + $offset} = 1;
1969
1970                                         $herectx .= "$rawlines[$ln + $offset]\n[...]\n";
1971                                         $ln += statement_rawlines($block) - 1;
1972
1973                                         substr($block, 0, length($cond), '');
1974
1975                                         $seen++ if ($block =~ /^\s*{/);
1976
1977                                         #print "cond<$cond> block<$block> allowed<$allowed>\n";
1978                                         if (statement_lines($cond) > 1) {
1979                                                 #print "APW: ALLOWED: cond<$cond>\n";
1980                                                 $allowed = 1;
1981                                         }
1982                                         if ($block =~/\b(?:if|for|while)\b/) {
1983                                                 #print "APW: ALLOWED: block<$block>\n";
1984                                                 $allowed = 1;
1985                                         }
1986                                         if (statement_block_size($block) > 1) {
1987                                                 #print "APW: ALLOWED: lines block<$block>\n";
1988                                                 $allowed = 1;
1989                                         }
1990                                 }
1991                                 if ($seen && !$allowed) {
1992                                         WARN("braces {} are not necessary for any arm of this statement\n" . $herectx);
1993                                 }
1994                         }
1995                 }
1996                 if (!defined $suppress_ifbraces{$linenr - 1} &&
1997                                         $line =~ /\b(if|while|for|else)\b/) {
1998                         my $allowed = 0;
1999
2000                         # Check the pre-context.
2001                         if (substr($line, 0, $-[0]) =~ /(\}\s*)$/) {
2002                                 #print "APW: ALLOWED: pre<$1>\n";
2003                                 $allowed = 1;
2004                         }
2005
2006                         my ($level, $endln, @chunks) =
2007                                 ctx_statement_full($linenr, $realcnt, $-[0]);
2008
2009                         # Check the condition.
2010                         my ($cond, $block) = @{$chunks[0]};
2011                         #print "CHECKING<$linenr> cond<$cond> block<$block>\n";
2012                         if (defined $cond) {
2013                                 substr($block, 0, length($cond), '');
2014                         }
2015                         if (statement_lines($cond) > 1) {
2016                                 #print "APW: ALLOWED: cond<$cond>\n";
2017                                 $allowed = 1;
2018                         }
2019                         if ($block =~/\b(?:if|for|while)\b/) {
2020                                 #print "APW: ALLOWED: block<$block>\n";
2021                                 $allowed = 1;
2022                         }
2023                         if (statement_block_size($block) > 1) {
2024                                 #print "APW: ALLOWED: lines block<$block>\n";
2025                                 $allowed = 1;
2026                         }
2027                         # Check the post-context.
2028                         if (defined $chunks[1]) {
2029                                 my ($cond, $block) = @{$chunks[1]};
2030                                 if (defined $cond) {
2031                                         substr($block, 0, length($cond), '');
2032                                 }
2033                                 if ($block =~ /^\s*\{/) {
2034                                         #print "APW: ALLOWED: chunk-1 block<$block>\n";
2035                                         $allowed = 1;
2036                                 }
2037                         }
2038                         if ($level == 0 && $block =~ /^\s*\{/ && !$allowed) {
2039                                 my $herectx = $here . "\n";;
2040                                 my $end = $linenr + statement_rawlines($block) - 1;
2041
2042                                 for (my $ln = $linenr - 1; $ln < $end; $ln++) {
2043                                         $herectx .= $rawlines[$ln] . "\n";;
2044                                 }
2045
2046                                 WARN("braces {} are not necessary for single statement blocks\n" . $herectx);
2047                         }
2048                 }
2049
2050 # don't include deprecated include files (uses RAW line)
2051                 for my $inc (@dep_includes) {
2052                         if ($rawline =~ m@^.\s*\#\s*include\s*\<$inc>@) {
2053                                 ERROR("Don't use <$inc>: see Documentation/feature-removal-schedule.txt\n" . $herecurr);
2054                         }
2055                 }
2056
2057 # don't use deprecated functions
2058                 for my $func (@dep_functions) {
2059                         if ($line =~ /\b$func\b/) {
2060                                 ERROR("Don't use $func(): see Documentation/feature-removal-schedule.txt\n" . $herecurr);
2061                         }
2062                 }
2063
2064 # no volatiles please
2065                 my $asm_volatile = qr{\b(__asm__|asm)\s+(__volatile__|volatile)\b};
2066                 if ($line =~ /\bvolatile\b/ && $line !~ /$asm_volatile/) {
2067                         WARN("Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt\n" . $herecurr);
2068                 }
2069
2070 # SPIN_LOCK_UNLOCKED & RW_LOCK_UNLOCKED are deprecated
2071                 if ($line =~ /\b(SPIN_LOCK_UNLOCKED|RW_LOCK_UNLOCKED)/) {
2072                         ERROR("Use of $1 is deprecated: see Documentation/spinlocks.txt\n" . $herecurr);
2073                 }
2074
2075 # warn about #if 0
2076                 if ($line =~ /^.\s*\#\s*if\s+0\b/) {
2077                         CHK("if this code is redundant consider removing it\n" .
2078                                 $herecurr);
2079                 }
2080
2081 # check for needless kfree() checks
2082                 if ($prevline =~ /\bif\s*\(([^\)]*)\)/) {
2083                         my $expr = $1;
2084                         if ($line =~ /\bkfree\(\Q$expr\E\);/) {
2085                                 WARN("kfree(NULL) is safe this check is probably not required\n" . $hereprev);
2086                         }
2087                 }
2088 # check for needless usb_free_urb() checks
2089                 if ($prevline =~ /\bif\s*\(([^\)]*)\)/) {
2090                         my $expr = $1;
2091                         if ($line =~ /\busb_free_urb\(\Q$expr\E\);/) {
2092                                 WARN("usb_free_urb(NULL) is safe this check is probably not required\n" . $hereprev);
2093                         }
2094                 }
2095
2096 # warn about #ifdefs in C files
2097 #               if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) {
2098 #                       print "#ifdef in C files should be avoided\n";
2099 #                       print "$herecurr";
2100 #                       $clean = 0;
2101 #               }
2102
2103 # warn about spacing in #ifdefs
2104                 if ($line =~ /^.\s*\#\s*(ifdef|ifndef|elif)\s\s+/) {
2105                         ERROR("exactly one space required after that #$1\n" . $herecurr);
2106                 }
2107
2108 # check for spinlock_t definitions without a comment.
2109                 if ($line =~ /^.\s*(struct\s+mutex|spinlock_t)\s+\S+;/ ||
2110                     $line =~ /^.\s*(DEFINE_MUTEX)\s*\(/) {
2111                         my $which = $1;
2112                         if (!ctx_has_comment($first_line, $linenr)) {
2113                                 CHK("$1 definition without comment\n" . $herecurr);
2114                         }
2115                 }
2116 # check for memory barriers without a comment.
2117                 if ($line =~ /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/) {
2118                         if (!ctx_has_comment($first_line, $linenr)) {
2119                                 CHK("memory barrier without comment\n" . $herecurr);
2120                         }
2121                 }
2122 # check of hardware specific defines
2123                 if ($line =~ m@^.\s*\#\s*if.*\b(__i386__|__powerpc64__|__sun__|__s390x__)\b@ && $realfile !~ m@include/asm-@) {
2124                         CHK("architecture specific defines should be avoided\n" .  $herecurr);
2125                 }
2126
2127 # check the location of the inline attribute, that it is between
2128 # storage class and type.
2129                 if ($line =~ /\b$Type\s+$Inline\b/ ||
2130                     $line =~ /\b$Inline\s+$Storage\b/) {
2131                         ERROR("inline keyword should sit between storage class and type\n" . $herecurr);
2132                 }
2133
2134 # Check for __inline__ and __inline, prefer inline
2135                 if ($line =~ /\b(__inline__|__inline)\b/) {
2136                         WARN("plain inline is preferred over $1\n" . $herecurr);
2137                 }
2138
2139 # check for new externs in .c files.
2140                 if ($realfile =~ /\.c$/ && defined $stat &&
2141                     $stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s)
2142                 {
2143                         my $function_name = $1;
2144                         my $paren_space = $2;
2145
2146                         my $s = $stat;
2147                         if (defined $cond) {
2148                                 substr($s, 0, length($cond), '');
2149                         }
2150                         if ($s =~ /^\s*;/ &&
2151                             $function_name ne 'uninitialized_var')
2152                         {
2153                                 WARN("externs should be avoided in .c files\n" .  $herecurr);
2154                         }
2155
2156                         if ($paren_space =~ /\n/) {
2157                                 WARN("arguments for function declarations should follow identifier\n" . $herecurr);
2158                         }
2159
2160                 } elsif ($realfile =~ /\.c$/ && defined $stat &&
2161                     $stat =~ /^.\s*extern\s+/)
2162                 {
2163                         WARN("externs should be avoided in .c files\n" .  $herecurr);
2164                 }
2165
2166 # checks for new __setup's
2167                 if ($rawline =~ /\b__setup\("([^"]*)"/) {
2168                         my $name = $1;
2169
2170                         if (!grep(/$name/, @setup_docs)) {
2171                                 CHK("__setup appears un-documented -- check Documentation/kernel-parameters.txt\n" . $herecurr);
2172                         }
2173                 }
2174
2175 # check for pointless casting of kmalloc return
2176                 if ($line =~ /\*\s*\)\s*k[czm]alloc\b/) {
2177                         WARN("unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html\n" . $herecurr);
2178                 }
2179
2180 # check for gcc specific __FUNCTION__
2181                 if ($line =~ /__FUNCTION__/) {
2182                         WARN("__func__ should be used instead of gcc specific __FUNCTION__\n"  . $herecurr);
2183                 }
2184
2185 # check for semaphores used as mutexes
2186                 if ($line =~ /^.\s*(DECLARE_MUTEX|init_MUTEX)\s*\(/) {
2187                         WARN("mutexes are preferred for single holder semaphores\n" . $herecurr);
2188                 }
2189 # check for semaphores used as mutexes
2190                 if ($line =~ /^.\s*init_MUTEX_LOCKED\s*\(/) {
2191                         WARN("consider using a completion\n" . $herecurr);
2192                 }
2193 # recommend strict_strto* over simple_strto*
2194                 if ($line =~ /\bsimple_(strto.*?)\s*\(/) {
2195                         WARN("consider using strict_$1 in preference to simple_$1\n" . $herecurr);
2196                 }
2197 # check for __initcall(), use device_initcall() explicitly please
2198                 if ($line =~ /^.\s*__initcall\s*\(/) {
2199                         WARN("please use device_initcall() instead of __initcall()\n" . $herecurr);
2200                 }
2201
2202 # use of NR_CPUS is usually wrong
2203 # ignore definitions of NR_CPUS and usage to define arrays as likely right
2204                 if ($line =~ /\bNR_CPUS\b/ &&
2205                     $line !~ /^.\s*\s*#\s*if\b.*\bNR_CPUS\b/ &&
2206                     $line !~ /^.\s*\s*#\s*define\b.*\bNR_CPUS\b/ &&
2207                     $line !~ /^.\s*$Declare\s.*\[[^\]]*NR_CPUS[^\]]*\]/ &&
2208                     $line !~ /\[[^\]]*\.\.\.[^\]]*NR_CPUS[^\]]*\]/ &&
2209                     $line !~ /\[[^\]]*NR_CPUS[^\]]*\.\.\.[^\]]*\]/)
2210                 {
2211                         WARN("usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc\n" . $herecurr);
2212                 }
2213
2214 # check for %L{u,d,i} in strings
2215                 my $string;
2216                 while ($line =~ /(?:^|")([X\t]*)(?:"|$)/g) {
2217                         $string = substr($rawline, $-[1], $+[1] - $-[1]);
2218                         if ($string =~ /(?<!%)%L[udi]/) {
2219                                 WARN("\%Ld/%Lu are not-standard C, use %lld/%llu\n" . $herecurr);
2220                                 last;
2221                         }
2222                 }
2223         }
2224
2225         # If we have no input at all, then there is nothing to report on
2226         # so just keep quiet.
2227         if ($#rawlines == -1) {
2228                 exit(0);
2229         }
2230
2231         # In mailback mode only produce a report in the negative, for
2232         # things that appear to be patches.
2233         if ($mailback && ($clean == 1 || !$is_patch)) {
2234                 exit(0);
2235         }
2236
2237         # This is not a patch, and we are are in 'no-patch' mode so
2238         # just keep quiet.
2239         if (!$chk_patch && !$is_patch) {
2240                 exit(0);
2241         }
2242
2243         if (!$is_patch) {
2244                 ERROR("Does not appear to be a unified-diff format patch\n");
2245         }
2246         if ($is_patch && $chk_signoff && $signoff == 0) {
2247                 ERROR("Missing Signed-off-by: line(s)\n");
2248         }
2249
2250         print report_dump();
2251         if ($summary && !($clean == 1 && $quiet == 1)) {
2252                 print "$filename " if ($summary_file);
2253                 print "total: $cnt_error errors, $cnt_warn warnings, " .
2254                         (($check)? "$cnt_chk checks, " : "") .
2255                         "$cnt_lines lines checked\n";
2256                 print "\n" if ($quiet == 0);
2257         }
2258
2259         if ($clean == 1 && $quiet == 0) {
2260                 print "$vname has no obvious style problems and is ready for submission.\n"
2261         }
2262         if ($clean == 0 && $quiet == 0) {
2263                 print "$vname has style problems, please review.  If any of these errors\n";
2264                 print "are false positives report them to the maintainer, see\n";
2265                 print "CHECKPATCH in MAINTAINERS.\n";
2266         }
2267
2268         return $clean;
2269 }