drm/i915: dereferencing an error pointer
[GitHub/mt8127/android_kernel_alcatel_ttab.git] / drivers / gpu / drm / i915 / intel_lvds.c
CommitLineData
79e53945
JB
1/*
2 * Copyright © 2006-2007 Intel Corporation
3 * Copyright (c) 2006 Dave Airlie <airlied@linux.ie>
4 *
5 * Permission is hereby granted, free of charge, to any person obtaining a
6 * copy of this software and associated documentation files (the "Software"),
7 * to deal in the Software without restriction, including without limitation
8 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
9 * and/or sell copies of the Software, and to permit persons to whom the
10 * Software is furnished to do so, subject to the following conditions:
11 *
12 * The above copyright notice and this permission notice (including the next
13 * paragraph) shall be included in all copies or substantial portions of the
14 * Software.
15 *
16 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
17 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
18 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
19 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
20 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
21 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
22 * DEALINGS IN THE SOFTWARE.
23 *
24 * Authors:
25 * Eric Anholt <eric@anholt.net>
26 * Dave Airlie <airlied@linux.ie>
27 * Jesse Barnes <jesse.barnes@intel.com>
28 */
29
c1c7af60 30#include <acpi/button.h>
565dcd46 31#include <linux/dmi.h>
79e53945 32#include <linux/i2c.h>
5a0e3ad6 33#include <linux/slab.h>
79e53945
JB
34#include "drmP.h"
35#include "drm.h"
36#include "drm_crtc.h"
37#include "drm_edid.h"
38#include "intel_drv.h"
39#include "i915_drm.h"
40#include "i915_drv.h"
e99da35f 41#include <linux/acpi.h>
79e53945 42
3fbe18d6 43/* Private structure for the integrated LVDS support */
ea5b213a
CW
44struct intel_lvds {
45 struct intel_encoder base;
788319d4 46
219adae1 47 struct edid *edid;
788319d4 48
3fbe18d6
ZY
49 int fitting_mode;
50 u32 pfit_control;
51 u32 pfit_pgm_ratios;
e9e331a8 52 bool pfit_dirty;
788319d4
CW
53
54 struct drm_display_mode *fixed_mode;
3fbe18d6
ZY
55};
56
788319d4 57static struct intel_lvds *to_intel_lvds(struct drm_encoder *encoder)
ea5b213a 58{
4ef69c7a 59 return container_of(encoder, struct intel_lvds, base.base);
ea5b213a
CW
60}
61
788319d4
CW
62static struct intel_lvds *intel_attached_lvds(struct drm_connector *connector)
63{
64 return container_of(intel_attached_encoder(connector),
65 struct intel_lvds, base);
66}
67
79e53945
JB
68/**
69 * Sets the power state for the panel.
70 */
2a1292fd 71static void intel_lvds_enable(struct intel_lvds *intel_lvds)
79e53945 72{
e9e331a8 73 struct drm_device *dev = intel_lvds->base.base.dev;
24ded204 74 struct intel_crtc *intel_crtc = to_intel_crtc(intel_lvds->base.base.crtc);
79e53945 75 struct drm_i915_private *dev_priv = dev->dev_private;
de842eff 76 u32 ctl_reg, lvds_reg, stat_reg;
541998a1 77
c619eed4 78 if (HAS_PCH_SPLIT(dev)) {
541998a1 79 ctl_reg = PCH_PP_CONTROL;
469d1296 80 lvds_reg = PCH_LVDS;
de842eff 81 stat_reg = PCH_PP_STATUS;
541998a1
ZW
82 } else {
83 ctl_reg = PP_CONTROL;
469d1296 84 lvds_reg = LVDS;
de842eff 85 stat_reg = PP_STATUS;
541998a1 86 }
79e53945 87
2a1292fd 88 I915_WRITE(lvds_reg, I915_READ(lvds_reg) | LVDS_PORT_EN);
e9e331a8 89
2a1292fd
CW
90 if (intel_lvds->pfit_dirty) {
91 /*
92 * Enable automatic panel scaling so that non-native modes
93 * fill the screen. The panel fitter should only be
94 * adjusted whilst the pipe is disabled, according to
95 * register description and PRM.
96 */
97 DRM_DEBUG_KMS("applying panel-fitter: %x, %x\n",
98 intel_lvds->pfit_control,
99 intel_lvds->pfit_pgm_ratios);
de842eff
KP
100
101 I915_WRITE(PFIT_PGM_RATIOS, intel_lvds->pfit_pgm_ratios);
102 I915_WRITE(PFIT_CONTROL, intel_lvds->pfit_control);
103 intel_lvds->pfit_dirty = false;
2a1292fd
CW
104 }
105
106 I915_WRITE(ctl_reg, I915_READ(ctl_reg) | POWER_TARGET_ON);
107 POSTING_READ(lvds_reg);
de842eff
KP
108 if (wait_for((I915_READ(stat_reg) & PP_ON) != 0, 1000))
109 DRM_ERROR("timed out waiting for panel to power on\n");
2a1292fd 110
24ded204 111 intel_panel_enable_backlight(dev, intel_crtc->pipe);
2a1292fd
CW
112}
113
114static void intel_lvds_disable(struct intel_lvds *intel_lvds)
115{
116 struct drm_device *dev = intel_lvds->base.base.dev;
117 struct drm_i915_private *dev_priv = dev->dev_private;
de842eff 118 u32 ctl_reg, lvds_reg, stat_reg;
2a1292fd
CW
119
120 if (HAS_PCH_SPLIT(dev)) {
121 ctl_reg = PCH_PP_CONTROL;
122 lvds_reg = PCH_LVDS;
de842eff 123 stat_reg = PCH_PP_STATUS;
2a1292fd
CW
124 } else {
125 ctl_reg = PP_CONTROL;
126 lvds_reg = LVDS;
de842eff 127 stat_reg = PP_STATUS;
2a1292fd
CW
128 }
129
47356eb6 130 intel_panel_disable_backlight(dev);
2a1292fd
CW
131
132 I915_WRITE(ctl_reg, I915_READ(ctl_reg) & ~POWER_TARGET_ON);
de842eff
KP
133 if (wait_for((I915_READ(stat_reg) & PP_ON) == 0, 1000))
134 DRM_ERROR("timed out waiting for panel to power off\n");
2a1292fd
CW
135
136 if (intel_lvds->pfit_control) {
2a1292fd
CW
137 I915_WRITE(PFIT_CONTROL, 0);
138 intel_lvds->pfit_dirty = true;
79e53945 139 }
2a1292fd
CW
140
141 I915_WRITE(lvds_reg, I915_READ(lvds_reg) & ~LVDS_PORT_EN);
c9f9ccc1 142 POSTING_READ(lvds_reg);
79e53945
JB
143}
144
145static void intel_lvds_dpms(struct drm_encoder *encoder, int mode)
146{
788319d4 147 struct intel_lvds *intel_lvds = to_intel_lvds(encoder);
79e53945
JB
148
149 if (mode == DRM_MODE_DPMS_ON)
2a1292fd 150 intel_lvds_enable(intel_lvds);
79e53945 151 else
2a1292fd 152 intel_lvds_disable(intel_lvds);
79e53945
JB
153
154 /* XXX: We never power down the LVDS pairs. */
155}
156
79e53945
JB
157static int intel_lvds_mode_valid(struct drm_connector *connector,
158 struct drm_display_mode *mode)
159{
788319d4
CW
160 struct intel_lvds *intel_lvds = intel_attached_lvds(connector);
161 struct drm_display_mode *fixed_mode = intel_lvds->fixed_mode;
79e53945 162
788319d4
CW
163 if (mode->hdisplay > fixed_mode->hdisplay)
164 return MODE_PANEL;
165 if (mode->vdisplay > fixed_mode->vdisplay)
166 return MODE_PANEL;
79e53945
JB
167
168 return MODE_OK;
169}
170
49be663f
CW
171static void
172centre_horizontally(struct drm_display_mode *mode,
173 int width)
174{
175 u32 border, sync_pos, blank_width, sync_width;
176
177 /* keep the hsync and hblank widths constant */
178 sync_width = mode->crtc_hsync_end - mode->crtc_hsync_start;
179 blank_width = mode->crtc_hblank_end - mode->crtc_hblank_start;
180 sync_pos = (blank_width - sync_width + 1) / 2;
181
182 border = (mode->hdisplay - width + 1) / 2;
183 border += border & 1; /* make the border even */
184
185 mode->crtc_hdisplay = width;
186 mode->crtc_hblank_start = width + border;
187 mode->crtc_hblank_end = mode->crtc_hblank_start + blank_width;
188
189 mode->crtc_hsync_start = mode->crtc_hblank_start + sync_pos;
190 mode->crtc_hsync_end = mode->crtc_hsync_start + sync_width;
f9bef081
DV
191
192 mode->private_flags |= INTEL_MODE_CRTC_TIMINGS_SET;
49be663f
CW
193}
194
195static void
196centre_vertically(struct drm_display_mode *mode,
197 int height)
198{
199 u32 border, sync_pos, blank_width, sync_width;
200
201 /* keep the vsync and vblank widths constant */
202 sync_width = mode->crtc_vsync_end - mode->crtc_vsync_start;
203 blank_width = mode->crtc_vblank_end - mode->crtc_vblank_start;
204 sync_pos = (blank_width - sync_width + 1) / 2;
205
206 border = (mode->vdisplay - height + 1) / 2;
207
208 mode->crtc_vdisplay = height;
209 mode->crtc_vblank_start = height + border;
210 mode->crtc_vblank_end = mode->crtc_vblank_start + blank_width;
211
212 mode->crtc_vsync_start = mode->crtc_vblank_start + sync_pos;
213 mode->crtc_vsync_end = mode->crtc_vsync_start + sync_width;
f9bef081
DV
214
215 mode->private_flags |= INTEL_MODE_CRTC_TIMINGS_SET;
49be663f
CW
216}
217
218static inline u32 panel_fitter_scaling(u32 source, u32 target)
219{
220 /*
221 * Floating point operation is not supported. So the FACTOR
222 * is defined, which can avoid the floating point computation
223 * when calculating the panel ratio.
224 */
225#define ACCURACY 12
226#define FACTOR (1 << ACCURACY)
227 u32 ratio = source * FACTOR / target;
228 return (FACTOR * ratio + FACTOR/2) / FACTOR;
229}
230
79e53945 231static bool intel_lvds_mode_fixup(struct drm_encoder *encoder,
e811f5ae 232 const struct drm_display_mode *mode,
79e53945
JB
233 struct drm_display_mode *adjusted_mode)
234{
235 struct drm_device *dev = encoder->dev;
236 struct drm_i915_private *dev_priv = dev->dev_private;
237 struct intel_crtc *intel_crtc = to_intel_crtc(encoder->crtc);
788319d4 238 struct intel_lvds *intel_lvds = to_intel_lvds(encoder);
6c2b7c12 239 struct intel_encoder *tmp_encoder;
49be663f 240 u32 pfit_control = 0, pfit_pgm_ratios = 0, border = 0;
9db4a9c7 241 int pipe;
79e53945
JB
242
243 /* Should never happen!! */
a6c45cf0 244 if (INTEL_INFO(dev)->gen < 4 && intel_crtc->pipe == 0) {
1ae8c0a5 245 DRM_ERROR("Can't support LVDS on pipe A\n");
79e53945
JB
246 return false;
247 }
248
249 /* Should never happen!! */
6c2b7c12
DV
250 for_each_encoder_on_crtc(dev, encoder->crtc, tmp_encoder) {
251 if (&tmp_encoder->base != encoder) {
1ae8c0a5 252 DRM_ERROR("Can't enable LVDS and another "
79e53945
JB
253 "encoder on the same pipe\n");
254 return false;
255 }
256 }
1d8e1c75 257
79e53945 258 /*
71677043 259 * We have timings from the BIOS for the panel, put them in
79e53945
JB
260 * to the adjusted mode. The CRTC will be set up for this mode,
261 * with the panel scaling set up to source from the H/VDisplay
262 * of the original mode.
263 */
788319d4 264 intel_fixed_panel_mode(intel_lvds->fixed_mode, adjusted_mode);
1d8e1c75
CW
265
266 if (HAS_PCH_SPLIT(dev)) {
267 intel_pch_panel_fitting(dev, intel_lvds->fitting_mode,
268 mode, adjusted_mode);
269 return true;
270 }
79e53945 271
3fbe18d6
ZY
272 /* Native modes don't need fitting */
273 if (adjusted_mode->hdisplay == mode->hdisplay &&
49be663f 274 adjusted_mode->vdisplay == mode->vdisplay)
3fbe18d6 275 goto out;
3fbe18d6
ZY
276
277 /* 965+ wants fuzzy fitting */
a6c45cf0 278 if (INTEL_INFO(dev)->gen >= 4)
49be663f
CW
279 pfit_control |= ((intel_crtc->pipe << PFIT_PIPE_SHIFT) |
280 PFIT_FILTER_FUZZY);
281
3fbe18d6
ZY
282 /*
283 * Enable automatic panel scaling for non-native modes so that they fill
284 * the screen. Should be enabled before the pipe is enabled, according
285 * to register description and PRM.
286 * Change the value here to see the borders for debugging
287 */
9db4a9c7
JB
288 for_each_pipe(pipe)
289 I915_WRITE(BCLRPAT(pipe), 0);
3fbe18d6 290
f9bef081
DV
291 drm_mode_set_crtcinfo(adjusted_mode, 0);
292
ea5b213a 293 switch (intel_lvds->fitting_mode) {
53bd8389 294 case DRM_MODE_SCALE_CENTER:
3fbe18d6
ZY
295 /*
296 * For centered modes, we have to calculate border widths &
297 * heights and modify the values programmed into the CRTC.
298 */
49be663f
CW
299 centre_horizontally(adjusted_mode, mode->hdisplay);
300 centre_vertically(adjusted_mode, mode->vdisplay);
301 border = LVDS_BORDER_ENABLE;
3fbe18d6 302 break;
49be663f 303
3fbe18d6 304 case DRM_MODE_SCALE_ASPECT:
49be663f 305 /* Scale but preserve the aspect ratio */
a6c45cf0 306 if (INTEL_INFO(dev)->gen >= 4) {
49be663f
CW
307 u32 scaled_width = adjusted_mode->hdisplay * mode->vdisplay;
308 u32 scaled_height = mode->hdisplay * adjusted_mode->vdisplay;
309
3fbe18d6 310 /* 965+ is easy, it does everything in hw */
49be663f 311 if (scaled_width > scaled_height)
257e48f1 312 pfit_control |= PFIT_ENABLE | PFIT_SCALING_PILLAR;
49be663f 313 else if (scaled_width < scaled_height)
257e48f1
CW
314 pfit_control |= PFIT_ENABLE | PFIT_SCALING_LETTER;
315 else if (adjusted_mode->hdisplay != mode->hdisplay)
316 pfit_control |= PFIT_ENABLE | PFIT_SCALING_AUTO;
3fbe18d6 317 } else {
49be663f
CW
318 u32 scaled_width = adjusted_mode->hdisplay * mode->vdisplay;
319 u32 scaled_height = mode->hdisplay * adjusted_mode->vdisplay;
3fbe18d6
ZY
320 /*
321 * For earlier chips we have to calculate the scaling
322 * ratio by hand and program it into the
323 * PFIT_PGM_RATIO register
324 */
49be663f
CW
325 if (scaled_width > scaled_height) { /* pillar */
326 centre_horizontally(adjusted_mode, scaled_height / mode->vdisplay);
327
328 border = LVDS_BORDER_ENABLE;
329 if (mode->vdisplay != adjusted_mode->vdisplay) {
330 u32 bits = panel_fitter_scaling(mode->vdisplay, adjusted_mode->vdisplay);
331 pfit_pgm_ratios |= (bits << PFIT_HORIZ_SCALE_SHIFT |
332 bits << PFIT_VERT_SCALE_SHIFT);
333 pfit_control |= (PFIT_ENABLE |
334 VERT_INTERP_BILINEAR |
335 HORIZ_INTERP_BILINEAR);
336 }
337 } else if (scaled_width < scaled_height) { /* letter */
338 centre_vertically(adjusted_mode, scaled_width / mode->hdisplay);
339
340 border = LVDS_BORDER_ENABLE;
341 if (mode->hdisplay != adjusted_mode->hdisplay) {
342 u32 bits = panel_fitter_scaling(mode->hdisplay, adjusted_mode->hdisplay);
343 pfit_pgm_ratios |= (bits << PFIT_HORIZ_SCALE_SHIFT |
344 bits << PFIT_VERT_SCALE_SHIFT);
345 pfit_control |= (PFIT_ENABLE |
346 VERT_INTERP_BILINEAR |
347 HORIZ_INTERP_BILINEAR);
348 }
349 } else
350 /* Aspects match, Let hw scale both directions */
351 pfit_control |= (PFIT_ENABLE |
352 VERT_AUTO_SCALE | HORIZ_AUTO_SCALE |
3fbe18d6
ZY
353 VERT_INTERP_BILINEAR |
354 HORIZ_INTERP_BILINEAR);
3fbe18d6
ZY
355 }
356 break;
357
358 case DRM_MODE_SCALE_FULLSCREEN:
359 /*
360 * Full scaling, even if it changes the aspect ratio.
361 * Fortunately this is all done for us in hw.
362 */
257e48f1
CW
363 if (mode->vdisplay != adjusted_mode->vdisplay ||
364 mode->hdisplay != adjusted_mode->hdisplay) {
365 pfit_control |= PFIT_ENABLE;
366 if (INTEL_INFO(dev)->gen >= 4)
367 pfit_control |= PFIT_SCALING_AUTO;
368 else
369 pfit_control |= (VERT_AUTO_SCALE |
370 VERT_INTERP_BILINEAR |
371 HORIZ_AUTO_SCALE |
372 HORIZ_INTERP_BILINEAR);
373 }
3fbe18d6 374 break;
49be663f 375
3fbe18d6
ZY
376 default:
377 break;
378 }
379
380out:
72389a33 381 /* If not enabling scaling, be consistent and always use 0. */
bee17e5a
CW
382 if ((pfit_control & PFIT_ENABLE) == 0) {
383 pfit_control = 0;
384 pfit_pgm_ratios = 0;
385 }
72389a33
CW
386
387 /* Make sure pre-965 set dither correctly */
388 if (INTEL_INFO(dev)->gen < 4 && dev_priv->lvds_dither)
389 pfit_control |= PANEL_8TO6_DITHER_ENABLE;
390
e9e331a8
CW
391 if (pfit_control != intel_lvds->pfit_control ||
392 pfit_pgm_ratios != intel_lvds->pfit_pgm_ratios) {
393 intel_lvds->pfit_control = pfit_control;
394 intel_lvds->pfit_pgm_ratios = pfit_pgm_ratios;
395 intel_lvds->pfit_dirty = true;
396 }
49be663f
CW
397 dev_priv->lvds_border_bits = border;
398
79e53945
JB
399 /*
400 * XXX: It would be nice to support lower refresh rates on the
401 * panels to reduce power consumption, and perhaps match the
402 * user's requested refresh rate.
403 */
404
405 return true;
406}
407
408static void intel_lvds_prepare(struct drm_encoder *encoder)
409{
788319d4 410 struct intel_lvds *intel_lvds = to_intel_lvds(encoder);
79e53945 411
ed10fca9 412 /*
e9e331a8
CW
413 * Prior to Ironlake, we must disable the pipe if we want to adjust
414 * the panel fitter. However at all other times we can just reset
415 * the registers regardless.
416 */
ed10fca9
KP
417 if (!HAS_PCH_SPLIT(encoder->dev) && intel_lvds->pfit_dirty)
418 intel_lvds_disable(intel_lvds);
79e53945
JB
419}
420
e9e331a8 421static void intel_lvds_commit(struct drm_encoder *encoder)
79e53945 422{
788319d4 423 struct intel_lvds *intel_lvds = to_intel_lvds(encoder);
79e53945 424
e9e331a8
CW
425 /* Always do a full power on as we do not know what state
426 * we were left in.
427 */
2a1292fd 428 intel_lvds_enable(intel_lvds);
79e53945
JB
429}
430
431static void intel_lvds_mode_set(struct drm_encoder *encoder,
432 struct drm_display_mode *mode,
433 struct drm_display_mode *adjusted_mode)
434{
79e53945
JB
435 /*
436 * The LVDS pin pair will already have been turned on in the
437 * intel_crtc_mode_set since it has a large impact on the DPLL
438 * settings.
439 */
79e53945
JB
440}
441
442/**
443 * Detect the LVDS connection.
444 *
b42d4c5c
JB
445 * Since LVDS doesn't have hotlug, we use the lid as a proxy. Open means
446 * connected and closed means disconnected. We also send hotplug events as
447 * needed, using lid status notification from the input layer.
79e53945 448 */
7b334fcb 449static enum drm_connector_status
930a9e28 450intel_lvds_detect(struct drm_connector *connector, bool force)
79e53945 451{
7b9c5abe 452 struct drm_device *dev = connector->dev;
6ee3b5a1 453 enum drm_connector_status status;
b42d4c5c 454
fe16d949
CW
455 status = intel_panel_detect(dev);
456 if (status != connector_status_unknown)
457 return status;
01fe9dbd 458
6ee3b5a1 459 return connector_status_connected;
79e53945
JB
460}
461
462/**
463 * Return the list of DDC modes if available, or the BIOS fixed mode otherwise.
464 */
465static int intel_lvds_get_modes(struct drm_connector *connector)
466{
788319d4 467 struct intel_lvds *intel_lvds = intel_attached_lvds(connector);
79e53945 468 struct drm_device *dev = connector->dev;
788319d4 469 struct drm_display_mode *mode;
79e53945 470
3f8ff0e7 471 if (intel_lvds->edid)
219adae1 472 return drm_add_edid_modes(connector, intel_lvds->edid);
79e53945 473
788319d4 474 mode = drm_mode_duplicate(dev, intel_lvds->fixed_mode);
311bd68e 475 if (mode == NULL)
788319d4 476 return 0;
79e53945 477
788319d4
CW
478 drm_mode_probed_add(connector, mode);
479 return 1;
79e53945
JB
480}
481
0544edfd
TB
482static int intel_no_modeset_on_lid_dmi_callback(const struct dmi_system_id *id)
483{
bc0daf48 484 DRM_INFO("Skipping forced modeset for %s\n", id->ident);
0544edfd
TB
485 return 1;
486}
487
488/* The GPU hangs up on these systems if modeset is performed on LID open */
489static const struct dmi_system_id intel_no_modeset_on_lid[] = {
490 {
491 .callback = intel_no_modeset_on_lid_dmi_callback,
492 .ident = "Toshiba Tecra A11",
493 .matches = {
494 DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
495 DMI_MATCH(DMI_PRODUCT_NAME, "TECRA A11"),
496 },
497 },
498
499 { } /* terminating entry */
500};
501
c9354c85
LT
502/*
503 * Lid events. Note the use of 'modeset_on_lid':
504 * - we set it on lid close, and reset it on open
505 * - we use it as a "only once" bit (ie we ignore
506 * duplicate events where it was already properly
507 * set/reset)
508 * - the suspend/resume paths will also set it to
509 * zero, since they restore the mode ("lid open").
510 */
c1c7af60
JB
511static int intel_lid_notify(struct notifier_block *nb, unsigned long val,
512 void *unused)
513{
514 struct drm_i915_private *dev_priv =
515 container_of(nb, struct drm_i915_private, lid_notifier);
516 struct drm_device *dev = dev_priv->dev;
a2565377 517 struct drm_connector *connector = dev_priv->int_lvds_connector;
c1c7af60 518
2fb4e61d
AW
519 if (dev->switch_power_state != DRM_SWITCH_POWER_ON)
520 return NOTIFY_OK;
521
a2565377
ZY
522 /*
523 * check and update the status of LVDS connector after receiving
524 * the LID nofication event.
525 */
526 if (connector)
7b334fcb 527 connector->status = connector->funcs->detect(connector,
930a9e28 528 false);
7b334fcb 529
0544edfd
TB
530 /* Don't force modeset on machines where it causes a GPU lockup */
531 if (dmi_check_system(intel_no_modeset_on_lid))
532 return NOTIFY_OK;
c9354c85
LT
533 if (!acpi_lid_open()) {
534 dev_priv->modeset_on_lid = 1;
535 return NOTIFY_OK;
06891e27 536 }
c1c7af60 537
c9354c85
LT
538 if (!dev_priv->modeset_on_lid)
539 return NOTIFY_OK;
540
541 dev_priv->modeset_on_lid = 0;
542
543 mutex_lock(&dev->mode_config.mutex);
544 drm_helper_resume_force_mode(dev);
545 mutex_unlock(&dev->mode_config.mutex);
06324194 546
c1c7af60
JB
547 return NOTIFY_OK;
548}
549
79e53945
JB
550/**
551 * intel_lvds_destroy - unregister and free LVDS structures
552 * @connector: connector to free
553 *
554 * Unregister the DDC bus for this connector then free the driver private
555 * structure.
556 */
557static void intel_lvds_destroy(struct drm_connector *connector)
558{
c1c7af60 559 struct drm_device *dev = connector->dev;
c1c7af60 560 struct drm_i915_private *dev_priv = dev->dev_private;
79e53945 561
aaa6fd2a
MG
562 intel_panel_destroy_backlight(dev);
563
c1c7af60
JB
564 if (dev_priv->lid_notifier.notifier_call)
565 acpi_lid_notifier_unregister(&dev_priv->lid_notifier);
79e53945
JB
566 drm_sysfs_connector_remove(connector);
567 drm_connector_cleanup(connector);
568 kfree(connector);
569}
570
335041ed
JB
571static int intel_lvds_set_property(struct drm_connector *connector,
572 struct drm_property *property,
573 uint64_t value)
574{
788319d4 575 struct intel_lvds *intel_lvds = intel_attached_lvds(connector);
3fbe18d6 576 struct drm_device *dev = connector->dev;
3fbe18d6 577
788319d4
CW
578 if (property == dev->mode_config.scaling_mode_property) {
579 struct drm_crtc *crtc = intel_lvds->base.base.crtc;
bb8a3560 580
53bd8389
JB
581 if (value == DRM_MODE_SCALE_NONE) {
582 DRM_DEBUG_KMS("no scaling not supported\n");
788319d4 583 return -EINVAL;
3fbe18d6 584 }
788319d4 585
ea5b213a 586 if (intel_lvds->fitting_mode == value) {
3fbe18d6
ZY
587 /* the LVDS scaling property is not changed */
588 return 0;
589 }
ea5b213a 590 intel_lvds->fitting_mode = value;
3fbe18d6
ZY
591 if (crtc && crtc->enabled) {
592 /*
593 * If the CRTC is enabled, the display will be changed
594 * according to the new panel fitting mode.
595 */
596 drm_crtc_helper_set_mode(crtc, &crtc->mode,
597 crtc->x, crtc->y, crtc->fb);
598 }
599 }
600
335041ed
JB
601 return 0;
602}
603
79e53945
JB
604static const struct drm_encoder_helper_funcs intel_lvds_helper_funcs = {
605 .dpms = intel_lvds_dpms,
606 .mode_fixup = intel_lvds_mode_fixup,
607 .prepare = intel_lvds_prepare,
608 .mode_set = intel_lvds_mode_set,
609 .commit = intel_lvds_commit,
610};
611
612static const struct drm_connector_helper_funcs intel_lvds_connector_helper_funcs = {
613 .get_modes = intel_lvds_get_modes,
614 .mode_valid = intel_lvds_mode_valid,
df0e9248 615 .best_encoder = intel_best_encoder,
79e53945
JB
616};
617
618static const struct drm_connector_funcs intel_lvds_connector_funcs = {
c9fb15f6 619 .dpms = drm_helper_connector_dpms,
79e53945
JB
620 .detect = intel_lvds_detect,
621 .fill_modes = drm_helper_probe_single_connector_modes,
335041ed 622 .set_property = intel_lvds_set_property,
79e53945
JB
623 .destroy = intel_lvds_destroy,
624};
625
79e53945 626static const struct drm_encoder_funcs intel_lvds_enc_funcs = {
ea5b213a 627 .destroy = intel_encoder_destroy,
79e53945
JB
628};
629
425d244c
JW
630static int __init intel_no_lvds_dmi_callback(const struct dmi_system_id *id)
631{
bc0daf48 632 DRM_INFO("Skipping LVDS initialization for %s\n", id->ident);
425d244c
JW
633 return 1;
634}
79e53945 635
425d244c 636/* These systems claim to have LVDS, but really don't */
93c05f22 637static const struct dmi_system_id intel_no_lvds[] = {
425d244c
JW
638 {
639 .callback = intel_no_lvds_dmi_callback,
640 .ident = "Apple Mac Mini (Core series)",
641 .matches = {
98acd46f 642 DMI_MATCH(DMI_SYS_VENDOR, "Apple"),
425d244c
JW
643 DMI_MATCH(DMI_PRODUCT_NAME, "Macmini1,1"),
644 },
645 },
646 {
647 .callback = intel_no_lvds_dmi_callback,
648 .ident = "Apple Mac Mini (Core 2 series)",
649 .matches = {
98acd46f 650 DMI_MATCH(DMI_SYS_VENDOR, "Apple"),
425d244c
JW
651 DMI_MATCH(DMI_PRODUCT_NAME, "Macmini2,1"),
652 },
653 },
654 {
655 .callback = intel_no_lvds_dmi_callback,
656 .ident = "MSI IM-945GSE-A",
657 .matches = {
658 DMI_MATCH(DMI_SYS_VENDOR, "MSI"),
659 DMI_MATCH(DMI_PRODUCT_NAME, "A9830IMS"),
660 },
661 },
662 {
663 .callback = intel_no_lvds_dmi_callback,
664 .ident = "Dell Studio Hybrid",
665 .matches = {
666 DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
667 DMI_MATCH(DMI_PRODUCT_NAME, "Studio Hybrid 140g"),
668 },
669 },
70aa96ca
JW
670 {
671 .callback = intel_no_lvds_dmi_callback,
b066254f
PC
672 .ident = "Dell OptiPlex FX170",
673 .matches = {
674 DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
675 DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex FX170"),
676 },
677 },
678 {
679 .callback = intel_no_lvds_dmi_callback,
70aa96ca
JW
680 .ident = "AOpen Mini PC",
681 .matches = {
682 DMI_MATCH(DMI_SYS_VENDOR, "AOpen"),
683 DMI_MATCH(DMI_PRODUCT_NAME, "i965GMx-IF"),
684 },
685 },
ed8c754b
TV
686 {
687 .callback = intel_no_lvds_dmi_callback,
688 .ident = "AOpen Mini PC MP915",
689 .matches = {
690 DMI_MATCH(DMI_BOARD_VENDOR, "AOpen"),
691 DMI_MATCH(DMI_BOARD_NAME, "i915GMx-F"),
692 },
693 },
22ab70d3
KP
694 {
695 .callback = intel_no_lvds_dmi_callback,
696 .ident = "AOpen i915GMm-HFS",
697 .matches = {
698 DMI_MATCH(DMI_BOARD_VENDOR, "AOpen"),
699 DMI_MATCH(DMI_BOARD_NAME, "i915GMm-HFS"),
700 },
701 },
e57b6886
DV
702 {
703 .callback = intel_no_lvds_dmi_callback,
704 .ident = "AOpen i45GMx-I",
705 .matches = {
706 DMI_MATCH(DMI_BOARD_VENDOR, "AOpen"),
707 DMI_MATCH(DMI_BOARD_NAME, "i45GMx-I"),
708 },
709 },
fa0864b2
MC
710 {
711 .callback = intel_no_lvds_dmi_callback,
712 .ident = "Aopen i945GTt-VFA",
713 .matches = {
714 DMI_MATCH(DMI_PRODUCT_VERSION, "AO00001JW"),
715 },
716 },
9875557e
SB
717 {
718 .callback = intel_no_lvds_dmi_callback,
719 .ident = "Clientron U800",
720 .matches = {
721 DMI_MATCH(DMI_SYS_VENDOR, "Clientron"),
722 DMI_MATCH(DMI_PRODUCT_NAME, "U800"),
723 },
724 },
6a574b5b 725 {
44306ab3
JS
726 .callback = intel_no_lvds_dmi_callback,
727 .ident = "Clientron E830",
728 .matches = {
729 DMI_MATCH(DMI_SYS_VENDOR, "Clientron"),
730 DMI_MATCH(DMI_PRODUCT_NAME, "E830"),
731 },
732 },
733 {
6a574b5b
HG
734 .callback = intel_no_lvds_dmi_callback,
735 .ident = "Asus EeeBox PC EB1007",
736 .matches = {
737 DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK Computer INC."),
738 DMI_MATCH(DMI_PRODUCT_NAME, "EB1007"),
739 },
740 },
0999bbe0
AJ
741 {
742 .callback = intel_no_lvds_dmi_callback,
743 .ident = "Asus AT5NM10T-I",
744 .matches = {
745 DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
746 DMI_MATCH(DMI_BOARD_NAME, "AT5NM10T-I"),
747 },
748 },
33471119
JBG
749 {
750 .callback = intel_no_lvds_dmi_callback,
751 .ident = "Hewlett-Packard HP t5740e Thin Client",
752 .matches = {
753 DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
754 DMI_MATCH(DMI_PRODUCT_NAME, "HP t5740e Thin Client"),
755 },
756 },
f5b8a7ed
MG
757 {
758 .callback = intel_no_lvds_dmi_callback,
759 .ident = "Hewlett-Packard t5745",
760 .matches = {
761 DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
62004978 762 DMI_MATCH(DMI_PRODUCT_NAME, "hp t5745"),
f5b8a7ed
MG
763 },
764 },
765 {
766 .callback = intel_no_lvds_dmi_callback,
767 .ident = "Hewlett-Packard st5747",
768 .matches = {
769 DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
62004978 770 DMI_MATCH(DMI_PRODUCT_NAME, "hp st5747"),
f5b8a7ed
MG
771 },
772 },
97effadb
AA
773 {
774 .callback = intel_no_lvds_dmi_callback,
775 .ident = "MSI Wind Box DC500",
776 .matches = {
777 DMI_MATCH(DMI_BOARD_VENDOR, "MICRO-STAR INTERNATIONAL CO., LTD"),
778 DMI_MATCH(DMI_BOARD_NAME, "MS-7469"),
779 },
780 },
9756fe38
SS
781 {
782 .callback = intel_no_lvds_dmi_callback,
783 .ident = "ZOTAC ZBOXSD-ID12/ID13",
784 .matches = {
785 DMI_MATCH(DMI_BOARD_VENDOR, "ZOTAC"),
786 DMI_MATCH(DMI_BOARD_NAME, "ZBOXSD-ID12/ID13"),
787 },
788 },
425d244c
JW
789
790 { } /* terminating entry */
791};
79e53945 792
18f9ed12
ZY
793/**
794 * intel_find_lvds_downclock - find the reduced downclock for LVDS in EDID
795 * @dev: drm device
796 * @connector: LVDS connector
797 *
798 * Find the reduced downclock for LVDS in EDID.
799 */
800static void intel_find_lvds_downclock(struct drm_device *dev,
788319d4
CW
801 struct drm_display_mode *fixed_mode,
802 struct drm_connector *connector)
18f9ed12
ZY
803{
804 struct drm_i915_private *dev_priv = dev->dev_private;
788319d4 805 struct drm_display_mode *scan;
18f9ed12
ZY
806 int temp_downclock;
807
788319d4 808 temp_downclock = fixed_mode->clock;
18f9ed12
ZY
809 list_for_each_entry(scan, &connector->probed_modes, head) {
810 /*
811 * If one mode has the same resolution with the fixed_panel
812 * mode while they have the different refresh rate, it means
813 * that the reduced downclock is found for the LVDS. In such
814 * case we can set the different FPx0/1 to dynamically select
815 * between low and high frequency.
816 */
788319d4
CW
817 if (scan->hdisplay == fixed_mode->hdisplay &&
818 scan->hsync_start == fixed_mode->hsync_start &&
819 scan->hsync_end == fixed_mode->hsync_end &&
820 scan->htotal == fixed_mode->htotal &&
821 scan->vdisplay == fixed_mode->vdisplay &&
822 scan->vsync_start == fixed_mode->vsync_start &&
823 scan->vsync_end == fixed_mode->vsync_end &&
824 scan->vtotal == fixed_mode->vtotal) {
18f9ed12
ZY
825 if (scan->clock < temp_downclock) {
826 /*
827 * The downclock is already found. But we
828 * expect to find the lower downclock.
829 */
830 temp_downclock = scan->clock;
831 }
832 }
833 }
788319d4 834 if (temp_downclock < fixed_mode->clock && i915_lvds_downclock) {
18f9ed12
ZY
835 /* We found the downclock for LVDS. */
836 dev_priv->lvds_downclock_avail = 1;
837 dev_priv->lvds_downclock = temp_downclock;
838 DRM_DEBUG_KMS("LVDS downclock is found in EDID. "
788319d4
CW
839 "Normal clock %dKhz, downclock %dKhz\n",
840 fixed_mode->clock, temp_downclock);
18f9ed12 841 }
18f9ed12
ZY
842}
843
7cf4f69d
ZY
844/*
845 * Enumerate the child dev array parsed from VBT to check whether
846 * the LVDS is present.
847 * If it is present, return 1.
848 * If it is not present, return false.
849 * If no child dev is parsed from VBT, it assumes that the LVDS is present.
7cf4f69d 850 */
270eea0f
CW
851static bool lvds_is_present_in_vbt(struct drm_device *dev,
852 u8 *i2c_pin)
7cf4f69d
ZY
853{
854 struct drm_i915_private *dev_priv = dev->dev_private;
425904dd 855 int i;
7cf4f69d
ZY
856
857 if (!dev_priv->child_dev_num)
425904dd 858 return true;
7cf4f69d 859
7cf4f69d 860 for (i = 0; i < dev_priv->child_dev_num; i++) {
425904dd
CW
861 struct child_device_config *child = dev_priv->child_dev + i;
862
863 /* If the device type is not LFP, continue.
864 * We have to check both the new identifiers as well as the
865 * old for compatibility with some BIOSes.
7cf4f69d 866 */
425904dd
CW
867 if (child->device_type != DEVICE_TYPE_INT_LFP &&
868 child->device_type != DEVICE_TYPE_LFP)
7cf4f69d
ZY
869 continue;
870
3bd7d909
DK
871 if (intel_gmbus_is_port_valid(child->i2c_pin))
872 *i2c_pin = child->i2c_pin;
270eea0f 873
425904dd
CW
874 /* However, we cannot trust the BIOS writers to populate
875 * the VBT correctly. Since LVDS requires additional
876 * information from AIM blocks, a non-zero addin offset is
877 * a good indicator that the LVDS is actually present.
7cf4f69d 878 */
425904dd
CW
879 if (child->addin_offset)
880 return true;
881
882 /* But even then some BIOS writers perform some black magic
883 * and instantiate the device without reference to any
884 * additional data. Trust that if the VBT was written into
885 * the OpRegion then they have validated the LVDS's existence.
886 */
887 if (dev_priv->opregion.vbt)
888 return true;
7cf4f69d 889 }
425904dd
CW
890
891 return false;
7cf4f69d
ZY
892}
893
f3cfcba6
CW
894static bool intel_lvds_supported(struct drm_device *dev)
895{
896 /* With the introduction of the PCH we gained a dedicated
897 * LVDS presence pin, use it. */
898 if (HAS_PCH_SPLIT(dev))
899 return true;
900
901 /* Otherwise LVDS was only attached to mobile products,
902 * except for the inglorious 830gm */
903 return IS_MOBILE(dev) && !IS_I830(dev);
904}
905
79e53945
JB
906/**
907 * intel_lvds_init - setup LVDS connectors on this device
908 * @dev: drm device
909 *
910 * Create the connector, register the LVDS DDC bus, and try to figure out what
911 * modes we can display on the LVDS panel (if present).
912 */
c5d1b51d 913bool intel_lvds_init(struct drm_device *dev)
79e53945
JB
914{
915 struct drm_i915_private *dev_priv = dev->dev_private;
ea5b213a 916 struct intel_lvds *intel_lvds;
21d40d37 917 struct intel_encoder *intel_encoder;
bb8a3560 918 struct intel_connector *intel_connector;
79e53945
JB
919 struct drm_connector *connector;
920 struct drm_encoder *encoder;
921 struct drm_display_mode *scan; /* *modes, *bios_mode; */
922 struct drm_crtc *crtc;
923 u32 lvds;
270eea0f
CW
924 int pipe;
925 u8 pin;
79e53945 926
f3cfcba6
CW
927 if (!intel_lvds_supported(dev))
928 return false;
929
425d244c
JW
930 /* Skip init on machines we know falsely report LVDS */
931 if (dmi_check_system(intel_no_lvds))
c5d1b51d 932 return false;
565dcd46 933
270eea0f
CW
934 pin = GMBUS_PORT_PANEL;
935 if (!lvds_is_present_in_vbt(dev, &pin)) {
11ba1592 936 DRM_DEBUG_KMS("LVDS is not present in VBT\n");
c5d1b51d 937 return false;
38b3037e 938 }
e99da35f 939
c619eed4 940 if (HAS_PCH_SPLIT(dev)) {
541998a1 941 if ((I915_READ(PCH_LVDS) & LVDS_DETECTED) == 0)
c5d1b51d 942 return false;
5ceb0f9b 943 if (dev_priv->edp.support) {
28c97730 944 DRM_DEBUG_KMS("disable LVDS for eDP support\n");
c5d1b51d 945 return false;
32f9d658 946 }
541998a1
ZW
947 }
948
ea5b213a
CW
949 intel_lvds = kzalloc(sizeof(struct intel_lvds), GFP_KERNEL);
950 if (!intel_lvds) {
c5d1b51d 951 return false;
79e53945
JB
952 }
953
bb8a3560
ZW
954 intel_connector = kzalloc(sizeof(struct intel_connector), GFP_KERNEL);
955 if (!intel_connector) {
ea5b213a 956 kfree(intel_lvds);
c5d1b51d 957 return false;
bb8a3560
ZW
958 }
959
e9e331a8
CW
960 if (!HAS_PCH_SPLIT(dev)) {
961 intel_lvds->pfit_control = I915_READ(PFIT_CONTROL);
962 }
963
ea5b213a 964 intel_encoder = &intel_lvds->base;
4ef69c7a 965 encoder = &intel_encoder->base;
ea5b213a 966 connector = &intel_connector->base;
bb8a3560 967 drm_connector_init(dev, &intel_connector->base, &intel_lvds_connector_funcs,
79e53945
JB
968 DRM_MODE_CONNECTOR_LVDS);
969
4ef69c7a 970 drm_encoder_init(dev, &intel_encoder->base, &intel_lvds_enc_funcs,
79e53945
JB
971 DRM_MODE_ENCODER_LVDS);
972
df0e9248 973 intel_connector_attach_encoder(intel_connector, intel_encoder);
21d40d37 974 intel_encoder->type = INTEL_OUTPUT_LVDS;
79e53945 975
21d40d37 976 intel_encoder->clone_mask = (1 << INTEL_LVDS_CLONE_BIT);
27f8227b
JB
977 if (HAS_PCH_SPLIT(dev))
978 intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
0b9f43a0
DV
979 else if (IS_GEN4(dev))
980 intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
27f8227b
JB
981 else
982 intel_encoder->crtc_mask = (1 << 1);
983
79e53945
JB
984 drm_encoder_helper_add(encoder, &intel_lvds_helper_funcs);
985 drm_connector_helper_add(connector, &intel_lvds_connector_helper_funcs);
986 connector->display_info.subpixel_order = SubPixelHorizontalRGB;
987 connector->interlace_allowed = false;
988 connector->doublescan_allowed = false;
989
3fbe18d6
ZY
990 /* create the scaling mode property */
991 drm_mode_create_scaling_mode_property(dev);
992 /*
993 * the initial panel fitting mode will be FULL_SCREEN.
994 */
79e53945 995
bb8a3560 996 drm_connector_attach_property(&intel_connector->base,
3fbe18d6 997 dev->mode_config.scaling_mode_property,
dd1ea37d 998 DRM_MODE_SCALE_ASPECT);
ea5b213a 999 intel_lvds->fitting_mode = DRM_MODE_SCALE_ASPECT;
79e53945
JB
1000 /*
1001 * LVDS discovery:
1002 * 1) check for EDID on DDC
1003 * 2) check for VBT data
1004 * 3) check to see if LVDS is already on
1005 * if none of the above, no panel
1006 * 4) make sure lid is open
1007 * if closed, act like it's not there for now
1008 */
1009
79e53945
JB
1010 /*
1011 * Attempt to get the fixed panel mode from DDC. Assume that the
1012 * preferred mode is the right one.
1013 */
219adae1 1014 intel_lvds->edid = drm_get_edid(connector,
3bd7d909
DK
1015 intel_gmbus_get_adapter(dev_priv,
1016 pin));
3f8ff0e7
CW
1017 if (intel_lvds->edid) {
1018 if (drm_add_edid_modes(connector,
1019 intel_lvds->edid)) {
1020 drm_mode_connector_update_edid_property(connector,
1021 intel_lvds->edid);
1022 } else {
1023 kfree(intel_lvds->edid);
1024 intel_lvds->edid = NULL;
1025 }
1026 }
219adae1 1027 if (!intel_lvds->edid) {
788319d4
CW
1028 /* Didn't get an EDID, so
1029 * Set wide sync ranges so we get all modes
1030 * handed to valid_mode for checking
1031 */
1032 connector->display_info.min_vfreq = 0;
1033 connector->display_info.max_vfreq = 200;
1034 connector->display_info.min_hfreq = 0;
1035 connector->display_info.max_hfreq = 200;
1036 }
79e53945
JB
1037
1038 list_for_each_entry(scan, &connector->probed_modes, head) {
79e53945 1039 if (scan->type & DRM_MODE_TYPE_PREFERRED) {
788319d4 1040 intel_lvds->fixed_mode =
79e53945 1041 drm_mode_duplicate(dev, scan);
788319d4
CW
1042 intel_find_lvds_downclock(dev,
1043 intel_lvds->fixed_mode,
1044 connector);
565dcd46 1045 goto out;
79e53945 1046 }
79e53945
JB
1047 }
1048
1049 /* Failed to get EDID, what about VBT? */
88631706 1050 if (dev_priv->lfp_lvds_vbt_mode) {
788319d4 1051 intel_lvds->fixed_mode =
88631706 1052 drm_mode_duplicate(dev, dev_priv->lfp_lvds_vbt_mode);
788319d4
CW
1053 if (intel_lvds->fixed_mode) {
1054 intel_lvds->fixed_mode->type |=
e285f3cd 1055 DRM_MODE_TYPE_PREFERRED;
e285f3cd
JB
1056 goto out;
1057 }
79e53945
JB
1058 }
1059
1060 /*
1061 * If we didn't get EDID, try checking if the panel is already turned
1062 * on. If so, assume that whatever is currently programmed is the
1063 * correct mode.
1064 */
541998a1 1065
f2b115e6 1066 /* Ironlake: FIXME if still fail, not try pipe mode now */
c619eed4 1067 if (HAS_PCH_SPLIT(dev))
541998a1
ZW
1068 goto failed;
1069
79e53945
JB
1070 lvds = I915_READ(LVDS);
1071 pipe = (lvds & LVDS_PIPEB_SELECT) ? 1 : 0;
f875c15a 1072 crtc = intel_get_crtc_for_pipe(dev, pipe);
79e53945
JB
1073
1074 if (crtc && (lvds & LVDS_PORT_EN)) {
788319d4
CW
1075 intel_lvds->fixed_mode = intel_crtc_mode_get(dev, crtc);
1076 if (intel_lvds->fixed_mode) {
1077 intel_lvds->fixed_mode->type |=
79e53945 1078 DRM_MODE_TYPE_PREFERRED;
565dcd46 1079 goto out;
79e53945
JB
1080 }
1081 }
1082
1083 /* If we still don't have a mode after all that, give up. */
788319d4 1084 if (!intel_lvds->fixed_mode)
79e53945
JB
1085 goto failed;
1086
79e53945 1087out:
24ded204
DV
1088 /*
1089 * Unlock registers and just
1090 * leave them unlocked
1091 */
c619eed4 1092 if (HAS_PCH_SPLIT(dev)) {
ed10fca9
KP
1093 I915_WRITE(PCH_PP_CONTROL,
1094 I915_READ(PCH_PP_CONTROL) | PANEL_UNLOCK_REGS);
1095 } else {
ed10fca9
KP
1096 I915_WRITE(PP_CONTROL,
1097 I915_READ(PP_CONTROL) | PANEL_UNLOCK_REGS);
541998a1 1098 }
c1c7af60
JB
1099 dev_priv->lid_notifier.notifier_call = intel_lid_notify;
1100 if (acpi_lid_notifier_register(&dev_priv->lid_notifier)) {
28c97730 1101 DRM_DEBUG_KMS("lid notifier registration failed\n");
c1c7af60
JB
1102 dev_priv->lid_notifier.notifier_call = NULL;
1103 }
a2565377
ZY
1104 /* keep the LVDS connector */
1105 dev_priv->int_lvds_connector = connector;
79e53945 1106 drm_sysfs_connector_add(connector);
aaa6fd2a
MG
1107
1108 intel_panel_setup_backlight(dev);
1109
c5d1b51d 1110 return true;
79e53945
JB
1111
1112failed:
8a4c47f3 1113 DRM_DEBUG_KMS("No LVDS modes found, disabling.\n");
79e53945 1114 drm_connector_cleanup(connector);
1991bdfa 1115 drm_encoder_cleanup(encoder);
ea5b213a 1116 kfree(intel_lvds);
bb8a3560 1117 kfree(intel_connector);
c5d1b51d 1118 return false;
79e53945 1119}